You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-23] [$175] Make the GPS distance counter label a fully localized phrase #103488
the amount and unit come before the "Distance" label
The unit is also shown as the raw value and is never translated.
Proposed fix
Replace the joined pieces with one full phrase in src/languages/en.ts and every other language file. Mark up its parts (amount, unit, label) so RenderHTML can style them, like the bold amount and muted unit shown today. Each locale then controls word order and spacing.
Generally, we're going to want to use Intl.NumberFormat here.
// plumb locale and unit as appropriateconstformatter=newIntl.NumberFormat('en-US',{style: 'unit',unit: 'kilometer',unitDisplay: 'short'});constparts=formatter.formatToParts(distance);
Assuming I'm reading the existing code correctly, to match the current styling behavior, we want to render them in the order that they're returned, wrapping just the type === 'unit' part with styles.colorMuted.
Feel free to extend libs/NumberFormatUtils as appropriate
changed the title [-]Make the GPS distance counter label a fully localized phrase[/-][+][$175] Make the GPS distance counter label a fully localized phrase[/+]on Oct 8, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.12-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-23. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A. This a refactoring issue
Link to the comment on the Issue: N/A. This a refactoring issue
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
This is a straightforward change, so I don’t think we need a regression test here.
Activity
chuckdries commentedon Oct 8, 2026
I can take this one
chuckdries commentedon Oct 8, 2026
Generally, we're going to want to use Intl.NumberFormat here.
partsshould be an array something likeAssuming I'm reading the existing code correctly, to match the current styling behavior, we want to render them in the order that they're returned, wrapping just the
type === 'unit'part withstyles.colorMuted.Feel free to extend
libs/NumberFormatUtilsas appropriatemelvin-bot commentedon Oct 8, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (
External)[-]Make the GPS distance counter label a fully localized phrase[/-][+][$175] Make the GPS distance counter label a fully localized phrase[/+]melvin-bot commentedon Oct 8, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022108234900806244629
yuvrajangadsingh commentedon Oct 8, 2026
withdrawing this, it went up before the issue had the
Help Wantedlabel. will come back if the label is added.22 remaining items
melvin-bot commentedon Oct 16, 2026
@ahmedGaber93
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.12-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-23. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 16, 2026
@ahmedGaber93 Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Oct 20, 2026
@ahmedGaber93 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Oct 22, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 22, 2026
Payment Summary
Resolving PRs:
Localize the GPS distance counter number and unit with Intl.NumberFormat #103796
Reviewer: @ahmedGaber93 owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
ahmedGaber93 commentedon Oct 23, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: N/A. This a refactoring issue
Link to the comment on the Issue: N/A. This a refactoring issue
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
This is a straightforward change, so I don’t think we need a regression test here.
mallenexpensify commentedon Oct 26, 2026
Payment Summary
Contributor+: @ahmedGaber93 due $175 via NewDot
flaviadefaria commentedon Nov 9, 2026
Approved: @ahmedGaber93 due $175 via NewDot