Skip to content

[Due for payment 2026-11-03] [Insights polish R1] Add spinner with fade-in for charts. #103964

Closed

Description

@JmillsExpensify

This is just an issue to accompany the PR.

Issue OwnerCurrent Issue Owner: @daledah

Activity

  1. added
    ImprovementItem broken or needs improvement.
    InternalRequires API changes or must be handled by Expensify staff
    on Oct 14, 2026
  2. sharabai commented on Oct 14, 2026

    @sharabai
    Contributor

    @daledah you're the C+ on most of the other R1 Insights issues. Could you take the C+ review on #103684?

  3. JmillsExpensify commented on Oct 14, 2026

    @JmillsExpensify
    ContributorAuthor

    Added

  4. daledah commented on Oct 14, 2026

    @daledah
    Contributor

    Thanks @sharabai for the PR. I’ll review it in a couple of hours.

  5. changed the title [-][Insights polish R1] Add spinner with fade-in for charts.[/-] [+][Due for payment 2026-10-23] [Insights polish R1] Add spinner with fade-in for charts.[/+] on Oct 16, 2026
  6. 12 remaining items

  7. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  8. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  9. mallenexpensify commented on Oct 26, 2026

    @mallenexpensify
    Contributor

    Payment Summary

    Contributor+: @daledah due $250 via NewDot

    comment/reopen if we need a test case

  10. JmillsExpensify commented on Oct 26, 2026

    @JmillsExpensify
    ContributorAuthor

    I don't think it's required for this one.

  11. jponikarchuk commented on Oct 27, 2026

    @jponikarchuk

    Deploy Blocker #105108 was identified to be related to the PR #103210 that attempted to fix this issue.

  12. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  13. changed the title [-][Due for payment 2026-10-23] [Insights polish R1] Add spinner with fade-in for charts.[/-] [+][Due for payment 2026-11-03] [Insights polish R1] Add spinner with fade-in for charts.[/+] on Oct 27, 2026
  14. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    @daledah @mallenexpensify

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.23-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-03. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  15. added
    ReviewingHas a PR in review
    and removed on Nov 9, 2026
  16. quinthar commented on Nov 15, 2026

    @quinthar
    Contributor

    Approved $250 to @daledah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions