You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-23] [$175] Onboarding - Device back button doesn´t return to previous step on join workspace intent #104023
Version Number: 9.5.9-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#99833 Email or phone of affected tester (no customers):ibellicotest+3253@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) App Component: Other
Action Performed:
Open the Expensify app.
Sign up with a new account.
Select "Join my company workspace" during onboarding.
On "What´s your work Email?", use device´s back button to return to previous step.
Note that a "Please finish the setup questions to start using the app" error is triggered and you remain on the same step.
Tap on back button on the top left corner.
Note that now, you return to previous step, but "Please finish the setup questions to start using the app" error is still visible.
Expected Result:
After seleting join workspace intent, user should be able to return to previous step using device´s back button or app´s back button.
Actual Result:
After selecting join workspace intent during onboarding, user is unable to return from "What´s your work Email?" to previous step using device´s back button. "Please finish the setup questions to start using the app" error is triggered with that action, and error remains on previous step after returning using app´s back button.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root cause: The new intent makes "What's your work email?" a second step. The Android wrapper still blocks every hardware back press and sets the error. See index.native.tsx:13-25. The header back button (BaseOnboardingWorkEmail.tsx:365) navigates without clearing the Onyx error. The intent list then shows that error.
Recommendation: Use a targeted fix. Revert #103652 only if the fix can't land quickly.
In OnboardingWorkEmail/index.native.tsx, block hardware back only when the screen is the first route. Copy the routeIndex !== 0 early return from OnboardingPersonalDetails/index.native.tsx:10-18.
In the header back handler, clear the error before calling Navigation.goBack.
Why the error persists: the intent list reads the shared error key (BaseOnboardingPurpose.tsx:84) and shows it (L253). It clears the error only when the user taps a choice (L128).
These open PRs are related but don't unblock hardware back, so fix 1 is still needed:
Activity
applause-bot commentedon Oct 14, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/ef628a3d3083a280f7510eb6a99fa704018546a46046b616982c23f0b3a2135d
melvin-bot commentedon Oct 14, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #99833
github-actions commentedon Oct 14, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 14, 2026
@iwiznia @hungvu193 you have been assigned to this deploy blocker because you reviewed the offending PR: #99833
melvin-bot commentedon Oct 14, 2026
@carlosmiceli you have been assigned to this deploy blocker because you authored the offending PR: #99833
melvin-bot commentedon Oct 14, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 14, 2026
Deploy Blocker Analysis
Causing PR: [Payment due @abzokhattab] Add the join-workspace onboarding intent and Concierge follow up tasks (
Expensify/App#103652). It re-lands Add the join-workspace onboarding intent and Concierge follow up tasks, which Melvin flagged. Both are on this checklist. The code on staging matches #103652. Confidence: high.Root cause: The new intent makes "What's your work email?" a second step. The Android wrapper still blocks every hardware back press and sets the error. See index.native.tsx:13-25. The header back button (BaseOnboardingWorkEmail.tsx:365) navigates without clearing the Onyx error. The intent list then shows that error.
Recommendation: Use a targeted fix. Revert #103652 only if the fix can't land quickly.
OnboardingWorkEmail/index.native.tsx, block hardware back only when the screen is the first route. Copy therouteIndex !== 0early return from OnboardingPersonalDetails/index.native.tsx:10-18.Navigation.goBack.Investigation details
Navigation.goBack(ROUTES.ONBOARDING_PURPOSE.getRoute()), which matches [Payment due @abzokhattab] Add the join-workspace onboarding intent and Concierge follow up tasks #103652. Neither PR changedindex.native.tsx.abzokhattabapproved [Payment due @abzokhattab] Add the join-workspace onboarding intent and Concierge follow up tasks #103652 but isn't assigned here.Next Steps: Reply with
@MelvinBot implement thisto create a draft PR, or@MelvinBot <your feedback>to refine this analysis.view run
14 remaining items
FitseTLT commentedon Oct 16, 2026
I was only involved to reviewing pr that fixed the DP.
melvin-bot commentedon Oct 22, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 22, 2026
Payment Summary
Resolving PRs:
Let Android back leave onboarding work email when the intent list opened it #104025
Contributor: @hungvu193 does not require payment (Contractor)
Reviewer: @FitseTLT owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Oct 26, 2026
Payment Summary
Contributor+: @FitseTLT due $175 via NewDot
flaviadefaria commentedon Nov 9, 2026
Approved: @FitseTLT due $175 via NewDot