You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-30] Fix false missingAttendees violation in Search rows #104546
In Spend → Reports, a report row shows "Report contains expenses with violations.", but the opened report shows no errors. In Spend → Expenses, its expenses show "Multiple attendees required for this category." until the expense or report is opened. Both Search rows re-check the missing-attendees violation on the client and read the top-level attendees field from snapshot data, which is never set, because the attendees live in comment.attendees.
Solution
ExpenseReportListItem and TransactionListItem now read attendees with getAttendees(), which returns modifiedAttendees ?? comment.attendees. This is the same source the Search attendees column already uses, so the rows see the real attendees from snapshot data and no longer add a false missingAttendees violation.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Create a WS setup-requires-attendees rule for a category. Invite a member. As a member, create an expense with the category with the rule and add two attendees.
Test:
Log in as the admin/owner/approver, or reset the cache if already logged in
Go Spend > Expense
Verify that the member's expense doesn't show the attendees violation.
Activity
VickyStash commentedon Oct 21, 2026
PR is ready for the review: #104540
nkdengineer commentedon Oct 22, 2026
Assigned here as I'm the reviewer of the PR.
4 remaining items
nkdengineer commentedon Oct 27, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: https://github.com/Expensify/App/pull/79050/changes#r4394726168
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Oct 29, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Oct 29, 2026
Payment Summary
Resolving PRs:
Fix false missingAttendees violation in Search rows #104540
Contributor: @VickyStash does not require payment (Contractor)
Reviewer: @nkdengineer owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Nov 2, 2026
Payment Summary
Contributor+: @nkdengineer due $175 via NewDot