Skip to content

[Due for payment 2026-11-13] [$175] Spend - Not here page opens after clicking split row on Date tab when opened from Spend #105152

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.23-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/80732943/folder/57599982/71461417/1913501751?sort=-identifier
Email or phone of affected tester (no customers): idjosjosijdosj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create an expense.
  4. Go to Spend > Expenses.
  5. Select the expense via checkbox.
  6. Click More > Split.
  7. Go to Date tab.
  8. Click on any split.

Expected Result:

Split page will open.

Actual Result:

Not here page opens after clicking split row on Date tab when opened from Spend.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7298089_1793114406406.7.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7298089

Upwork Automation - Do Not Edit
Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 27, 2026
  2. applause-bot commented on Oct 27, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/06b9edce8b8c1a7c18d44d420c809414048ce0528370b6dbcd55ca064fbf7bb3

  3. MelvinBot commented on Oct 27, 2026

    @MelvinBot
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    When the split flow is opened from Spend > Expenses, clicking a split row on the Date tab shows the "Hmm... it's not here" page instead of the split edit page.

    What is the root cause of that problem?

    A legacy URL redirect catches the split edit URL and rewrites it into a broken expense-date URL.

    • When opened from Search, the split edit URL on the Date tab is /search/split-expense-overview-search/date/split-expense/edit/<reportID>/<transactionID>. The date tab name is the third path segment.
    • The legacy pattern '/*/*/date/*/*/*' in OldRoutes.ts:222 matches any path whose third segment is date. It rewrites the URL to /r/edit/expense-date?action=search&iouType=split-expense-overview-search&transactionID=split-expense&reportID=edit….
    • Report edit and transaction split-expense don't exist, so the Not Here page shows.

    This only happens from Spend, and only on the Date tab:

    • From a chat, the base is /r/<reportID>, so date is not the third segment.
    • The other tabs use amount and percentage, which no legacy pattern matches.
    Code path
    1. More > Split calls initSplitExpense. Search opens split-expense-overview-search (SplitExpenses.ts:243-244).
    2. The active tab is a child path segment (amount / percentage / date) (config.ts:1961-1988).
    3. All tabs share onSelectRow. It appends the dynamic SPLIT_EXPENSE_EDIT suffix to the current path (DynamicSplitExpensePage.tsx:610-626).
    4. getMatchingNewRoute runs before normal route parsing and picks the longest matching legacy pattern. A trailing * matches the rest of the path (getMatchingNewRoute.ts:15-29). The edit page's own not-found check never runs.

    Likely regression source: the clash appeared after the date legacy patterns from Migrate money request merchant, description and date steps to dynamic met the new Search split URLs from Migrate split expense routes to dynamic URL navigation and migrate SPLIT_EXPENSE_EDIT. I didn't confirm which PR first introduced it.

    What changes do you think we should make in order to solve the problem?

    In OldRoutes.ts, add a pass-through entry so split edit URLs under the date tab are left unchanged. The file already does this for participants at OldRoutes.ts:224.

    • Pattern: '/*/*/date/split-expense/edit/*', mapped to '/$1/$2/date/split-expense/edit/$3'.
    • It is longer than '/*/*/date/*/*/*', so it wins.

    Add cases to tests/navigation/getMatchingNewRouteTest.ts:

    • The Search split edit URL under date comes back unchanged.
    • A legacy URL such as /edit/submit/date/123/456 still redirects.

    What alternative solutions did you explore? (Optional)

    • Rename the Date tab's path segment in config.ts (for example, by-date) for both split screens. This fixes the clash at its source but changes existing tab URLs.
    • Make getMatchingNewRoute skip legacy redirects when the path already resolves to a registered dynamic route. This is broader and also protects against other '/*/*/<keyword>/*/*' patterns.
    Web reproduction

    I reproduced this on web. The Date tab row opens the Not Here page, and the Amount tab row opens the edit page.

    Date tab row Amount tab row
    Date tab split row opens Not here page Amount tab split row opens split edit page

    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/105152) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run · no recording available

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 27, 2026
  5. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

  6. changed the title [-]Spend - Not here page opens after clicking split row on Date tab when opened from Spend[/-] [+][$175] Spend - Not here page opens after clicking split row on Date tab when opened from Spend[/+] on Oct 27, 2026
  7. melvin-bot commented on Oct 27, 2026

    @melvin-bot
  8. Stephen3453 commented on Oct 27, 2026

    @Stephen3453

    Proposal

    What is the root cause of that problem?

    getMatchingNewRoute (src/libs/Navigation/helpers/getMatchingNewRoute.ts) runs every path through the legacy oldRoutes table and picks the longest matching pattern. Its regex is anchored (^…(?=[?#]|$)), a non-trailing * is one segment, and a trailing * is (.*).

    The legacy pattern '/*/*/date/*/*/*' (OldRoutes.ts:222) matches /search/split-expense-overview-search/date/split-expense/edit/<reportID>/<transactionID>, because when the split flow is opened from Spend the Date tab name is the third segment. It rewrites it to /r/edit/expense-date?..., a report that does not exist, so Not Here shows. From a chat the base is /r/<reportID>, so date is not third. The amount and percentage tabs have no legacy pattern, so they are fine.

    What changes do you think we should make in order to solve the problem?

    In OldRoutes.ts, next to the participants pass-through at line 224, add:
    '/*/*/date/split-expense/edit/*': '/$1/$2/date/split-expense/edit/$3'.
    It is longer than '/*/*/date/*/*/*', so maxLength selects it and the URL comes back unchanged. The literal split-expense/edit keeps real legacy date URLs (/edit/submit/date/<txn>/<report>) redirecting.

    Test, in tests/navigation/getMatchingNewRouteTest.ts (same expect(getMatchingNewRoute(...)) style):

    • The Search split-edit URL under date returns unchanged, with and without ?backTo=....
    • /edit/submit/date/123/456 still returns /r/456/expense-date?....

    What alternative solutions did you explore? (Optional)

    • MelvinBot's proposal reaches the same root cause and the same pass-through. Mine adds the ?backTo case, which matters because the split-edit URL carries a query, and the guard that real legacy date URLs still redirect.
    • MelvinBot's alternatives (renaming the Date tab segment in config.ts, or making getMatchingNewRoute skip redirects for registered dynamic routes) are broader. I rejected them for this bug: the first changes existing tab URLs, the second needs a route-registry lookup inside a pure string helper.
  9. j3ffffff commented on Oct 27, 2026

    @j3ffffff
  10. camesenin commented on Oct 27, 2026

    @camesenin
  11. melvin-bot commented on Oct 27, 2026

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  12. apoorv-xs commented on Oct 27, 2026

    @apoorv-xs
  13. 28 remaining items

  14. melvin-bot commented on Nov 7, 2026

    @melvin-bot
  15. melvin-bot commented on Nov 9, 2026

    @melvin-bot

    @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. situchan commented on Nov 11, 2026

    @situchan
    Contributor

    @MelvinBot find offending PR

  17. MelvinBot commented on Nov 11, 2026

    @MelvinBot
    Contributor

    The offending PR is migrate SPLIT_EXPENSE_EDIT — merged August 26, 2026. High confidence from historical code comparison.

    It changed split-row navigation from a standalone edit URL to a dynamic suffix appended to the active Date-tab URL:

    /search/split-expense-overview-search/date/split-expense/edit/<reportID>/<transactionID>

    That URL matches the existing legacy date redirect, which rewrites it to /r/edit/expense-date?..., causing Not Here.

    The other two migrations were prerequisites, not the final trigger:

    The matcher already supported this collision when the offending PR merged; no later matcher change was needed.


    view run

  18. situchan commented on Nov 11, 2026

    @situchan
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: migrate SPLIT_EXPENSE_EDIT #98547 (comment)
      Link to the comment on the Issue:

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion:

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    Regression Test Proposal

    Test:

    1. Go to workspace chat.
    2. Create an expense.
    3. Go to Spend > Expenses.
    4. Select the expense via checkbox.
    5. Click More > Split.
    6. Go to Date tab.
    7. Click on any split.
    8. Verify the split page opens (not the "Hmm... it's not here" page).

    Do we agree 👍 or 👎

  19. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 11, 2026
  20. melvin-bot commented on Nov 12, 2026

    @melvin-bot

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  21. melvin-bot commented on Nov 12, 2026

    @melvin-bot

    Payment Summary

    Resolving PRs:

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  22. mallenexpensify commented on Nov 16, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    Ready. Job price: $175 (title).

    • situchan (C+): 100%, via NewDot

    No deploy blockers or regressions on the issue or the PR.

    Next: press Caps+Y, then pay.

    Evidence
    • C+ checklist, 8 test steps: comment
    • TestRail case: none yet.
    • Resolving PR #105749: by MelvinBot, merged 2026-11-04, approved by joekaufmanexpensify, neil-marcellini and situchan. No revert.
    • Offending PR migrate SPLIT_EXPENSE_EDIT #98547 by huult, reviewed by suneox: production 2026-08-27, bug filed 2026-10-27. Outside the window, no cut.
    • Videos: C+ 2/5.

    PAYPREP v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions