You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-13] [$175] Spend - Not here page opens after clicking split row on Date tab when opened from Spend #105152
Please re-state the problem that we are trying to solve in this issue.
When the split flow is opened from Spend > Expenses, clicking a split row on the Date tab shows the "Hmm... it's not here" page instead of the split edit page.
What is the root cause of that problem?
A legacy URL redirect catches the split edit URL and rewrites it into a broken expense-date URL.
When opened from Search, the split edit URL on the Date tab is /search/split-expense-overview-search/date/split-expense/edit/<reportID>/<transactionID>. The date tab name is the third path segment.
The legacy pattern '/*/*/date/*/*/*' in OldRoutes.ts:222 matches any path whose third segment is date. It rewrites the URL to /r/edit/expense-date?action=search&iouType=split-expense-overview-search&transactionID=split-expense&reportID=edit….
Report edit and transaction split-expense don't exist, so the Not Here page shows.
This only happens from Spend, and only on the Date tab:
From a chat, the base is /r/<reportID>, so date is not the third segment.
The other tabs use amount and percentage, which no legacy pattern matches.
Code path
More > Split calls initSplitExpense. Search opens split-expense-overview-search (SplitExpenses.ts:243-244).
The active tab is a child path segment (amount / percentage / date) (config.ts:1961-1988).
getMatchingNewRoute runs before normal route parsing and picks the longest matching legacy pattern. A trailing * matches the rest of the path (getMatchingNewRoute.ts:15-29). The edit page's own not-found check never runs.
What changes do you think we should make in order to solve the problem?
In OldRoutes.ts, add a pass-through entry so split edit URLs under the date tab are left unchanged. The file already does this for participants at OldRoutes.ts:224.
Pattern: '/*/*/date/split-expense/edit/*', mapped to '/$1/$2/date/split-expense/edit/$3'.
It is longer than '/*/*/date/*/*/*', so it wins.
Add cases to tests/navigation/getMatchingNewRouteTest.ts:
The Search split edit URL under date comes back unchanged.
A legacy URL such as /edit/submit/date/123/456 still redirects.
What alternative solutions did you explore? (Optional)
Rename the Date tab's path segment in config.ts (for example, by-date) for both split screens. This fixes the clash at its source but changes existing tab URLs.
Make getMatchingNewRoute skip legacy redirects when the path already resolves to a registered dynamic route. This is broader and also protects against other '/*/*/<keyword>/*/*' patterns.
Web reproduction
I reproduced this on web. The Date tab row opens the Not Here page, and the Amount tab row opens the edit page.
Date tab row
Amount tab row
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/105152) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Spend - Not here page opens after clicking split row on Date tab when opened from Spend[/-][+][$175] Spend - Not here page opens after clicking split row on Date tab when opened from Spend[/+]on Oct 27, 2026
getMatchingNewRoute (src/libs/Navigation/helpers/getMatchingNewRoute.ts) runs every path through the legacy oldRoutes table and picks the longest matching pattern. Its regex is anchored (^…(?=[?#]|$)), a non-trailing * is one segment, and a trailing * is (.*).
The legacy pattern '/*/*/date/*/*/*' (OldRoutes.ts:222) matches /search/split-expense-overview-search/date/split-expense/edit/<reportID>/<transactionID>, because when the split flow is opened from Spend the Date tab name is the third segment. It rewrites it to /r/edit/expense-date?..., a report that does not exist, so Not Here shows. From a chat the base is /r/<reportID>, so date is not third. The amount and percentage tabs have no legacy pattern, so they are fine.
What changes do you think we should make in order to solve the problem?
In OldRoutes.ts, next to the participants pass-through at line 224, add: '/*/*/date/split-expense/edit/*': '/$1/$2/date/split-expense/edit/$3'.
It is longer than '/*/*/date/*/*/*', so maxLength selects it and the URL comes back unchanged. The literal split-expense/edit keeps real legacy date URLs (/edit/submit/date/<txn>/<report>) redirecting.
Test, in tests/navigation/getMatchingNewRouteTest.ts (same expect(getMatchingNewRoute(...)) style):
The Search split-edit URL under date returns unchanged, with and without ?backTo=....
/edit/submit/date/123/456 still returns /r/456/expense-date?....
What alternative solutions did you explore? (Optional)
MelvinBot's proposal reaches the same root cause and the same pass-through. Mine adds the ?backTo case, which matters because the split-edit URL carries a query, and the guard that real legacy date URLs still redirect.
MelvinBot's alternatives (renaming the Date tab segment in config.ts, or making getMatchingNewRoute skip redirects for registered dynamic routes) are broader. I rejected them for this bug: the first changes existing tab URLs, the second needs a route-registry lookup inside a pure string helper.
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Go to workspace chat.
Create an expense.
Go to Spend > Expenses.
Select the expense via checkbox.
Click More > Split.
Go to Date tab.
Click on any split.
Verify the split page opens (not the "Hmm... it's not here" page).
Activity
applause-bot commentedon Oct 27, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/06b9edce8b8c1a7c18d44d420c809414048ce0528370b6dbcd55ca064fbf7bb3
MelvinBot commentedon Oct 27, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When the split flow is opened from Spend > Expenses, clicking a split row on the Date tab shows the "Hmm... it's not here" page instead of the split edit page.
What is the root cause of that problem?
A legacy URL redirect catches the split edit URL and rewrites it into a broken expense-date URL.
/search/split-expense-overview-search/date/split-expense/edit/<reportID>/<transactionID>. Thedatetab name is the third path segment.'/*/*/date/*/*/*'inOldRoutes.ts:222matches any path whose third segment isdate. It rewrites the URL to/r/edit/expense-date?action=search&iouType=split-expense-overview-search&transactionID=split-expense&reportID=edit….editand transactionsplit-expensedon't exist, so the Not Here page shows.This only happens from Spend, and only on the Date tab:
/r/<reportID>, sodateis not the third segment.amountandpercentage, which no legacy pattern matches.Code path
initSplitExpense. Search openssplit-expense-overview-search(SplitExpenses.ts:243-244).amount/percentage/date) (config.ts:1961-1988).onSelectRow. It appends the dynamicSPLIT_EXPENSE_EDITsuffix to the current path (DynamicSplitExpensePage.tsx:610-626).getMatchingNewRouteruns before normal route parsing and picks the longest matching legacy pattern. A trailing*matches the rest of the path (getMatchingNewRoute.ts:15-29). The edit page's own not-found check never runs.Likely regression source: the clash appeared after the
datelegacy patterns from Migrate money request merchant, description and date steps to dynamic met the new Search split URLs from Migrate split expense routes to dynamic URL navigation and migrate SPLIT_EXPENSE_EDIT. I didn't confirm which PR first introduced it.What changes do you think we should make in order to solve the problem?
In
OldRoutes.ts, add a pass-through entry so split edit URLs under thedatetab are left unchanged. The file already does this for participants atOldRoutes.ts:224.'/*/*/date/split-expense/edit/*', mapped to'/$1/$2/date/split-expense/edit/$3'.'/*/*/date/*/*/*', so it wins.Add cases to
tests/navigation/getMatchingNewRouteTest.ts:datecomes back unchanged./edit/submit/date/123/456still redirects.What alternative solutions did you explore? (Optional)
config.ts(for example,by-date) for both split screens. This fixes the clash at its source but changes existing tab URLs.getMatchingNewRouteskip legacy redirects when the path already resolves to a registered dynamic route. This is broader and also protects against other'/*/*/<keyword>/*/*'patterns.Web reproduction
I reproduced this on web. The Date tab row opens the Not Here page, and the Amount tab row opens the edit page.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/105152)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run · no recording available
melvin-bot commentedon Oct 27, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (
External)[-]Spend - Not here page opens after clicking split row on Date tab when opened from Spend[/-][+][$175] Spend - Not here page opens after clicking split row on Date tab when opened from Spend[/+]melvin-bot commentedon Oct 27, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022115112485992206644
Stephen3453 commentedon Oct 27, 2026
Proposal
What is the root cause of that problem?
getMatchingNewRoute(src/libs/Navigation/helpers/getMatchingNewRoute.ts) runs every path through the legacyoldRoutestable and picks the longest matching pattern. Its regex is anchored (^…(?=[?#]|$)), a non-trailing*is one segment, and a trailing*is(.*).The legacy pattern
'/*/*/date/*/*/*'(OldRoutes.ts:222) matches/search/split-expense-overview-search/date/split-expense/edit/<reportID>/<transactionID>, because when the split flow is opened from Spend the Date tab name is the third segment. It rewrites it to/r/edit/expense-date?..., a report that does not exist, so Not Here shows. From a chat the base is/r/<reportID>, sodateis not third. Theamountandpercentagetabs have no legacy pattern, so they are fine.What changes do you think we should make in order to solve the problem?
In
OldRoutes.ts, next to the participants pass-through at line 224, add:'/*/*/date/split-expense/edit/*': '/$1/$2/date/split-expense/edit/$3'.It is longer than
'/*/*/date/*/*/*', somaxLengthselects it and the URL comes back unchanged. The literalsplit-expense/editkeeps real legacy date URLs (/edit/submit/date/<txn>/<report>) redirecting.Test, in
tests/navigation/getMatchingNewRouteTest.ts(sameexpect(getMatchingNewRoute(...))style):datereturns unchanged, with and without?backTo=..../edit/submit/date/123/456still returns/r/456/expense-date?....What alternative solutions did you explore? (Optional)
?backTocase, which matters because the split-edit URL carries a query, and the guard that real legacy date URLs still redirect.config.ts, or makinggetMatchingNewRouteskip redirects for registered dynamic routes) are broader. I rejected them for this bug: the first changes existing tab URLs, the second needs a route-registry lookup inside a pure string helper.j3ffffff commentedon Oct 27, 2026
camesenin commentedon Oct 27, 2026
melvin-bot commentedon Oct 27, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
apoorv-xs commentedon Oct 27, 2026
28 remaining items
melvin-bot commentedon Nov 7, 2026
melvin-bot commentedon Nov 9, 2026
@situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
situchan commentedon Nov 11, 2026
@MelvinBot find offending PR
MelvinBot commentedon Nov 11, 2026
The offending PR is migrate SPLIT_EXPENSE_EDIT — merged August 26, 2026. High confidence from historical code comparison.
It changed split-row navigation from a standalone edit URL to a dynamic suffix appended to the active Date-tab URL:
/search/split-expense-overview-search/date/split-expense/edit/<reportID>/<transactionID>That URL matches the existing legacy date redirect, which rewrites it to
/r/edit/expense-date?..., causing Not Here.The other two migrations were prerequisites, not the final trigger:
The matcher already supported this collision when the offending PR merged; no later matcher change was needed.
view run
situchan commentedon Nov 11, 2026
Contributor+ Checklist:
[Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to the comment on the PR: migrate SPLIT_EXPENSE_EDIT #98547 (comment)
Link to the comment on the Issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Nov 12, 2026
Triggered auto assignment to @mallenexpensify (
Awaiting Payment)melvin-bot commentedon Nov 12, 2026
Payment Summary
Resolving PRs:
Fix Not Here page when editing a split from the Date tab opened from Spend #105749
Reviewer: @situchan owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
mallenexpensify commentedon Nov 16, 2026
Claude posting on behalf of Matt:
Ready. Job price: $175 (title).
No deploy blockers or regressions on the issue or the PR.
Next: press Caps+Y, then pay.
Evidence
PAYPREP v1