You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$175] Trial ended-User is not navigated to Subscription page after clicking Add payment card #105225
Version Number: 9.5.24-2 Reproducible in staging?: Yes Reproducible in production?: Unable to validate in Prod - Provide reasoning. If this was caught during regression testing, add the test name, ID and link from BrowserStack:https://test-management.browserstack.com/tc/TC-4272 Email or phone of affected tester (no customers): N/A Issue reported by: Applause Internal Team Bug source: Regression TC Execution Device used: MacBook Air 26.6.2 Chrome App Component: Other
Action Performed:
Log in to ND with the account that has a free trial
Disable the internet connection
Open console and enter the snippet: Onyx.merge('nvp_private_lastDayFreeTrial', '<today's date time>');
E.g: if today's date is 8/26/2024 it would look like: Onyx.merge('nvp_private_lastDayFreeTrial', '2024-08-26 01:01:00');
Then run the following snippet: "Onyx.merge('nvp_private_amountOwed', 1000);"
Then run the following snippet: "Onyx.merge('nvp_private_billingGracePeriodEnd', 1719792000);"
Go to the Workspace chat, click "+" - Create expense
On the “Restricted” screen click “Add payment card”
Expected Result:
User is redirected to the Subscription page with the Add payment card RHP opened
Actual Result:
User is not redirected to the Subscription page. Add payment card RHP is opened in the Inbox tab
Please re-state the problem that we are trying to solve in this issue.
On web, clicking Add payment card on the workspace "Restricted" screen opens the Add payment card RHP on top of the Inbox. It should open on top of Settings > Subscription.
That PR made Add payment card a dynamic route. The Restricted screen's button changed from the fixed settings/subscription/add-payment-card route to createDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path). See WorkspaceOwnerRestrictedAction/index.tsx:30-34.
With no basePath, createDynamicRoute adds add-payment-card to whatever route is active (createDynamicRoute.ts:83). Here the call runs after dismissModal, so the active route is the workspace chat. The RHP then opens over the Inbox instead of Subscription.
Keeping the chat underneath was the goal for Concierge's "Add payment card" button. It is wrong for the Restricted screen, whose job is to send the owner to Subscription.
What changes do you think we should make in order to solve the problem?
In WorkspaceOwnerRestrictedAction/index.tsx, pass Subscription as the base path: createDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path, ROUTES.SETTINGS_SUBSCRIPTION.route).
The resulting route is settings/subscription/add-payment-card, which matches the behavior before the regression. Subscription is already an allowed entry screen for this dynamic route (ROUTES.ts:248).
Update the expected route in tests/unit/pages/RestrictedAction/WorkspaceOwnerRestrictedActionTest.tsx to match.
What alternative solutions did you explore? (Optional)
Navigate to Subscription first, then open the dynamic route. This takes two navigations and adds a transition for no benefit.
Investigation details
Diff that changed this button: commit 4cd4df80bb (part of the PR above).
The native version is unaffected. It navigates to ROUTES.SETTINGS_SUBSCRIPTION directly (index.native.tsx:39). This matches the report: only MacOS Chrome/Safari is checked.
The other callers changed by that PR (Concierge button, Home, Teachers Unite, Subscription card section) intentionally keep their current page underneath, so leave them as they are.
I did not run the reproduction in a browser. The conclusion is based on the code diff and the timing of the merge versus 9.5.24-2.
Next Steps for Contributor+ team: To accept:@MelvinBot implement [this](https://github.com/Expensify/App/issues/105225) to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
changed the title [-]Trial ended-User is not navigated to Subscription page after clicking Add payment card[/-][+][$175] Trial ended-User is not navigated to Subscription page after clicking Add payment card[/+]on Oct 28, 2026
@jeffrey-graham, I carefully reviewed the information you provided and independently identified the underlying code-level issues. I've documented the confirmed findings, their root causes, and their impact, along with the proposed corrections.
1. Please re-state the problem that we are trying to solve in this issue.
When a workspace owner whose trial has expired clicks the Add payment card button in the Workspace Restricted Action modal, the Add Payment Card panel opens over the Inbox/report instead of opening over Settings > Subscription.
This causes an incorrect navigation experience and interrupts the intended billing setup workflow.
2. What is the root cause of that problem?
Root Cause 1: Missing explicit base path during dynamic navigation
The missing relationship means the Add Payment Card dynamic screen is not explicitly registered as a child RHP of the Subscription root in this configuration.
Impact:
The Subscription-to-payment-card navigation hierarchy is incomplete.
The expected relationship between the Subscription screen and its payment-card panel is not explicitly represented in the linking configuration.
3. What changes do you think we should make in order to solve the problem?
This explicitly associates the dynamic payment-card screen with its intended Subscription parent.
4. What alternative solutions did you explore?
Alternative 1: Navigate to Subscription before opening Add Payment Card.
This requires two navigation operations and an intermediate transition.
Providing an explicit base path constructs the intended destination directly.
Alternative 2: Change the global dynamic-route helper.
Changing the helper's default active-route behavior could affect other callers that intentionally depend on it.
A targeted correction in WorkspaceOwnerRestrictedAction avoids changing unrelated navigation behavior.
5. Conclusion
The navigation defect originates from constructing the Add Payment Card dynamic route without an explicit Subscription base path.
The Subscription RHP relationship also lacks the corresponding dynamic screen registration.
The proposed changes address both confirmed source-code discrepancies and align the Add Payment Card navigation with its intended Subscription context.
@gijoe0295 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Please re-state the problem that we are trying to solve in this issue.
When a workspace owner's free trial has ended and they trigger a restricted workspace action (such as inviting a member or assigning a company card), clicking Add payment card on the WorkspaceOwnerRestrictedAction modal opens the Add payment card Right-Hand Panel (RHP) over the previous background screen (for example, Workspace Members) instead of navigating the underlying full-screen view to Settings > Subscription. Furthermore, pressing the back button on the Add payment card RHP returns to the previous screen instead of Settings > Subscription.
What is the root cause of that problem?
There are two coupled issues in how WorkspaceOwnerRestrictedAction and the settings-to-RHP relation map handle DYNAMIC_ROUTES.ADD_PAYMENT_CARD:
createDynamicRoute is called without a basePath in src/pages/RestrictedAction/Workspace/WorkspaceOwnerRestrictedAction/index.tsx (lines 30–34):
Because no basePath is passed to createDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path), createDynamicRoute (src/libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute.ts:83) falls back to getActiveRoute(). After Navigation.dismissModal finishes, the active route is whatever screen triggered the restricted-action modal (for example, workspaces/<policyID>/members), producing workspaces/<policyID>/members/add-payment-card.
When getMatchingFullScreenRoute (src/libs/Navigation/helpers/getMatchingFullScreenRoute.ts:227-259) strips the dynamic suffix add-payment-card, pathWithoutDynamicSuffix resolves to workspaces/<policyID>/members, keeping the Workspace Split Navigator underneath the RHP.
Similarly, AddPaymentCard.tsx computes backPath = useDynamicBackPath(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path), which strips add-payment-card and navigates back to workspaces/<policyID>/members instead of ROUTES.SETTINGS_SUBSCRIPTION.route.
SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARD is missing from SETTINGS_TO_RHP[SCREENS.SETTINGS.SUBSCRIPTION.ROOT] in src/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts (lines 109–120):
Even when createDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path, ROUTES.SETTINGS_SUBSCRIPTION.route) is used (producing settings/subscription/add-payment-card), SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARD is registered under ModalStackNavigators (src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx), not as a dynamic suffix in DYNAMIC_ROUTES's RHP_TO_SETTINGS relation. Specifically, in getMatchingFullScreenRoute.ts:69:
isDynamicRouteScreen(route.name) checks whether route.name is a generated dynamic screen name, and RHP_TO_SETTINGS[route.name] (derived by inverting SETTINGS_TO_RHP) is checked at line 181.
Because SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARD is omitted from SETTINGS_TO_RHP[SCREENS.SETTINGS.SUBSCRIPTION.ROOT] (src/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts:109-120), RHP_TO_SETTINGS[SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARD] is undefined. As a result, linkTo / swapBackgroundTabForRHPTarget does not swap the background full-screen navigator from WorkspaceSplitNavigator to SettingsSplitNavigator (SCREENS.SETTINGS.SUBSCRIPTION.ROOT) during in-app navigation!
What changes do you think we should make in order to solve the problem?
Pass ROUTES.SETTINGS_SUBSCRIPTION.route as the basePath in src/pages/RestrictedAction/Workspace/WorkspaceOwnerRestrictedAction/index.tsx (lines 30–34):
This sets the target URL to settings/subscription/add-payment-card, ensuring useDynamicBackPath(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path) inside AddPaymentCard.tsx resolves backPath to settings/subscription.
Register SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARD under SCREENS.SETTINGS.SUBSCRIPTION.ROOT in src/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts (lines 109–120):
This populates RHP_TO_SETTINGS[SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARD] = SCREENS.SETTINGS.SUBSCRIPTION.ROOT, so getMatchingFullScreenRoute (and linkTo's background full-screen synchronization) mounts the Subscription central screen in SettingsSplitNavigator directly underneath the Add payment card RHP both on in-app navigation and on deep-link/reload.
Add unit/navigation test coverage:
Update tests/navigation/dynamicSettingsRhpBackgroundTests.ts (or WorkspaceOwnerRestrictedAction tests) to verify that navigating to createDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path, ROUTES.SETTINGS_SUBSCRIPTION.route) from a workspace route mounts SCREENS.SETTINGS.SUBSCRIPTION.ROOT underneath the RHP and returns to ROUTES.SETTINGS_SUBSCRIPTION.route on back navigation.
What alternative solutions did you explore? (Optional)
Using only createDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path, ROUTES.SETTINGS_SUBSCRIPTION.route) without updating SETTINGS_TO_RHP.ts: While this updates the URL prefix so the header back button navigates to settings/subscription, RHP_TO_SETTINGS[SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARD] remains undefined, so on wide screens the background split navigator underneath the RHP does not switch to the Subscription page when opened from the Workspace Members screen. Both changes are required for consistent wide-screen and narrow-screen behavior.
@MelvinBot's proposal is good. The root cause is right: since #100917, the web Restricted screen builds the dynamic route after dismissModal, so it resolves against the chat instead of Subscription. Passing ROUTES.SETTINGS_SUBSCRIPTION.route as the base path restores the behavior from before the regression and matches native.
Infrastructure blocker prevented verification on dev NewDot web: the existing session was suspended and snapshots exposed no UI. No application failure was observed, and no payment card was submitted.
Step
Status
Log in with a free-trial workspace-owner accountAccount state could not be confirmed; the session remained suspended after one retry.
⚠️
Disable internetRequired offline fixture could not be established.
⚠️
Set lastDayFreeTrial to today's datetimeCould not set or verify the value.
⚠️
Set amountOwed to 1000Could not set or verify the value.
⚠️
Set billingGracePeriodEnd to 1719792000Could not set or verify the value.
⚠️
Workspace chat > + > Create expenseNot reached because the session exposed no UI.
⚠️
Restricted > Add payment card opens over SubscriptionCould not inspect the RHP or its background.
⚠️
Closing the card RHP returns to SubscriptionNot reached; no card RHP was opened.
All four focused tests pass; both web regression cases fail without the fix. Lint, type checking, Storybook smoke tests, formatting, and focused compiler checks passed. Full-suite Jest and the changed-files compiler wrapper remain incomplete, documented in the PR.
Activity
applause-bot commentedon Oct 28, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/b5bdfd1644f592b7c31613bdd9337cf483c0559d60bbd7f96e02af8f0f0ce800
MelvinBot commentedon Oct 28, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
On web, clicking Add payment card on the workspace "Restricted" screen opens the Add payment card RHP on top of the Inbox. It should open on top of Settings > Subscription.
What is the root cause of that problem?
This is a regression from Keep the page an RHP was opened from underneath it, merged 2026-10-27.
That PR made Add payment card a dynamic route. The Restricted screen's button changed from the fixed
settings/subscription/add-payment-cardroute tocreateDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path). See WorkspaceOwnerRestrictedAction/index.tsx:30-34.With no
basePath,createDynamicRouteaddsadd-payment-cardto whatever route is active (createDynamicRoute.ts:83). Here the call runs afterdismissModal, so the active route is the workspace chat. The RHP then opens over the Inbox instead of Subscription.Keeping the chat underneath was the goal for Concierge's "Add payment card" button. It is wrong for the Restricted screen, whose job is to send the owner to Subscription.
What changes do you think we should make in order to solve the problem?
In
WorkspaceOwnerRestrictedAction/index.tsx, pass Subscription as the base path:createDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path, ROUTES.SETTINGS_SUBSCRIPTION.route).The resulting route is
settings/subscription/add-payment-card, which matches the behavior before the regression. Subscription is already an allowed entry screen for this dynamic route (ROUTES.ts:248).Update the expected route in
tests/unit/pages/RestrictedAction/WorkspaceOwnerRestrictedActionTest.tsxto match.What alternative solutions did you explore? (Optional)
Navigate to Subscription first, then open the dynamic route. This takes two navigations and adds a transition for no benefit.
Investigation details
ROUTES.SETTINGS_SUBSCRIPTIONdirectly (index.native.tsx:39). This matches the report: only MacOS Chrome/Safari is checked.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement [this](https://github.com/Expensify/App/issues/105225)to create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
melvin-bot commentedon Oct 28, 2026
Triggered auto assignment to Contributor-plus team member for initial proposal review - @gijoe0295 (
External)[-]Trial ended-User is not navigated to Subscription page after clicking Add payment card[/-][+][$175] Trial ended-User is not navigated to Subscription page after clicking Add payment card[/+]melvin-bot commentedon Oct 28, 2026
Job added to Upwork: https://www.upwork.com/jobs/~022115320754920689972
camesenin commentedon Oct 28, 2026
melvin-bot commentedon Oct 28, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
j3ffffff commentedon Oct 28, 2026
apoorv-xs commentedon Oct 28, 2026
melvin-bot commentedon Oct 28, 2026
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
33 remaining items
jeffrey-graham commentedon Nov 7, 2026
melvin-bot commentedon Nov 7, 2026
ujjwalmishramishra8977-cell commentedon Nov 7, 2026
@jeffrey-graham, I carefully reviewed the information you provided and independently identified the underlying code-level issues. I've documented the confirmed findings, their root causes, and their impact, along with the proposed corrections.
1. Please re-state the problem that we are trying to solve in this issue.
When a workspace owner whose trial has expired clicks the Add payment card button in the Workspace Restricted Action modal, the Add Payment Card panel opens over the Inbox/report instead of opening over Settings > Subscription.
This causes an incorrect navigation experience and interrupts the intended billing setup workflow.
2. What is the root cause of that problem?
Root Cause 1: Missing explicit base path during dynamic navigation
File:
src/pages/RestrictedAction/Workspace/WorkspaceOwnerRestrictedAction/index.tsxThe navigation currently constructs the dynamic route without specifying its intended base path:
File:
src/libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute.tsThe helper uses the following fallback:
Because no explicit
basePathis supplied, the helper uses the currently active route.Consequently, the Add Payment Card route can be constructed relative to the Inbox/report route instead of Settings > Subscription.
Impact:
Root Cause 2: Missing Subscription RHP relationship
File:
src/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.tsThe Subscription root relationship does not include:
The missing relationship means the Add Payment Card dynamic screen is not explicitly registered as a child RHP of the Subscription root in this configuration.
Impact:
3. What changes do you think we should make in order to solve the problem?
Fix 1: Supply an explicit Subscription base path
In:
src/pages/RestrictedAction/Workspace/WorkspaceOwnerRestrictedAction/index.tsxChange the dynamic route construction to:
This ensures that the dynamic route is constructed relative to Settings > Subscription rather than the currently active report route.
Fix 2: Register the Add Payment Card screen in the Subscription RHP relationship
In:
src/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.tsAdd:
to the relationship array for:
This explicitly associates the dynamic payment-card screen with its intended Subscription parent.
4. What alternative solutions did you explore?
Alternative 1: Navigate to Subscription before opening Add Payment Card.
This requires two navigation operations and an intermediate transition.
Providing an explicit base path constructs the intended destination directly.
Alternative 2: Change the global dynamic-route helper.
Changing the helper's default active-route behavior could affect other callers that intentionally depend on it.
A targeted correction in
WorkspaceOwnerRestrictedActionavoids changing unrelated navigation behavior.5. Conclusion
The navigation defect originates from constructing the Add Payment Card dynamic route without an explicit Subscription base path.
The Subscription RHP relationship also lacks the corresponding dynamic screen registration.
The proposed changes address both confirmed source-code discrepancies and align the Add Payment Card navigation with its intended Subscription context.
melvin-bot commentedon Nov 10, 2026
@gijoe0295 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
gijoe0295 commentedon Nov 11, 2026
I'm working on it
melvin-bot commentedon Nov 11, 2026
@gijoe0295 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
cocvn157 commentedon Nov 14, 2026
Proposal
Please re-state the problem that we are trying to solve in this issue.
When a workspace owner's free trial has ended and they trigger a restricted workspace action (such as inviting a member or assigning a company card), clicking Add payment card on the
WorkspaceOwnerRestrictedActionmodal opens the Add payment card Right-Hand Panel (RHP) over the previous background screen (for example, Workspace Members) instead of navigating the underlying full-screen view to Settings > Subscription. Furthermore, pressing the back button on the Add payment card RHP returns to the previous screen instead of Settings > Subscription.What is the root cause of that problem?
There are two coupled issues in how
WorkspaceOwnerRestrictedActionand the settings-to-RHP relation map handleDYNAMIC_ROUTES.ADD_PAYMENT_CARD:createDynamicRouteis called without abasePathinsrc/pages/RestrictedAction/Workspace/WorkspaceOwnerRestrictedAction/index.tsx(lines 30–34):Because no
basePathis passed tocreateDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path),createDynamicRoute(src/libs/Navigation/helpers/dynamicRoutesUtils/createDynamicRoute.ts:83) falls back togetActiveRoute(). AfterNavigation.dismissModalfinishes, the active route is whatever screen triggered the restricted-action modal (for example,workspaces/<policyID>/members), producingworkspaces/<policyID>/members/add-payment-card.getMatchingFullScreenRoute(src/libs/Navigation/helpers/getMatchingFullScreenRoute.ts:227-259) strips the dynamic suffixadd-payment-card,pathWithoutDynamicSuffixresolves toworkspaces/<policyID>/members, keeping the Workspace Split Navigator underneath the RHP.AddPaymentCard.tsxcomputesbackPath = useDynamicBackPath(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path), which stripsadd-payment-cardand navigates back toworkspaces/<policyID>/membersinstead ofROUTES.SETTINGS_SUBSCRIPTION.route.SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARDis missing fromSETTINGS_TO_RHP[SCREENS.SETTINGS.SUBSCRIPTION.ROOT]insrc/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts(lines 109–120):Even when
createDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path, ROUTES.SETTINGS_SUBSCRIPTION.route)is used (producingsettings/subscription/add-payment-card),SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARDis registered underModalStackNavigators(src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx), not as a dynamic suffix inDYNAMIC_ROUTES'sRHP_TO_SETTINGSrelation. Specifically, ingetMatchingFullScreenRoute.ts:69:isDynamicRouteScreen(route.name)checks whetherroute.nameis a generated dynamic screen name, andRHP_TO_SETTINGS[route.name](derived by invertingSETTINGS_TO_RHP) is checked at line 181.SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARDis omitted fromSETTINGS_TO_RHP[SCREENS.SETTINGS.SUBSCRIPTION.ROOT](src/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts:109-120),RHP_TO_SETTINGS[SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARD]isundefined. As a result,linkTo/swapBackgroundTabForRHPTargetdoes not swap the background full-screen navigator fromWorkspaceSplitNavigatortoSettingsSplitNavigator(SCREENS.SETTINGS.SUBSCRIPTION.ROOT) during in-app navigation!What changes do you think we should make in order to solve the problem?
Pass
ROUTES.SETTINGS_SUBSCRIPTION.routeas thebasePathinsrc/pages/RestrictedAction/Workspace/WorkspaceOwnerRestrictedAction/index.tsx(lines 30–34):This sets the target URL to
settings/subscription/add-payment-card, ensuringuseDynamicBackPath(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path)insideAddPaymentCard.tsxresolvesbackPathtosettings/subscription.Register
SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARDunderSCREENS.SETTINGS.SUBSCRIPTION.ROOTinsrc/libs/Navigation/linkingConfig/RELATIONS/SETTINGS_TO_RHP.ts(lines 109–120):This populates
RHP_TO_SETTINGS[SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARD] = SCREENS.SETTINGS.SUBSCRIPTION.ROOT, sogetMatchingFullScreenRoute(andlinkTo's background full-screen synchronization) mounts the Subscription central screen inSettingsSplitNavigatordirectly underneath the Add payment card RHP both on in-app navigation and on deep-link/reload.Add unit/navigation test coverage:
tests/navigation/dynamicSettingsRhpBackgroundTests.ts(orWorkspaceOwnerRestrictedActiontests) to verify that navigating tocreateDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path, ROUTES.SETTINGS_SUBSCRIPTION.route)from a workspace route mountsSCREENS.SETTINGS.SUBSCRIPTION.ROOTunderneath the RHP and returns toROUTES.SETTINGS_SUBSCRIPTION.routeon back navigation.What alternative solutions did you explore? (Optional)
createDynamicRoute(DYNAMIC_ROUTES.ADD_PAYMENT_CARD.path, ROUTES.SETTINGS_SUBSCRIPTION.route)without updatingSETTINGS_TO_RHP.ts: While this updates the URL prefix so the header back button navigates tosettings/subscription,RHP_TO_SETTINGS[SCREENS.SETTINGS.SUBSCRIPTION.ADD_PAYMENT_CARD]remainsundefined, so on wide screens the background split navigator underneath the RHP does not switch to the Subscription page when opened from the Workspace Members screen. Both changes are required for consistent wide-screen and narrow-screen behavior.gijoe0295 commentedon Nov 16, 2026
@MelvinBot's proposal is good. The root cause is right: since #100917, the web Restricted screen builds the dynamic route after
dismissModal, so it resolves against the chat instead of Subscription. PassingROUTES.SETTINGS_SUBSCRIPTION.routeas the base path restores the behavior from before the regression and matches native.@MelvinBot please implement your proposal at #105225 (comment)
🎀👀🎀 C+ reviewed
expensify-chore-bot commentedon Nov 16, 2026
Triggered auto assignment to @inimaga, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
MelvinBot commentedon Nov 16, 2026
🤖 Web test steps verification results:⚠️ partial
Infrastructure blocker prevented verification on dev NewDot web: the existing session was suspended and snapshots exposed no UI. No application failure was observed, and no payment card was submitted.
Log in with a free-trial workspace-owner account
Account state could not be confirmed; the session remained suspended after one retry.Disable internet
Required offline fixture could not be established.Set lastDayFreeTrial to today's datetime
Could not set or verify the value.Set amountOwed to 1000
Could not set or verify the value.Set billingGracePeriodEnd to 1719792000
Could not set or verify the value.Workspace chat > + > Create expense
Not reached because the session exposed no UI.Restricted > Add payment card opens over Subscription
Could not inspect the RHP or its background.Closing the card RHP returns to Subscription
Not reached; no card RHP was opened.Implemented in draft PR: Open restricted payment card flow over Subscription, assigned to
gijoe0295.All four focused tests pass; both web regression cases fail without the fix. Lint, type checking, Storybook smoke tests, formatting, and focused compiler checks passed. Full-suite Jest and the changed-files compiler wrapper remain incomplete, documented in the PR.
view run · no recording available