Skip to content

mweb/Desktop - Growl - User does not receive a growl when offline in workspace options #10547

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Access staging.new.expensify.com on mweb (Or desktop app)
  2. Sign into a valid account
  3. Tap on Profile icon > Workspace > Reimburse Expenses (Can be any workspace option that should display a growl)
  4. Turn off internet connection
  5. Tap on "View all receipts" while offline

Expected Result:

User expects to receive a growl when offline

Actual Result:

The button does not seem to be responsive, as no growl is received even though it is being pressed.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Desktop App
  • Mobile Web

Version Number: 1.1.89.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5702599_User_also_doesnt_receive_growls_on_desktop.mp4
Bug5702599_User_does_not_recieve_a_growl_when_offline.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Aug 24, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 24, 2022

    @melvin-bot

    Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. sketchydroide commented on Aug 25, 2022

    @sketchydroide
    Contributor

    I cannot replicate this one, and there was another similar to this one that could not be replicated

  4. sketchydroide commented on Aug 25, 2022

    @sketchydroide
    Contributor

    Seems like @luacmartins can't replicate either I'm leaning on not a blocker

  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Aug 25, 2022
  6. removed their assignment
    on Aug 25, 2022
  7. bondydaa commented on Aug 25, 2022

    @bondydaa
    Contributor

    User expects to receive a growl when offline

    I think since we're moving toward Brick Road error handling we are getting rid of growls, right?

    cc @iwiznia

  8. bondydaa commented on Aug 25, 2022

    @bondydaa
    Contributor

    once we figure out if this should be Brick Road or Growl we can probably make it external, will leave as daily until we get more insight.

  9. bondydaa commented on Aug 25, 2022

    @bondydaa
    Contributor

    discussed here https://expensify.slack.com/archives/C02HWMSMZEC/p1661447438916179

    TL:DR yes for now we should have a growl give the user some feedback, even if it's just "you're offline". This should be doable by a contributor so adding that label

    From Robert

    IIRC, the discussion was that we would have to know prior to that action that the user is Offline and show some sort of indicator that they can’t move forward with that step: be it a growl, or selectively disabling the link/button

  10. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 25, 2022
  11. melvin-bot commented on Aug 25, 2022

    @melvin-bot

    Triggered auto assignment to @dylanexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  12. melvin-bot commented on Aug 29, 2022

    @melvin-bot

    @dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

  13. dylanexpensify commented on Aug 30, 2022

    @dylanexpensify
    Contributor

    reviewing today :)

  14. dylanexpensify commented on Aug 30, 2022

    @dylanexpensify
    Contributor

    So it seems this isn't reproducible. Do we still want to export cc @bondydaa @sketchydroide ?

  15. sketchydroide commented on Aug 30, 2022

    @sketchydroide
    Contributor

    I think this is not always reproducible, maybe we can ask QA to try again, and see if this is still an issue
    @kbecciv can you guys check if this still happens for your guys?

  16. kbecciv commented on Aug 30, 2022

    @kbecciv
    Author

    @sketchydroide Checking with team, will update you shortly.

  17. kbecciv commented on Aug 30, 2022

    @kbecciv
    Author

    @sketchydroide Unable to reproduce it for all environments.

  18. sketchydroide commented on Aug 30, 2022

    @sketchydroide
    Contributor

    thanks, I think we can close for now, if it's an issue we will reopen, it might be that a PR that was needed did not go toghether with another one, or a Web PR was not in Staging at the time of testing, and it was soon after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorImprovementItem broken or needs improvement.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions