You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
mweb/Desktop - Growl - User does not receive a growl when offline in workspace options #10547
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
TL:DR yes for now we should have a growl give the user some feedback, even if it's just "you're offline". This should be doable by a contributor so adding that label
From Robert
IIRC, the discussion was that we would have to know prior to that action that the user is Offline and show some sort of indicator that they can’t move forward with that step: be it a growl, or selectively disabling the link/button
I think this is not always reproducible, maybe we can ask QA to try again, and see if this is still an issue @kbecciv can you guys check if this still happens for your guys?
thanks, I think we can close for now, if it's an issue we will reopen, it might be that a PR that was needed did not go toghether with another one, or a Web PR was not in Staging at the time of testing, and it was soon after.
Activity
OSBotify commentedon Aug 24, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Aug 24, 2022
Triggered auto assignment to @bondydaa (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.sketchydroide commentedon Aug 25, 2022
I cannot replicate this one, and there was another similar to this one that could not be replicated
sketchydroide commentedon Aug 25, 2022
Seems like @luacmartins can't replicate either I'm leaning on not a blocker
bondydaa commentedon Aug 25, 2022
I think since we're moving toward Brick Road error handling we are getting rid of growls, right?
cc @iwiznia
bondydaa commentedon Aug 25, 2022
once we figure out if this should be Brick Road or Growl we can probably make it external, will leave as daily until we get more insight.
bondydaa commentedon Aug 25, 2022
discussed here https://expensify.slack.com/archives/C02HWMSMZEC/p1661447438916179
TL:DR yes for now we should have a growl give the user some feedback, even if it's just "you're offline". This should be doable by a contributor so adding that label
From Robert
melvin-bot commentedon Aug 25, 2022
Triggered auto assignment to @dylanexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Aug 29, 2022
@dylanexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!
dylanexpensify commentedon Aug 30, 2022
reviewing today :)
dylanexpensify commentedon Aug 30, 2022
So it seems this isn't reproducible. Do we still want to export cc @bondydaa @sketchydroide ?
sketchydroide commentedon Aug 30, 2022
I think this is not always reproducible, maybe we can ask QA to try again, and see if this is still an issue
@kbecciv can you guys check if this still happens for your guys?
kbecciv commentedon Aug 30, 2022
@sketchydroide Checking with team, will update you shortly.
kbecciv commentedon Aug 30, 2022
@sketchydroide Unable to reproduce it for all environments.
sketchydroide commentedon Aug 30, 2022
thanks, I think we can close for now, if it's an issue we will reopen, it might be that a PR that was needed did not go toghether with another one, or a Web PR was not in Staging at the time of testing, and it was soon after.