Skip to content

[Due for payment 2026-11-11] Rules - Negative sign cannot be entered on Amount field when creating rule #105811

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.31-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #104155
Email or phone of affected tester (no customers): sondjoisjdnoisj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable Rules.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Rules.
  3. Click Add rule > Apply expense defaults.
  4. Click Merchant, enter any merchant and save it.
  5. Click Amount.
  6. Enter negative sign.

Expected Result:

Negative sign can be entered on Amount field.

Actual Result:

Negative sign cannot be entered on Amount field when creating rule.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7304029_1793736614123.8.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7304029

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 3, 2026
  2. applause-bot commented on Nov 3, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/9df9c236002c80578e6a5dbf08f8ad0c1e529265a5dff2a345e808214b74129d

  3. melvin-bot commented on Nov 3, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #104155

  4. melvin-bot commented on Nov 3, 2026

    @melvin-bot

    @luacmartins @JS00001 @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #104155

  5. melvin-bot commented on Nov 3, 2026

    @melvin-bot

    @Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #104155

  6. melvin-bot commented on Nov 3, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 3, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 3, 2026

    @MelvinBot
    Contributor

    🤖 Web test steps verification results: ⚠️ partial

    Verified on dev NewDot web after creating a workspace and enabling Rules. A paid Control-plan upgrade blocked rule creation, so negative-sign behavior remains untested; no source changed.

    Paid Control-plan upgrade gate after clicking Add rule

    Step Status
    1. Open the appThe signed-in Home screen was visible.
    ✅
    2. Open workspace settings > RulesCreated a workspace and enabled Rules. The Rules page displayed Add rule and Expense defaults.
    ✅
    3. Click Add rule > Apply expense defaultsAdd rule opened a paid Control-plan upgrade dialog, blocking further navigation.
    Paid Control-plan upgrade gate after clicking Add rule
    ⚠️
    4. Enter and save a MerchantNot reached because rule creation required a paid upgrade.
    ⚠️
    5. Open AmountNot reached because rule creation required a paid upgrade.
    ⚠️
    6. Enter a negative signBrowser verification was blocked. Static investigation identifies [Rules Engine Release 2] Support expense defaults for more than just merchants as the introducing PR, with high confidence from its merge diff.
    Root cause: AddAmountPage.tsx:75–84 uses AmountForm, which does not pass allowNegative. AmountFormField.tsx:38–39 defaults that option to false.
    Recommendation: Revert the introducing PR unless owners can promptly verify a complete signed-amount fix. Allowing the keystroke alone is unsafe: ExpenseDefaultRuleUtils.ts:204–216 saves both signs as negative backend amounts. ExpenseDefaultRuleUtils.ts:499–504 rejects credit defaults when reopening, and MerchantTypeRulesUtils.ts:68–72 removes the displayed sign.
    A complete fix needs opt-in signed input, sign-preserving save/reopen conversion, signed summaries, and tests for both expense and credit defaults. Confirm the intended scope first: the implementation explicitly excludes credits, but that does not establish that the reported expectation is invalid. Keep the blocker pending that decision and verification.
    ⚠️

    view run · no recording available

  9. JS00001 commented on Nov 4, 2026

    @JS00001
    Contributor

    Lets keep this as intentional, we just want normal amounts

  10. m-natarajan commented on Nov 4, 2026

    @m-natarajan

    Not repro on Win 11/Chrome build v9.5.31-3. No amount field in Apply Expense defaults >> Merchant option

    Recording.240.mp4
  11. added and removed
    ReviewingHas a PR in review
    on Nov 4, 2026
  12. changed the title [-]Rules - Negative sign cannot be entered on Amount field when creating rule[/-] [+][Due for payment 2026-11-11] Rules - Negative sign cannot be entered on Amount field when creating rule[/+] on Nov 4, 2026
  13. melvin-bot commented on Nov 4, 2026

    @melvin-bot

    @Krishna2323 / @situchan

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.31-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-11. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  14. added
    ReviewingHas a PR in review
    and removed on Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions