You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-11-11] Rule - Created rule doesn´t disappear after deleting category used as condition. #105855
Version Number: 9.5.31-0 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#104155 Email or phone of affected tester (no customers):ibellicotest+3215@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome App Component: Workspace Settings
Action Performed:
Prerequisite: User is owner of a "Control" workspace.
Prerequisite 2: "Rules" and "Categories" enabled.
Open the staging.new.expensify.com website.
Navigate to "Workspaces" > Workspace > "Rules"
Click on "Add Rule" > "Apply expense defaults"
In "If any expense matches", select any category.
In "Then apply the following defaults", apply any default.
Save the created rule.
Navigate to "Categories"
Select the category used as condition in rule and delete it.
Return to "Rules" > "Expense Defaults"
Note that created rule is still displayed in rules list.
Expected Result:
Created rule should disappear from expense defaults after deleting the category or tag used as condition during creation.
Actual Result:
Created rule is still visible in expense defaults after deleting the category or tag used as condition during creation.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Recommendation: Keep the deploy blocker. Confirm whether deleting a condition should hide or permanently delete its rule. If QA’s expectation stands and no verified fix is ready, revert the introducing PR after checking compatibility with newly created rules. A visibility fix must preserve rules with other valid category conditions. Tag deletion and server-side behavior were not runtime-tested.
changed the title [-]Rule - Created rule doesn´t disappear after deleting category used as condition.[/-][+][Due for payment 2026-11-11] Rule - Created rule doesn´t disappear after deleting category used as condition.[/+]on Nov 4, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.31-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-11. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Nov 4, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/7f6b22af5736dd5fafb546bb5c68c6021cfe80420c93efd576a905bce0ce5aa3
melvin-bot commentedon Nov 4, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #104155
melvin-bot commentedon Nov 4, 2026
@luacmartins @JS00001 @situchan you have been assigned to this deploy blocker because you reviewed the offending PR: #104155
melvin-bot commentedon Nov 4, 2026
@Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #104155
melvin-bot commentedon Nov 4, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 4, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 4, 2026
🤖 Web test steps verification results: ❌ fail
Reproduced on dev NewDot web: the expense-default rule remains after deleting its condition category.
1. Open website
Signed-in web session displayed Home.2. Navigate Workspaces > workspace > Rules
Opened Rules in an owned Control workspace.3. Add Rule > Apply expense defaults
Expense-default editor opened.4. Select a condition category
Selected Advertising.5. Select an expense default
Selected Reimbursable: Yes.6. Save rule
Saved rule appeared in the list.7. Navigate Categories
Advertising appeared in the category list.8. Delete the condition category
Confirmed deletion; Advertising disappeared from Categories.9. Return Rules > Expense defaults
Opened Expense defaults explicitly.10. Rule disappears after deleting its condition category
Failed: Category is “Advertising”; Mark as “reimbursable” remained visible.Cause — high confidence: Support expense defaults for more than just merchants introduced category-conditioned generic rules. The list filters deleted rules, not deleted condition categories (MerchantTypeRulesUtils.ts:180–210). This is intentional retention, not proven backend cleanup failure: the PR explicitly tests that rules remain after category deletion (CategoryContextualRulesUtilsTest.ts:188–203).
Recommendation: Keep the deploy blocker. Confirm whether deleting a condition should hide or permanently delete its rule. If QA’s expectation stands and no verified fix is ready, revert the introducing PR after checking compatibility with newly created rules. A visibility fix must preserve rules with other valid category conditions. Tag deletion and server-side behavior were not runtime-tested.
view run · view recording
JS00001 commentedon Nov 4, 2026
this is expected
m-natarajan commentedon Nov 4, 2026
MacBook Air 26.6.2 Chrome, build 9.5.31-3. Category field is not shown in Expense defaults, the feature was reverted.
No.amount.field.1.mp4
[-]Rule - Created rule doesn´t disappear after deleting category used as condition.[/-][+][Due for payment 2026-11-11] Rule - Created rule doesn´t disappear after deleting category used as condition.[/+]melvin-bot commentedon Nov 4, 2026
@Krishna2323 / @situchan
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.31-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-11-11. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]