Skip to content

[Due for payment 2026-11-13] Payment issue for E/App PR#105696 #106185

Open

Description

@melvin-bot

Issue created to compensate the Contributor+ member for their work on #105696
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/684654.
Contributor+ member who reviewed the PR - @Eskalifer1.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

Issue OwnerCurrent Issue Owner: @mallenexpensify

Activity

  1. melvin-bot commented on Nov 6, 2026

    @melvin-bot
    Author

    @Eskalifer1 The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  2. melvin-bot commented on Nov 9, 2026

    @melvin-bot
    Author

    @Eskalifer1 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  3. Eskalifer1 commented on Nov 12, 2026

    @Eskalifer1
    Contributor

    @MelvinBot find offending PR

  4. Eskalifer1 commented on Nov 12, 2026

    @Eskalifer1
    Contributor

    Contributor+ Checklist:

    • [Contributor] The offending PR and associated issue have been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to the comment on the PR: https://github.com/Expensify/App/pull/53802/changes#r4550073737

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

      N/A - dead code removal

  5. MelvinBot commented on Nov 12, 2026

    @MelvinBot
    Contributor

    The PR that made this code unreachable was Fix: Remove GBR and 'Add a bank account' for paid invoices, merged December 19, 2024.

    Important distinction: Removing the GBR from paid invoices was intentional. The leftover dead code—not a new user-facing regression—is what the cleanup PR addressed.


    view run

  6. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 12, 2026
  7. melvin-bot commented on Nov 12, 2026

    @melvin-bot
    Author

    Triggered auto assignment to @mallenexpensify (Awaiting Payment)

  8. melvin-bot commented on Nov 12, 2026

    @melvin-bot
    Author

    Payment Summary

    • Assignee: @Eskalifer1 requires payment (Needs manual offer from BZ)

    BugZero Checklist (@mallenexpensify)

    • I have confirmed assignees, roles, and Upwork contracts look correct
    • I have paid out Upwork contracts / manual NewDot requests
    • [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
  9. mallenexpensify commented on Nov 16, 2026

    @mallenexpensify
    Contributor

    Claude posting on behalf of Matt:

    Ready. Job price: $175 (standard, no Help Wanted, first review 2026-11-04).

    • Eskalifer1 (C+): 100%, via NewDot

    The C+ checklist says "N/A - dead code removal": no test steps for Caps+Y.

    Melvin's summary says Eskalifer1 needs a manual offer.

    Next: pay.

    Evidence
    • C+ checklist: comment
    • PR #105696: by cead22 (employee), merged 2026-11-04, approved by Beamanator and Eskalifer1. No revert.
    • Offending PR #53802 by ikevin127, merged 2024-12-19. Outside the window, no cut.
    • Videos: C+ 5/5.

    PAYPREP v1

  10. Eskalifer1 commented on Nov 16, 2026

    @Eskalifer1
    Contributor

    Note: This issue shold be paid via Upwork yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2Task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions