Skip to content

[HOLD for payment 2022-11-16] [$500] Dev - Activating metrics on crashes the app on Android - reported by @parasharrajat #10622

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

1.Set the env with following.
ONYX_METRICS=true
CAPTURE_METRICS=true
2. Build the app for android.

Expected Result:

App should build

Actual Result:

App crashes

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • Android

Version Number:
Reproducible in staging?: need repro
Reproducible in production?: need repro
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

image - 2022-08-28T224657 651
image - 2022-08-28T224655 216

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1660151993852989

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Aug 29, 2022

    @melvin-bot

    Triggered auto assignment to @puneetlath (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Aug 29, 2022
  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 29, 2022
  4. melvin-bot commented on Aug 29, 2022

    @melvin-bot

    Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

  5. puneetlath commented on Aug 29, 2022

    @puneetlath
    Contributor
  6. melvin-bot commented on Aug 29, 2022

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Aug 29, 2022
  8. 74 remaining items

  9. puneetlath commented on Nov 3, 2022

    @puneetlath
    Contributor

    I believe we now also need a PR to update the app to use the new onyx version, is that right?

  10. Santhosh-Sellavel commented on Nov 3, 2022

    @Santhosh-Sellavel
    Collaborator

    Yes right, @christianwen can you make submit again the E/APP, thanks!

  11. zzz0108 commented on Nov 4, 2022

    @zzz0108
    Contributor

    @Santhosh-Sellavel PR for it here #12465
    Thanks

  12. melvin-bot commented on Nov 8, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist will need to be completed before the issue can be closed:

    • A regression test has been added or updated so that the same bug will not reach production again. Link to the updated test here: n/a since this is a dev issue
    • The PR that introduced the bug has been identified. Link to the PR: Bundle Onyx with Webpack react-native-onyx#132
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Bundle Onyx with Webpack react-native-onyx#132 (comment)
    • A discussion in #contributor-plus has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C049HHMV9SM/p1668624479764529
    • Payment has been made to the issue reporter (if applicable)
    • Payment has been made to the contributor that fixed the issue (if applicable)
    • Payment has been made to the contributor+ that helped on the issue (if applicable)
  13. puneetlath commented on Nov 8, 2022

    @puneetlath
    Contributor

    @Santhosh-Sellavel could you help out with determining which PR introduced this bug?

  14. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 9, 2022
  15. changed the title [-][$500] Dev - Activating metrics on crashes the app on Android - reported by @parasharrajat[/-] [+][HOLD for payment 2022-11-16] [$500] Dev - Activating metrics on crashes the app on Android - reported by @parasharrajat[/+] on Nov 9, 2022
  16. melvin-bot commented on Nov 9, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.25-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-11-16. 🎊

  17. Santhosh-Sellavel commented on Nov 13, 2022

    @Santhosh-Sellavel
    Collaborator
  18. puneetlath commented on Nov 16, 2022

    @puneetlath
    Contributor

    Checklist completed. Everyone paid.

    Thanks for your contributions everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions