Skip to content

Compliance in the background loads infinitely when upgrade success RHP is not dismissed #106513

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.35-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #105505
Email or phone of affected tester (no customers): jodijnsdojodsijo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Other

Action Performed:

Precondition:

  • Enable insightsCompliance beta.
  • Create a new account.
  • Create a Collect workspace.
  1. Go to staging.new.expensify.com
  2. Go to Insights.
  3. Go to Compliance.
  4. Click Upgrade to Control.
  5. Click Upgrade.
  6. Do not dismiss upgrade success RHP.

Expected Result:

Compliance on the background will not load infinitely.

Actual Result:

Compliance on the background loads infinitely when upgrade success RHP is not dismissed.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7310164_1794323890357.2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Chandana Kiran
Bug ID: 7310164

Issue OwnerCurrent Issue Owner: @adamgrzybowski

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 10, 2026
  2. applause-bot commented on Nov 10, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/88fac808280740bfcb8bb74ae06bb63a4235c61c1a7a21f020f5dfd50f01802d

  3. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #105505

  4. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    @luacmartins @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #105505

  5. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    @adamgrzybowski you have been assigned to this deploy blocker because you authored the offending PR: #105505

  6. github-actions commented on Nov 10, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. melvin-bot commented on Nov 10, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Nov 10, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The contributing PR is Show Control upsell on the Insights compliance dashboard.

    Upgrading immediately enables the background Compliance dashboard’s query and removes its upsell. However, the dashboard refuses to fetch data while the upgrade RHP holds navigation focus. It therefore displays loading for a request it has not issued, indefinitely while the RHP remains open.

    Confidence: Strong static evidence; not independently browser-verified.

    Code evidence and release attribution

    A backend timeout is unnecessary to explain the symptom: the client prevents the request. Dismissing the RHP should restore focus and trigger fetching, but that recovery remains unverified.

    What changes do you think we should make in order to solve the problem?

    Recommend a targeted roll-forward. Allow the active Insights tab to fetch newly eligible Compliance data beneath the RHP, while preserving offline and inactive-tab guards. The existing tab-focus hook linked above is a suitable starting point.

    Verify that upgrading with the success RHP still open issues GetInsights and settles the background dashboard. Also cover dismissal, failed upgrades, offline/reconnect, and switching tabs.

    What alternative solutions did you explore? (Optional)

    Reverting the upsell PR would remove the triggering flow but also remove the feature. Forcing dismissal would mask the problem rather than fix the loading behavior.

    Suggested AI review rule

    Flag tab-root fetch effects gated solely by useIsFocused() when an RHP can change shared state and enable a query on the still-visible background tab. Prefer tab-level eligibility or preserve settled UI until fetching resumes. Exclude intentionally focus-only work such as camera or keyboard handling.

    No code changes were made.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement this to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions