You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Compliance in the background loads infinitely when upgrade success RHP is not dismissed #106513
Version Number: 9.5.35-1 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#105505 Email or phone of affected tester (no customers):jodijnsdojodsijo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Other
Action Performed:
Precondition:
Enable insightsCompliance beta.
Create a new account.
Create a Collect workspace.
Go to staging.new.expensify.com
Go to Insights.
Go to Compliance.
Click Upgrade to Control.
Click Upgrade.
Do not dismiss upgrade success RHP.
Expected Result:
Compliance on the background will not load infinitely.
Actual Result:
Compliance on the background loads infinitely when upgrade success RHP is not dismissed.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Upgrading immediately enables the background Compliance dashboard’s query and removes its upsell. However, the dashboard refuses to fetch data while the upgrade RHP holds navigation focus. It therefore displays loading for a request it has not issued, indefinitely while the RHP remains open.
Confidence: Strong static evidence; not independently browser-verified.
The PR appears in the staging release checklist. It introduced this upgrade transition; the focus guard already existed.
A backend timeout is unnecessary to explain the symptom: the client prevents the request. Dismissing the RHP should restore focus and trigger fetching, but that recovery remains unverified.
What changes do you think we should make in order to solve the problem?
Recommend a targeted roll-forward. Allow the active Insights tab to fetch newly eligible Compliance data beneath the RHP, while preserving offline and inactive-tab guards. The existing tab-focus hook linked above is a suitable starting point.
Verify that upgrading with the success RHP still open issues GetInsights and settles the background dashboard. Also cover dismissal, failed upgrades, offline/reconnect, and switching tabs.
What alternative solutions did you explore? (Optional)
Reverting the upsell PR would remove the triggering flow but also remove the feature. Forcing dismissal would mask the problem rather than fix the loading behavior.
Suggested AI review rule
Flag tab-root fetch effects gated solely by useIsFocused() when an RHP can change shared state and enable a query on the still-visible background tab. Prefer tab-level eligibility or preserve settled UI until fetching resumes. Exclude intentionally focus-only work such as camera or keyboard handling.
No code changes were made.
Next Steps for Contributor+ team: To accept:@MelvinBot implement this to create a draft PR. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin's proposal.
Activity
applause-bot commentedon Nov 10, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/88fac808280740bfcb8bb74ae06bb63a4235c61c1a7a21f020f5dfd50f01802d
melvin-bot commentedon Nov 10, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #105505
melvin-bot commentedon Nov 10, 2026
@luacmartins @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #105505
melvin-bot commentedon Nov 10, 2026
@adamgrzybowski you have been assigned to this deploy blocker because you authored the offending PR: #105505
github-actions commentedon Nov 10, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Nov 10, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Nov 10, 2026
Proposal
What is the root cause of that problem?
The contributing PR is Show Control upsell on the Insights compliance dashboard.
Upgrading immediately enables the background Compliance dashboard’s query and removes its upsell. However, the dashboard refuses to fetch data while the upgrade RHP holds navigation focus. It therefore displays loading for a request it has not issued, indefinitely while the RHP remains open.
Confidence: Strong static evidence; not independently browser-verified.
Code evidence and release attribution
isFocusedis false.useIsFocused()false.A backend timeout is unnecessary to explain the symptom: the client prevents the request. Dismissing the RHP should restore focus and trigger fetching, but that recovery remains unverified.
What changes do you think we should make in order to solve the problem?
Recommend a targeted roll-forward. Allow the active Insights tab to fetch newly eligible Compliance data beneath the RHP, while preserving offline and inactive-tab guards. The existing tab-focus hook linked above is a suitable starting point.
Verify that upgrading with the success RHP still open issues
GetInsightsand settles the background dashboard. Also cover dismissal, failed upgrades, offline/reconnect, and switching tabs.What alternative solutions did you explore? (Optional)
Reverting the upsell PR would remove the triggering flow but also remove the feature. Forcing dismissal would mask the problem rather than fix the loading behavior.
Suggested AI review rule
Flag tab-root fetch effects gated solely by
useIsFocused()when an RHP can change shared state and enable a query on the still-visible background tab. Prefer tab-level eligibility or preserve settled UI until fetching resumes. Exclude intentionally focus-only work such as camera or keyboard handling.No code changes were made.
Next Steps for Contributor+ team:
To accept:
@MelvinBot implement thisto create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run