Skip to content

Spend - No reset button on empty results page when keyword search is applied #106588

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.36-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #106136
Email or phone of affected tester (no customers): osjndojsdoinjonsjo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Search

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Spend > Expenses.
  3. Click on the search field.
  4. Type anything that will not show results and search.

Expected Result:

Empty results page will show Reset button when keyword search is applied.

Actual Result:

Empty results page does not show Reset button when keyword search is applied.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7310695_1794360038677.2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7310695

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 11, 2026
  2. applause-bot commented on Nov 11, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/9746c28ba4648714445beb743f9943c882c63e5da75e72bd6ea54f53957be124

  3. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #106136

  4. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    @JS00001 @ahmedGaber93 you have been assigned to this deploy blocker because you reviewed the offending PR: #106136

  5. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. github-actions commented on Nov 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  7. MelvinBot commented on Nov 11, 2026

    @MelvinBot
    Contributor

    🤖 Web test steps verification results: ⚠️ partial

    Submitted the unmatched search successfully on dev NewDot web. No Reset button appeared, but the account’s no-expenses state prevents equivalent reproduction against existing expenses.

    Submitted unmatched search without Reset

    Step Status
    Identify tested build and open appTested dev.new.expensify.com:8082, local version 9.5.36-0—not staging.
    ✅
    Go to Spend > ExpensesExpenses opened and displayed “No expenses yet”.
    Spend > Expenses with no existing expenses
    ✅
    Click the search fieldClicked “Search for something...”.
    ✅
    Enter an unmatched keywordEntered unmatched106588xyz and confirmed the input value.
    Unmatched keyword entered before submission
    ✅
    Submit the searchSearch submitted successfully; the resulting view displayed Save and retained the keyword.
    Submitted unmatched search without Reset
    ✅
    Determine whether empty results show ResetNo Reset appeared. Code finding: the button intentionally returns nothing when canReset is false (SearchResetFiltersButton.tsx:13–20). The associated PR explicitly tests that keyword-only searches cannot reset (useSearchFiltersReset.test.tsx:50–62). This explains the reported behavior, although this account cannot independently confirm the established-expense scenario.
    Submitted unmatched search without Reset
    ✅
    Assess limitations and deploy-blocker recommendationOnboarding did not block navigation, but existing expenses are needed for equivalent reproduction. Attribution: the empty-results Reset implementation shipped in the affected release, but keyword exclusion and preservation already existed in its parent (SearchQueryUtils.ts:1292–1320). The original feature requirement asks for parity with the filter-bar Reset, so this is a requirements mismatch—not an established regression. Recommendation: confirm whether keyword-only searches should reset before reverting. If required, change both eligibility and reset behavior: the current action preserves keywords (SearchQueryUtils.ts:1311–1320), so merely showing the button would not resolve the empty results. No source or labels changed.
    ✅

    view run · view recording

  8. ahmedGaber93 commented on Nov 11, 2026

    @ahmedGaber93
    Contributor

    We matched the behaviour of the existing "Reset" button in the top bar:

    • It only appears when filters are applied. Search text alone doesn't make it appear.
    • Clicking it clears the filters but keeps the search text.

    Our PR follows the same rules, so the reset action in the empty state works the same way as the top bar button.

    CC @dubielzyk-expensify

    Screen.Recording.2026-11-11.at.4.01.51.PM.mov
  9. dubielzyk-expensify commented on Nov 11, 2026

    @dubielzyk-expensify
    Contributor

    Yep, this is working as intended and is meant to follow the Reset button in the filter bar.

    It points out a fair thing that we could have a reset button when the keyword is applied, but we'd do that separately and we didn't do it initially so this isn't considered a bug 👍

  10. ahmedGaber93 commented on Nov 11, 2026

    @ahmedGaber93
    Contributor

    Thanks, Jon, we can close this now. cc @JS00001

  11. dubielzyk-expensify commented on Nov 12, 2026

    @dubielzyk-expensify
    Contributor

    Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions