You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Spend - No reset button on empty results page when keyword search is applied #106588
Version Number: 9.5.36-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#106136 Email or phone of affected tester (no customers):osjndojsdoinjonsjo@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Search
Action Performed:
Go to staging.new.expensify.com
Go to Spend > Expenses.
Click on the search field.
Type anything that will not show results and search.
Expected Result:
Empty results page will show Reset button when keyword search is applied.
Actual Result:
Empty results page does not show Reset button when keyword search is applied.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Submitted the unmatched search successfully on dev NewDot web. No Reset button appeared, but the account’s no-expenses state prevents equivalent reproduction against existing expenses.
Step
Status
Identify tested build and open appTested dev.new.expensify.com:8082, local version 9.5.36-0—not staging.
✅
Go to Spend > ExpensesExpenses opened and displayed “No expenses yet”.
✅
Click the search fieldClicked “Search for something...”.
✅
Enter an unmatched keywordEntered unmatched106588xyz and confirmed the input value.
✅
Submit the searchSearch submitted successfully; the resulting view displayed Save and retained the keyword.
✅
Determine whether empty results show ResetNo Reset appeared. Code finding: the button intentionally returns nothing when canReset is false (SearchResetFiltersButton.tsx:13–20). The associated PR explicitly tests that keyword-only searches cannot reset (useSearchFiltersReset.test.tsx:50–62). This explains the reported behavior, although this account cannot independently confirm the established-expense scenario.
✅
Assess limitations and deploy-blocker recommendationOnboarding did not block navigation, but existing expenses are needed for equivalent reproduction. Attribution: the empty-results Reset implementation shipped in the affected release, but keyword exclusion and preservation already existed in its parent (SearchQueryUtils.ts:1292–1320). The original feature requirement asks for parity with the filter-bar Reset, so this is a requirements mismatch—not an established regression. Recommendation: confirm whether keyword-only searches should reset before reverting. If required, change both eligibility and reset behavior: the current action preserves keywords (SearchQueryUtils.ts:1311–1320), so merely showing the button would not resolve the empty results. No source or labels changed.
Yep, this is working as intended and is meant to follow the Reset button in the filter bar.
It points out a fair thing that we could have a reset button when the keyword is applied, but we'd do that separately and we didn't do it initially so this isn't considered a bug 👍
Activity
applause-bot commentedon Nov 11, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/9746c28ba4648714445beb743f9943c882c63e5da75e72bd6ea54f53957be124
melvin-bot commentedon Nov 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #106136
melvin-bot commentedon Nov 11, 2026
@JS00001 @ahmedGaber93 you have been assigned to this deploy blocker because you reviewed the offending PR: #106136
melvin-bot commentedon Nov 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 11, 2026
🤖 Web test steps verification results:⚠️ partial
Submitted the unmatched search successfully on dev NewDot web. No Reset button appeared, but the account’s no-expenses state prevents equivalent reproduction against existing expenses.
Identify tested build and open app
Tested dev.new.expensify.com:8082, local version 9.5.36-0—not staging.Go to Spend > Expenses
Expenses opened and displayed “No expenses yet”.Click the search field
Clicked “Search for something...”.Enter an unmatched keyword
Entered unmatched106588xyz and confirmed the input value.Submit the search
Search submitted successfully; the resulting view displayed Save and retained the keyword.Determine whether empty results show Reset
No Reset appeared. Code finding: the button intentionally returns nothing when canReset is false (SearchResetFiltersButton.tsx:13–20). The associated PR explicitly tests that keyword-only searches cannot reset (useSearchFiltersReset.test.tsx:50–62). This explains the reported behavior, although this account cannot independently confirm the established-expense scenario.Assess limitations and deploy-blocker recommendation
Onboarding did not block navigation, but existing expenses are needed for equivalent reproduction. Attribution: the empty-results Reset implementation shipped in the affected release, but keyword exclusion and preservation already existed in its parent (SearchQueryUtils.ts:1292–1320). The original feature requirement asks for parity with the filter-bar Reset, so this is a requirements mismatch—not an established regression. Recommendation: confirm whether keyword-only searches should reset before reverting. If required, change both eligibility and reset behavior: the current action preserves keywords (SearchQueryUtils.ts:1311–1320), so merely showing the button would not resolve the empty results. No source or labels changed.view run · view recording
ahmedGaber93 commentedon Nov 11, 2026
We matched the behaviour of the existing "Reset" button in the top bar:
Our PR follows the same rules, so the reset action in the empty state works the same way as the top bar button.
CC @dubielzyk-expensify
Screen.Recording.2026-11-11.at.4.01.51.PM.mov
dubielzyk-expensify commentedon Nov 11, 2026
Yep, this is working as intended and is meant to follow the
Resetbutton in the filter bar.It points out a fair thing that we could have a reset button when the keyword is applied, but we'd do that separately and we didn't do it initially so this isn't considered a bug 👍
ahmedGaber93 commentedon Nov 11, 2026
Thanks, Jon, we can close this now. cc @JS00001
dubielzyk-expensify commentedon Nov 12, 2026
Closing!