You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Spend - Modal shows wrong total report when bulk changing workspace #106590
Version Number: 9.5.36-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#104295 Email or phone of affected tester (no customers):osjdonijdsojio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Search
Action Performed:
Precondition:
Create two workspaces - A and B.
Go to staging.new.expensify.com
Create a report in workspace chat A and B.
Go to Spend > Reports.
Bulk select both reports from workspace chat A and B.
Click Change workspace.
Select workspace B > Save.
Expected Result:
Modal will show “Changed workspace on 1 of 2 reports” as 2 reports are selected.
Actual Result:
Modal shows “Changed workspace on 1 of 1 report” when 2 reports are selected.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The evidence points to a selected-versus-changed report counting mismatch, not incorrect pluralization. Both selected reports are submitted, but the modal displays the bulk operation’s counts. The report already in workspace B appears to be excluded from that total.
The exact count-producing defect remains unconfirmed: this investigation was static; no runtime response or backend producer was inspected.
Supporting evidence and alternative explanations
SearchChangeWorkspacePage.tsx:108–115 includes all selected report IDs without filtering by destination workspace. This contradicts the hypothesis that the frontend drops the already-in-B report before submission.
BulkActionStatusModal.tsx:142–148 derives successful reports as total - failedReportIDs.length. “1 of 1” therefore reflects the supplied operation counts.
What changes do you think we should make in order to solve the problem?
Prefer a targeted roll-forward, but confirm the counting contract before implementation. An internal engineer should trace the submitted request and resulting bulk-action updates to establish where the selected count becomes the changed count. If that producer is outside App, escalate the fix to an internal engineer with access.
The acceptance criterion requires distinguishing selected, changed, failed, and skipped reports. Simply increasing total is insufficient: the current arithmetic would incorrectly show “2 of 2.”
What alternative solutions did you explore? (Optional)
Reverting the introducing PR would remove the entire new bulk-workspace feature. A targeted accounting correction is preferable if it can be verified promptly; otherwise, reverting remains the release-unblocking fallback.
Next Steps for Contributor+ team: Confirm the response/count producer and skipped-report semantics before requesting implementation.
The count comes from the backend. Reports that are already in the target workspace get dropped before the job runs, so the total only counts the reports that were moved. The fix needs a backend change, so I'm removing the blocker label. I'll open a follow-up for it.
Activity
applause-bot commentedon Nov 11, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/dc88f60e66202a45f273a92e40c7d4b2e4f9e6fd4018b6ca7c4d8fcc244f5c6b
melvin-bot commentedon Nov 11, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #104295
melvin-bot commentedon Nov 11, 2026
@JS00001 @mollfpr @Eskalifer1 you have been assigned to this deploy blocker because you reviewed the offending PR: #104295
melvin-bot commentedon Nov 11, 2026
@allgandalf you have been assigned to this deploy blocker because you authored the offending PR: #104295
melvin-bot commentedon Nov 11, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 11, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 11, 2026
Proposal
What is the root cause of that problem?
Introducing PR identified with high confidence: Add Change workspace to Search bulk actions, included in release 9.5.36-0.
The evidence points to a selected-versus-changed report counting mismatch, not incorrect pluralization. Both selected reports are submitted, but the modal displays the bulk operation’s counts. The report already in workspace B appears to be excluded from that total.
The exact count-producing defect remains unconfirmed: this investigation was static; no runtime response or backend producer was inspected.
Supporting evidence and alternative explanations
total - failedReportIDs.length. “1 of 1” therefore reflects the supplied operation counts.What changes do you think we should make in order to solve the problem?
Prefer a targeted roll-forward, but confirm the counting contract before implementation. An internal engineer should trace the submitted request and resulting bulk-action updates to establish where the selected count becomes the changed count. If that producer is outside App, escalate the fix to an internal engineer with access.
The acceptance criterion requires distinguishing selected, changed, failed, and skipped reports. Simply increasing
totalis insufficient: the current arithmetic would incorrectly show “2 of 2.”What alternative solutions did you explore? (Optional)
Reverting the introducing PR would remove the entire new bulk-workspace feature. A targeted accounting correction is preferable if it can be verified promptly; otherwise, reverting remains the release-unblocking fallback.
Next Steps for Contributor+ team: Confirm the response/count producer and skipped-report semantics before requesting implementation.
view run
mollfpr commentedon Nov 11, 2026
The count comes from the backend. Reports that are already in the target workspace get dropped before the job runs, so the total only counts the reports that were moved. The fix needs a backend change, so I'm removing the blocker label. I'll open a follow-up for it.
Eskalifer1 commentedon Nov 11, 2026
I have raised that during PR here: #104295 (review) (3rd point)
#104295 (comment) - seems like expected. The original PR was already quite big; I think if we want to fix this, we can do so in a follow-up.
cc: @mollfpr
mollfpr commentedon Nov 16, 2026
Still working on the backend changes.