Skip to content

Spend - Modal shows wrong total report when bulk changing workspace #106590

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.36-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #104295
Email or phone of affected tester (no customers): osjdonijdsojio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Search

Action Performed:

Precondition:

  • Create two workspaces - A and B.
  1. Go to staging.new.expensify.com
  2. Create a report in workspace chat A and B.
  3. Go to Spend > Reports.
  4. Bulk select both reports from workspace chat A and B.
  5. Click Change workspace.
  6. Select workspace B > Save.

Expected Result:

Modal will show “Changed workspace on 1 of 2 reports” as 2 reports are selected.

Actual Result:

Modal shows “Changed workspace on 1 of 1 report” when 2 reports are selected.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7310702_1794360622139.3.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7310702

Issue OwnerCurrent Issue Owner: @mollfpr

Activity

  1. applause-bot commented on Nov 11, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/dc88f60e66202a45f273a92e40c7d4b2e4f9e6fd4018b6ca7c4d8fcc244f5c6b

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 11, 2026
  3. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #104295

  4. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    @JS00001 @mollfpr @Eskalifer1 you have been assigned to this deploy blocker because you reviewed the offending PR: #104295

  5. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    @allgandalf you have been assigned to this deploy blocker because you authored the offending PR: #104295

  6. melvin-bot commented on Nov 11, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 11, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 11, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    Introducing PR identified with high confidence: Add Change workspace to Search bulk actions, included in release 9.5.36-0.

    The evidence points to a selected-versus-changed report counting mismatch, not incorrect pluralization. Both selected reports are submitted, but the modal displays the bulk operation’s counts. The report already in workspace B appears to be excluded from that total.

    The exact count-producing defect remains unconfirmed: this investigation was static; no runtime response or backend producer was inspected.

    Supporting evidence and alternative explanations

    What changes do you think we should make in order to solve the problem?

    Prefer a targeted roll-forward, but confirm the counting contract before implementation. An internal engineer should trace the submitted request and resulting bulk-action updates to establish where the selected count becomes the changed count. If that producer is outside App, escalate the fix to an internal engineer with access.

    The acceptance criterion requires distinguishing selected, changed, failed, and skipped reports. Simply increasing total is insufficient: the current arithmetic would incorrectly show “2 of 2.”

    What alternative solutions did you explore? (Optional)

    Reverting the introducing PR would remove the entire new bulk-workspace feature. A targeted accounting correction is preferable if it can be verified promptly; otherwise, reverting remains the release-unblocking fallback.


    Next Steps for Contributor+ team: Confirm the response/count producer and skipped-report semantics before requesting implementation.


    view run

  9. mollfpr commented on Nov 11, 2026

    @mollfpr
    Contributor

    The count comes from the backend. Reports that are already in the target workspace get dropped before the job runs, so the total only counts the reports that were moved. The fix needs a backend change, so I'm removing the blocker label. I'll open a follow-up for it.

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 11, 2026
  11. Eskalifer1 commented on Nov 11, 2026

    @Eskalifer1
    Contributor

    I have raised that during PR here: #104295 (review) (3rd point)

    #104295 (comment) - seems like expected. The original PR was already quite big; I think if we want to fix this, we can do so in a follow-up.

    cc: @mollfpr

  12. mollfpr commented on Nov 16, 2026

    @mollfpr
    Contributor

    Still working on the backend changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions