Skip to content

[Pending Payment] [$250] Web/Desktop - Workspace settings side menu does not open after creating workspace #10665

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Navigate to staging and login
  2. Create Workspace

Expected Result:

Workspace should be created and side menu Workspace settings should be open.

Actual Result:

Workspace is created but side menu Workspace settings isn't open. Only popup appeared.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: v1.1.93-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5709463_WS

Bug5709463_WS.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Aug 29, 2022

    @melvin-bot

    Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. joelbettner commented on Aug 30, 2022

    @joelbettner

    I think we can make this an external.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Aug 30, 2022
  4. melvin-bot commented on Aug 30, 2022

    @melvin-bot

    Triggered auto assignment to @NicMendonca (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  5. jayeshmangwani commented on Aug 30, 2022

    @jayeshmangwani
    Contributor

    Proposal

    we need to pass the array in this Promise.all in create function

    return Promise.all(
    Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${response.policyID}`, {
    id: response.policyID,
    type: response.policy.type,
    name: response.policy.name,
    role: CONST.POLICY.ROLE.ADMIN,
    outputCurrency: response.policy.outputCurrency,
    }),
    Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_MEMBER_LIST}${response.policyID}`, getSimplifiedEmployeeList(response.policy.employeeList)),

    +return Promise.all([
      Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${response.policyID}`, {
          id: response.policyID,
          type: response.policy.type,
          name: response.policy.name,
          role: CONST.POLICY.ROLE.ADMIN,
          outputCurrency: response.policy.outputCurrency,
      }),
      Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_MEMBER_LIST}${response.policyID}`, getSimplifiedEmployeeList(response.policy.employeeList)),
    +]);
    issue-10665.mov
  6. trjExpensify commented on Aug 30, 2022

    @trjExpensify
    Contributor

    Adding yah back for CM, @NicMendonca.

  7. NicMendonca commented on Aug 30, 2022

    @NicMendonca
    Contributor
  8. 17 remaining items

  9. melvin-bot commented on Aug 31, 2022

    @melvin-bot

    📣 @jayeshmangwani You have been assigned to this job by @Beamanator!
    Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  10. jayeshmangwani commented on Aug 31, 2022

    @jayeshmangwani
    Contributor

    this change is added in this PR and it merged 2 hours ago to the main branch.

    cc: @rushatgabhane @Beamanator

  11. Beamanator commented on Aug 31, 2022

    @Beamanator
    Contributor

    Oh nice thanks for the link @jayeshmangwani 👍 Looks like it's on Staging already

  12. jasperhuangg commented on Aug 31, 2022

    @jasperhuangg
    Contributor

    my b guys, I never saw this issue and was assigned that other issue as demolitions so decided to fix it super quick, let's close this out.

  13. jayeshmangwani commented on Aug 31, 2022

    @jayeshmangwani
    Contributor

    Oh nice thanks for the link @jayeshmangwani 👍 Looks like it's on Staging already

    I have a doubt here, am I eligible or not for the payment in this scenario?
    cc: @rushatgabhane @Beamanator

  14. Beamanator commented on Sep 2, 2022

    @Beamanator
    Contributor

    @jayeshmangwani good question, I'm running this by some internal team members, will get back to you soon 👍

  15. Beamanator commented on Sep 2, 2022

    @Beamanator
    Contributor

    Discussed internally (here) and we are happy to pay you for your time looking into this solution, adding your proposal, and getting selected (even though the fix was completed internally).

    @NicMendonca would you please pay @jayeshmangwani and close this out? :)

  16. jayeshmangwani commented on Sep 6, 2022

    @jayeshmangwani
    Contributor

    @Beamanator Thanks for the update,

    @NicMendonca I have applied at Upwork.

  17. changed the title [-][$250] Web/Desktop - Workspace settings side menu does not open after creating workspace[/-] [+][Pending Payment] [$250] Web/Desktop - Workspace settings side menu does not open after creating workspace[/+] on Sep 7, 2022
  18. NicMendonca commented on Sep 7, 2022

    @NicMendonca
    Contributor

    ^ Reopening so I can better track this via K2

    @jayeshmangwani Can you please accept the offer in Upwork when you get the chance? Thanks!

  19. jayeshmangwani commented on Sep 7, 2022

    @jayeshmangwani
    Contributor

    @NicMendonca offer accepted 🚀

  20. NicMendonca commented on Sep 7, 2022

    @NicMendonca
    Contributor

    paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions