Skip to content

Category visibility - Thread header and thread message does not match #107018

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.39-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #105184
Email or phone of affected tester (no customers): joinsdjosjdojosijdiosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable categoryVisibility beta.
  • Create a Control workspace.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Click on your profile.
  4. Click Category visibility.
  5. Unselect any category > Save,
  6. Go to #admins room.
  7. Right click on "set everyone to only see 16 categories" > Reply in thread.

Expected Result:

Thread header and thread message should match.

Actual Result:

Thread header and thread message does not match.
Thread header shows ""set everyone to only see 16 categories".
Thread message shows "vuay al lc.vcnl
Categories: "Car", "Fees", "Home Office", "Insurance", "Interest", "Labor", "Maintenance", "Materials", "Meals and Entertainment", "Office Supplies", "Other", "Professional Services", "Rent", "Taxes", "Travel", and "Utilities".

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7315718_1794848123005.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7315718

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 16, 2026
  2. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #105184

  3. applause-bot commented on Nov 16, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/9a2a481d503baf327e4051b606ea222a61372ce3546ad27fe47e4d3e109ea9aa

  4. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    @chiragsalian @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #105184

  5. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    @nkdengineer you have been assigned to this deploy blocker because you authored the offending PR: #105184

  6. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 16, 2026

    @MelvinBot
    Contributor

    Investigation: acceptance criteria conflict

    The reported behavior matches the original specification. I recommend clarifying the expected presentation before reverting either PR.

    Attribution: Show category visibility change logs in #admins introduced the differing presentations—not the category-visibility picker PR identified by the assignment bot.

    Evidence and rendering mechanism
    • The thread header requests the compact summary: “set everyone to only see 16 categories.” See computeReportName.ts:517–519.
    • The parent message inside the thread requests expanded details. For 10 or more categories, the formatter returns the category list instead of the summary sentence. See ReportActionsUtils.ts:3883–3920.
    • The original specification explicitly requires full category/member lists for thread-parent messages. Existing tests assert that distinction.
    • A later review comment expects the compact sentence inside the thread, conflicting with the specification and tests.

    The rendering PR reached staging before the reported version. Its web code also reached production, but production feature availability and reproduction remain unverified.

    Recommended next action: Confirm whether the thread parent should display expanded details only or the summary plus expanded details. If matching wording is required, prefer a narrow formatter-and-test update over reverting either feature PR.

    Confidence: High on the rendering mechanism and introducing PR; whether this constitutes a defect remains unresolved. No browser reproduction or test execution was performed. No code, labels, or assignments were changed.


    view run

  9. chiragsalian commented on Nov 16, 2026

    @chiragsalian
    Contributor

    Demoting, minor UI issue and not blocker worthy. But i agree, threaded headers always show in the body.
    So @daledah @nkdengineer, assuming this is the header,

    set everyone to only see 16 categories
    

    Can we update the threaded message to be,

    set everyone to only see 16 categories
    Categories: "Car", "Fees", "Home Office", "Insurance", "Interest", "Labor", "Maintenance", "Materials", "Meals and Entertainment", "Office Supplies", "Other", "Professional Services", "Rent", "Taxes", "Travel", and "Utilities".
    
  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions