You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Members - Category visiblity does not show "All categories" when member is invited offline #107019
Version Number: 9.5.39-2 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#105184 Email or phone of affected tester (no customers):joinsdjosjdojosijdiosnj@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Workspace Settings
Action Performed:
Precondition:
Enable categoryVisibility beta.
Create a Control workspace.
Go to staging.new.expensify.com
Go to workspace settings > Members.
Click on your profile.
Click Category visibility.
Unselect any category > Save,
Go offline.
Click Invite member.
Invite a member to the workspace.
Open member's profile.
Go online
Expected Result:
Category visiblity field will show "All categories" when member is invited offline.
Actual Result:
Category visiblity field shows "n categories" when member is invited offline, then it changes to "All categories" after returning online.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Inviting a member offline adds them to the workspace optimistically, but does not add them to restricted categories’ visibility lists.
Restricting your own visibility creates explicit lists of existing members for those categories. The new invitee is missing from those lists, so their profile shows fewer categories until the server response corrects the local state.
Code and release evidence
The feature creates explicit membership lists when restricting visibility: Category.ts:2139–2166.
Retest the reported flow with both existing-account and new-email invitees. Confirm “All categories” appears offline and remains unchanged after reconnecting. Keep the deploy blocker until verified.
What alternative solutions did you explore?
Reverting the original feature is broader than applying the existing targeted fix. A translation-only change would hide the incorrect local state rather than repair it.
Verification limits: Static source and release-history evidence strongly support this diagnosis. No browser verification was performed; a targeted Jest invocation was denied by execution permissions. The fix is therefore not runtime-verified in this investigation.
Next Steps for Contributor+ team: To accept: Apply the existing merged fix to staging and verify; no duplicate PR is needed. To refine:@MelvinBot <your feedback> To reject: Explain why you are rejecting Melvin’s proposal.
Activity
applause-bot commentedon Nov 16, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/1b4894ceeb8d8e03cdb15efb1ae82f7e570bd8963d69b7b1d2b3dae3860a7a51
expensify-chore-bot commentedon Nov 16, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #105184
expensify-chore-bot commentedon Nov 16, 2026
@chiragsalian @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #105184
expensify-chore-bot commentedon Nov 16, 2026
@nkdengineer you have been assigned to this deploy blocker because you authored the offending PR: #105184
expensify-chore-bot commentedon Nov 16, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 16, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 16, 2026
Proposal
Recommendation: roll forward with the already-merged fix. The
deploy-blocker-investigatortraced this to Add Category visibility row and category picker to member details. The fix in the merged category-visibility invitation update is absent from staging version 9.5.39-2.What is the root cause of that problem?
Inviting a member offline adds them to the workspace optimistically, but does not add them to restricted categories’ visibility lists.
Restricting your own visibility creates explicit lists of existing members for those categories. The new invitee is missing from those lists, so their profile shows fewer categories until the server response corrects the local state.
Code and release evidence
What changes do you think we should make in order to solve the problem?
Cherry-pick the existing invitation/category-visibility fix onto staging, reviewing conflicts rather than creating a duplicate implementation.
That fix updates restricted categories optimistically and handles rollback and temporary account IDs: Member.ts:867–899. It includes invitation, rollback, and temporary-ID regression tests.
Retest the reported flow with both existing-account and new-email invitees. Confirm “All categories” appears offline and remains unchanged after reconnecting. Keep the deploy blocker until verified.
What alternative solutions did you explore?
Reverting the original feature is broader than applying the existing targeted fix. A translation-only change would hide the incorrect local state rather than repair it.
Verification limits: Static source and release-history evidence strongly support this diagnosis. No browser verification was performed; a targeted Jest invocation was denied by execution permissions. The fix is therefore not runtime-verified in this investigation.
Next Steps for Contributor+ team:
To accept: Apply the existing merged fix to staging and verify; no duplicate PR is needed.
To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin’s proposal.
view run
chiragsalian commentedon Nov 16, 2026
Not a blocker. Feature is behind a beta and the fix for this has been merged and will go to staging in the next deploy. No need to CP.