Skip to content

Members - Category visiblity does not show "All categories" when member is invited offline #107019

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.39-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #105184
Email or phone of affected tester (no customers): joinsdjosjdojosijdiosnj@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Enable categoryVisibility beta.
  • Create a Control workspace.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Click on your profile.
  4. Click Category visibility.
  5. Unselect any category > Save,
  6. Go offline.
  7. Click Invite member.
  8. Invite a member to the workspace.
  9. Open member's profile.
  10. Go online

Expected Result:

Category visiblity field will show "All categories" when member is invited offline.

Actual Result:

Category visiblity field shows "n categories" when member is invited offline, then it changes to "All categories" after returning online.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7315722_1794848323228.2.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Svetlana Lazutkina
Bug ID: 7315722

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 16, 2026
  2. applause-bot commented on Nov 16, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/1b4894ceeb8d8e03cdb15efb1ae82f7e570bd8963d69b7b1d2b3dae3860a7a51

  3. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #105184

  4. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    @chiragsalian @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #105184

  5. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    @nkdengineer you have been assigned to this deploy blocker because you authored the offending PR: #105184

  6. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 16, 2026

    @MelvinBot
    Contributor

    Proposal

    Recommendation: roll forward with the already-merged fix. The deploy-blocker-investigator traced this to Add Category visibility row and category picker to member details. The fix in the merged category-visibility invitation update is absent from staging version 9.5.39-2.

    What is the root cause of that problem?

    Inviting a member offline adds them to the workspace optimistically, but does not add them to restricted categories’ visibility lists.

    Restricting your own visibility creates explicit lists of existing members for those categories. The new invitee is missing from those lists, so their profile shows fewer categories until the server response corrects the local state.

    Code and release evidence
    • The feature creates explicit membership lists when restricting visibility: Category.ts:2139–2166.
    • Its visibility calculation excludes members missing from those lists: CategoryUtils.ts:117–124.
    • Staging’s optimistic invitation updates omit category visibility: Member.ts:895–940.
    • The inspected staging commit identifies itself as version 9.5.39-2: package.json:1–5.
    • History confirms the original feature is included in that staging commit, while the merged fix is not.

    What changes do you think we should make in order to solve the problem?

    Cherry-pick the existing invitation/category-visibility fix onto staging, reviewing conflicts rather than creating a duplicate implementation.

    That fix updates restricted categories optimistically and handles rollback and temporary account IDs: Member.ts:867–899. It includes invitation, rollback, and temporary-ID regression tests.

    Retest the reported flow with both existing-account and new-email invitees. Confirm “All categories” appears offline and remains unchanged after reconnecting. Keep the deploy blocker until verified.

    What alternative solutions did you explore?

    Reverting the original feature is broader than applying the existing targeted fix. A translation-only change would hide the incorrect local state rather than repair it.

    Verification limits: Static source and release-history evidence strongly support this diagnosis. No browser verification was performed; a targeted Jest invocation was denied by execution permissions. The fix is therefore not runtime-verified in this investigation.


    Next Steps for Contributor+ team:
    To accept: Apply the existing merged fix to staging and verify; no duplicate PR is needed.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin’s proposal.


    view run

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 16, 2026
  10. chiragsalian commented on Nov 16, 2026

    @chiragsalian
    Contributor

    Not a blocker. Feature is behind a beta and the fix for this has been merged and will go to staging in the next deploy. No need to CP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions