Skip to content

[Category Visibility] 1.b.3 [Ring1][Auth] Categories can't be turned off while a member's category visibility is restricted #107057

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.40-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #106674
Email or phone of affected tester (no customers): sjoidjnisojdosn@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • Create a Control workspace.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Members.
  3. Click on your profile.
  4. Click Category visibility.
  5. Unselect any category > Save,
  6. Go to workspace settings > More features.
  7. Disable Categories.

Expected Result:

Categories will be disabled.

Actual Result:

Categories is auto enabled after changing category visibility settings and disabling Categories.
User is not able to disable it.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7316037_1794869156083.3.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Chandana Kiran
Bug ID: 7316037

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 16, 2026
  2. applause-bot commented on Nov 16, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/6fc1dc58847b63e259eb15e564563b4cefa41109ab560921539e7712a3eaab1f

  3. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #106674

  4. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    @chiragsalian @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #106674

  5. github-actions commented on Nov 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    @nkdengineer you have been assigned to this deploy blocker because you authored the offending PR: #106674

  7. expensify-chore-bot commented on Nov 16, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  8. MelvinBot commented on Nov 16, 2026

    @MelvinBot
    Contributor

    🤖 Web test steps verification results: ❌ fail

    Verification was blocked: dev NewDot displayed a blank page and the browser session reported connection loss. The reported behavior could not be confirmed or disproved through runtime testing.

    Blank web app preventing workspace setup and verification

    Step Status
    Create Control workspace and open Members > own profile > Category visibilityBlocked before setup because no app UI rendered.
    Blank web app preventing workspace setup and verification
    ❌
    Unselect a category and successfully SaveNot reached. Source investigation confirms that saving visibility restrictions changes category visibleTo membership: Category.ts:1882–1906.
    ❌
    Disable Categories under More features and check persistenceNot reached in the browser.
    Investigation finding: Remove the category visibility beta is confirmed as the rollout exposing this flow, not conclusively as the origin of the underlying failure. It removes access gating without changing the disable action. It is included in the 9.5.40-0 staging checklist.
    Mechanism: The More features switch calls an action that optimistically disables the feature and every category, without transitioning visibility restrictions. Its failure handler explicitly re-enables Categories, matching the reported switch bounce.
    Recommendation: Keep the deploy blocker and revert the beta-removal rollout to limit further exposure. This restores gating; it does not repair restrictions already saved or fix beta users. Production still has the feature behind its beta gate.
    ❌
    Capture EnablePolicyCategories enabled=false response, jsonCode, and messageNo request was captured.
    Remaining uncertainty: Backend rejection of disabling restricted categories is the leading hypothesis, not a verified root cause. A server response or subsequent update could also restore the flag. Capture the disable response after a confirmed successful visibility save before choosing a functional fix; do not assume a specific validation error. Confidence is high for rollout attribution, medium for the failure mechanism.
    ❌

    view run · no recording available

  9. chiragsalian commented on Nov 16, 2026

    @chiragsalian
    Contributor

    Looks like a valid bug. The fix for this is in the backend. Investigating.

  10. changed the title [-]Categories - Unable to disable Categories after changing category visibility settings[/-] [+][Category Visibility] 1.b.3 [Ring1][Auth] Categories can't be turned off while a member's category visibility is restricted[/+] on Nov 16, 2026
  11. chiragsalian commented on Nov 17, 2026

    @chiragsalian
    Contributor

    The fix for this is in Auth. The PR is merged. It should be deployed tomorrow and then i'll remove the blocker label on this.
    If this is the last thing holding up deploy we can revert the beta PR i.e., this or disregard this blocker. I think the latter is fine because this is an edge case and not a common scenario and we have a fix that will go live soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DeployBlockerCashThis issue or pull request should block deploymentEngineeringHourlyKSv2ReviewingHas a PR in review

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions