Skip to content

[Due for payment 2026-11-25] Expense - "Car" is still shown for member´s distance expense, despite being restricted. #107066

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.40-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #106674
Email or phone of affected tester (no customers): ibellicotest+3215@gmail.com
Issue reported by: Applause Internal Team
Bug source: Pull Request QA execution
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Money Requests

Action Performed:

Prerequisite: User is owner of a "Control" workspace with "Categories" enabled.
Prerequisite 2: User B is a member of a workspace.

  1. Open the staging.new.expensify.com website.
  2. Navigate to "Workspaces" > Workspace > "Members"
  3. Open User B´s profile > "Categories visibility"
  4. Disable all the categories except one of them, different from "Car". (For example: Benefits)
  5. As User B, navigate to workspace chat.
  6. Click on "+" button > "Track Distance" > "Map"
  7. Note that "Category" field shows "Car" as selected category.
  8. Click on "Category"
  9. Note that "Car" and "Benefits" are the only categories shown, despite "Car" being restricted.

Expected Result:

"Car" shouldn´t be displayed available while creating a distance expense if it is restricted.

Actual Result:

"Car" is still displayed while member creates a distance expense, despite being already restricted by admin of the workspace.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7316066_1794872274203.Visible_7.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Alberto Gutierrez
Bug ID: 7316066

Issue OwnerCurrent Issue Owner: @nkdengineer

Activity

  1. applause-bot commented on Nov 17, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/1920d5a2fd8904a2c270c312453f3a678640b67ddaf9212e6693228710251f2e

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 17, 2026
  3. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #106674

  4. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    @chiragsalian @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #106674

  5. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    @nkdengineer you have been assigned to this deploy blocker because you authored the offending PR: #106674

  6. expensify-chore-bot commented on Nov 17, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 17, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 17, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    Distance-expense defaulting does not check the member’s category visibility. A restricted default such as “Car” can therefore enter a new draft. The category picker then preserves that already-selected category alongside permitted categories, explaining “Car” plus “Benefits.”

    Remove the category visibility beta exposed this defect by removing the configuration gates; it did not introduce the distance-defaulting logic.

    Code evidence and causation

    Confidence: medium. Static evidence explains both symptoms, but no runtime reproduction or affected-account payload was captured. The tester’s exact source of “Car” remains unverified.

    What changes do you think we should make in order to solve the problem?

    Prevent new distance drafts from receiving a default category unavailable to the expense owner. Audit all distance-default writers, not just the picker. Preserve the intentional display of restricted categories on existing expenses.

    Deploy recommendation: Keep the blocker. If a verified forward fix cannot land before deployment, revert the category-visibility rollout. That restores configuration gates but does not clear existing restrictions or repair affected drafts.

    What alternative solutions did you explore? (Optional)

    Hiding restricted selected rows globally would address the appearance, not the invalid default, and could regress existing-expense behavior. Reverting picker filtering would weaken restrictions rather than fix this defect.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/107066) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  9. chiragsalian commented on Nov 17, 2026

    @chiragsalian
    Contributor

    Oh interesting bug, nice catch. I dont feel like its blocker worthy though, removing label. We've got a PR merged so it should go out soon after.

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 17, 2026
  11. changed the title [-]Expense - "Car" is still shown for member´s distance expense, despite being restricted.[/-] [+][Due for payment 2026-11-25] Expense - "Car" is still shown for member´s distance expense, despite being restricted.[/+] on Nov 18, 2026
  12. melvin-bot commented on Nov 18, 2026

    @melvin-bot

    @nkdengineer / @daledah

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.41-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-11-25. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

  13. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringOverdue

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions