You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Has filter is not applied when enter group-by:violation from search #107476
Version Number: 9.5.43-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#107141 Email or phone of affected tester (no customers):gocemate+mizar333@gmail.com Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: windows 11/chrome App Component: Other
Action Performed:
Precondition: Has some expense with violation and it's submitted/approved
Steps:
Enable Rule feature in a workspace
Open the search router
Enter group-by:violation
Select this option
Verify you navigate to Spend tab and expenses are displayed
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Add group-by:violation introduced different behavior between the Display menu and search-router entry: only the Display-menu path automatically adds the violation Has filters.
This explains the missing visible filter without requiring a backend failure. Confidence: high for the frontend cause. Browser reproduction and backend result equivalence were not independently verified.
What changes do you think we should make in order to solve the problem?
Apply the same default submitted/approved violation filters when selecting violation grouping through the search router. Preserve explicitly selected stages and unrelated filters.
Add regression coverage for router entry, Display-menu parity, and explicit-stage preservation.
What alternative solutions did you explore? (Optional)
Changing the generic parser could affect intentionally supported raw queries; prefer the narrower router behavior change. Reverting the feature appears disproportionate to the reported inconsistency.
Next Steps for Contributor+ team: To accept: Request implementation of this proposal. To refine: Reply with feedback. To reject: Explain why you are rejecting Melvin's proposal.
Activity
applause-bot commentedon Nov 19, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/21f0a9b693b39be065f584f1d6195b4f1b6a211f43f1f81d55debb0e97282df2
expensify-chore-bot commentedon Nov 19, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #107141
expensify-chore-bot commentedon Nov 19, 2026
@neil-marcellini you have been assigned to this deploy blocker because you reviewed the offending PR: #107141
expensify-chore-bot commentedon Nov 19, 2026
@nkdengineer you have been assigned to this deploy blocker because you authored the offending PR: #107141
expensify-chore-bot commentedon Nov 19, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
neil-marcellini commentedon Nov 19, 2026
I don't think this needs to block release. It works fine and I don't think most people will do this, it's just a little inconsistent.
neil-marcellini commentedon Nov 19, 2026
I'll have AI put up a fix
MelvinBot commentedon Nov 19, 2026
Proposal
Recommendation: keep this non-blocking. Expenses still display, and the reviewer confirmed this is an inconsistency. The issue already has no deploy-blocker label.
What is the root cause of that problem?
Add group-by:violation introduced different behavior between the Display menu and search-router entry: only the Display-menu path automatically adds the violation Has filters.
Supporting evidence
group-by:violationwithout filters.This explains the missing visible filter without requiring a backend failure. Confidence: high for the frontend cause. Browser reproduction and backend result equivalence were not independently verified.
What changes do you think we should make in order to solve the problem?
Apply the same default submitted/approved violation filters when selecting violation grouping through the search router. Preserve explicitly selected stages and unrelated filters.
Add regression coverage for router entry, Display-menu parity, and explicit-stage preservation.
What alternative solutions did you explore? (Optional)
Changing the generic parser could affect intentionally supported raw queries; prefer the narrower router behavior change. Reverting the feature appears disproportionate to the reported inconsistency.
Next Steps for Contributor+ team:
To accept: Request implementation of this proposal.
To refine: Reply with feedback.
To reject: Explain why you are rejecting Melvin's proposal.
view run
nkdengineer commentedon Nov 20, 2026
@neil-marcellini it's a known issue as I asked in the previous PR here #107141 (comment)