Skip to content

Log in - Missing re-sent link message when you click Forgot password #10754

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. In log in page enter your username
  3. Click continue
  4. Click Forgot Password

Expected Result:

Re-sent link message should be appears when you click Forgot password

Actual Result:

Missing re-sent link message when you click Forgot password

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.96.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5713317_Recording__1056.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Sep 1, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 1, 2022

    @melvin-bot

    Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. arosiclair commented on Sep 1, 2022

    @arosiclair
    Contributor

    I can easily reproduce this in staging, however the reset email is still sent without issue so I don't think this is a blocking issue.

  4. arosiclair commented on Sep 1, 2022

    @arosiclair
    Contributor

    cc @jasperhuangg it looks like your refactor PR was the last to touch this

  5. bondydaa commented on Sep 2, 2022

    @bondydaa
    Contributor

    I can easily reproduce this in staging, however the reset email is still sent without issue so I don't think this is a blocking issue.

    be careful here, when you click Forgot Password we trigger 1 email automatically.

    Clicking the Resend button should send a second one.

  6. bondydaa commented on Sep 2, 2022

    @bondydaa
    Contributor

    This is probably from Jasper's / my PR #10556

    we refactored a component in there - let me take a deeper look.

  7. luacmartins commented on Sep 2, 2022

    @luacmartins
    Contributor

    I have a fix for it, testing now.

  8. bondydaa commented on Sep 2, 2022

    @bondydaa
    Contributor

    Just to update slightly there will be another small regression here where clicking the Forgot? button will automatically show the Green Brick Road message when it takes you to the next step for the time being like this: image

    This is fine and expected for now, we are cleaning it up on #10785

  9. melvin-bot commented on Sep 2, 2022

    @melvin-bot

    ⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions