You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Log in - Missing re-sent link message when you click Forgot password #10754
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Just to update slightly there will be another small regression here where clicking the Forgot? button will automatically show the Green Brick Road message when it takes you to the next step for the time being like this:
This is fine and expected for now, we are cleaning it up on #10785
Activity
OSBotify commentedon Sep 1, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Sep 1, 2022
Triggered auto assignment to @arosiclair (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.arosiclair commentedon Sep 1, 2022
I can easily reproduce this in staging, however the reset email is still sent without issue so I don't think this is a blocking issue.
arosiclair commentedon Sep 1, 2022
cc @jasperhuangg it looks like your refactor PR was the last to touch this
bondydaa commentedon Sep 2, 2022
be careful here, when you click
Forgot Passwordwe trigger 1 email automatically.Clicking the Resend button should send a second one.
bondydaa commentedon Sep 2, 2022
This is probably from Jasper's / my PR #10556
we refactored a component in there - let me take a deeper look.
luacmartins commentedon Sep 2, 2022
I have a fix for it, testing now.
bondydaa commentedon Sep 2, 2022
Just to update slightly there will be another small regression here where clicking the
Forgot?button will automatically show the Green Brick Road message when it takes you to the next step for the time being like this:This is fine and expected for now, we are cleaning it up on #10785
melvin-bot commentedon Sep 2, 2022
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.