Skip to content

Expenses with fixed violations are listed under violation filter #107576

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.49-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #107141
Email or phone of affected tester (no customers): gocemate+bazzo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: windows 11/chrome
App Component: Other

Action Performed:

  1. Create workspace and enable Rules option
  2. Go to workspace chat and create expenses with violation ( Duplicate potential)
  3. Go to Spend> Display> Group by> Violation
  4. Verify expenses with violation are displayed
  5. Reset this filter
  6. Edit one of duplicate expenses (change amount, merchant..), so the violation is fixed
  7. Go to Spend> Display> Group by> Violation

Expected Result:

There should be no expenses displayed

Actual Result:

Fixed violation expenses are still displayed under violation filter

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7319924_1795174651860.Recording__152.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7319924

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 20, 2026
  2. applause-bot commented on Nov 20, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/59b2838fee059e6fc8f5bd056eb5ae4d039fbee9c04786e0a96f982d40befc0c

  3. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #107141

  4. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @neil-marcellini you have been assigned to this deploy blocker because you reviewed the offending PR: #107141

  5. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @nkdengineer you have been assigned to this deploy blocker because you authored the offending PR: #107141

  6. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 20, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 20, 2026

    @MelvinBot
    Contributor

    Investigation result

    No regression confirmed. Add group-by:violation introduced this flow, but the evidence does not yet justify reverting it.

    Violation grouping intentionally uses violations recorded when expenses were submitted or approved, rather than their current warnings. Resolving a duplicate afterward may therefore leave it in these results.

    Supporting evidence

    These establish intended semantics—not whether the reported expenses correctly qualify.

    Missing evidence: The reproduction steps omit submission/approval history. No browser reproduction or affected search response was verified, so stale or incorrect membership remains possible.

    Recommendation: Keep the blocker pending verification of that history and a fresh search response. If matching historical duplicate violations exist, persistence is expected; if they do not, investigate incorrect membership. Do not revert the feature solely on the current evidence.

    Confidence: High on intended behavior; unresolved on this specific reproduction.


    view run

  9. nkdengineer commented on Nov 20, 2026

    @nkdengineer
    Contributor

    @neil-marcellini I think it's not a bug as the group capture the violation at the submitted/approved time.

  10. trjExpensify commented on Nov 20, 2026

    @trjExpensify
    Contributor

    I agree, this is not a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions