Skip to content

User can open group-by:violation via search when rules are disabled #107581

Closed as not planned

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.49-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #107141
Email or phone of affected tester (no customers): gocemate+hdhdhd@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: windows 11/chrome
App Component: Other

Action Performed:

Precondition: User have a workspace with Rules disabled

Steps:

  1. Open the search router
  2. Enter group-by:

Expected Result:

There should be no group-by:violation suggestion when Rules are disabled

Actual Result:

group-by:violation suggestion is displayed
When user navigate to this option, violation filter is listed in Display> Group by

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7319949_1795176438630.Recording__153.1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7319949

Activity

  1. applause-bot commented on Nov 20, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/a2cc9f76c3b54097687a4b8898d39b64b345b071fcfefa7d8ad4ce5fec113caa

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 20, 2026
  3. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #107141

  4. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @neil-marcellini you have been assigned to this deploy blocker because you reviewed the offending PR: #107141

  5. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @nkdengineer you have been assigned to this deploy blocker because you authored the offending PR: #107141

  6. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 20, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 20, 2026

    @MelvinBot
    Contributor

    Proposal

    Causing PR: “[Insights: Violations][R3] Add group-by:violation”. High confidence from code and release history; browser reproduction not performed.

    What is the root cause of that problem?

    The PR enables violation grouping globally, but applies the Rules-availability check only to the Display menu—not search autocomplete.

    Consequently, autocomplete offers group-by:violation even without an eligible Rules-enabled workspace. Selecting it then makes Violation appear in Display because that menu intentionally preserves the currently selected grouping.

    Supporting evidence

    Reproduction caveat: Availability considers all eligible accessible workspaces. Confirm that none has Rules enabled—not just the workspace mentioned in the report. The reporter’s workspace state was not independently verified.

    What changes do you think we should make in order to solve the problem?

    Apply the existing violation-availability check to the group-by autocomplete branch. Preserve other grouping suggestions and the selected-value Display label.

    Add regression coverage for:

    • No eligible Rules-enabled workspace: omit violation for both group-by: and group-by:vio.
    • An eligible Rules-enabled workspace: offer violation.
    • Rules toggled off: update suggestions without reloading.
    • Other grouping suggestions remain unchanged.

    What alternative solutions did you explore?

    Deployment fallback: Revert the causing PR if a targeted fix cannot be verified promptly. Revert cleanliness and downstream dependencies have not been tested. Keep this blocker open pending verification.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/107581) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

  9. neil-marcellini commented on Nov 20, 2026

    @neil-marcellini
    Contributor

    Edge case so I don't think it needs to block.

  10. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 20, 2026
  11. neil-marcellini commented on Nov 20, 2026

    @neil-marcellini
    Contributor

    (Neil's AI agent)

    Closing. Expenses get violations with Rules off too, so we're removing the Rules requirement from violation search (agreed here). Tracked in #107601.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions