Skip to content

Expense - Selected tax rate appears twice in Tax dropdown when bulk editing #107604

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.491
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #106067
Email or phone of affected tester (no customers): joisdnjosnjdiosjio@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Create a non-USD workspace.
  • Enable Taxes.
  • Set Tax Rate 1 (5%) as workspace currency default in Tax settings.
  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create two expenses.
  4. Open the report.
  5. Bulk select both expenses.
  6. Click Edit multiple.
  7. Click Tax dropdown.
  8. Select Tax Rate 1 (5%).
  9. Open Tax dropdown again.

Expected Result:

The selected tax rate will not appear twice.

Actual Result:

The selected tax rate appears twice in Tax dropdown when bulk editing.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7320078_1795188830815.8.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Chandana Kiran
Bug ID: 7320078

Issue OwnerCurrent Issue Owner: @DylanDylann
Issue OwnerCurrent Issue Owner: @DylanDylann

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 20, 2026
  2. applause-bot commented on Nov 20, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/7b362b97369d1c2aa62a1fe1dcbff24429c8188c38cf53fdd2928de8d06cb1b0

  3. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #106067

  4. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @mountiny @ikevin127 you have been assigned to this deploy blocker because you reviewed the offending PR: #106067

  5. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    @DylanDylann you have been assigned to this deploy blocker because you authored the offending PR: #106067

  6. expensify-chore-bot commented on Nov 20, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 20, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 20, 2026

    @MelvinBot
    Contributor

    🤖 Web test steps verification results: ⚠️ partial

    Environment failure blocked all requested product checks. Issue 107604 was not reproduced or disproved.

    Browser state when issue verification was blocked

    Step Status
    App available for testing — investigation findings insideThe browser session was suspended; retry failed and snapshots returned zero nodes.

    Investigation: The deploy-blocker-investigator identified Update the Edit multiple flow to use inline editing and dropdown down style rows as the leading suspected introducing PR. Confidence is medium: code and staging/production comparisons support attribution, but runtime confirmation is blocked.

    Proposal — root cause: The new dropdown receives a transaction-aware selected label but builds its options without transaction context. Their “Default” suffixes can differ. Because filtering compares decorated names rather than tax IDs, the same tax survives as two entries.
    Evidence: selected-label calculation, dropdown configuration, and name-based filtering.

    Important qualification: This mechanism requires different workspace/foreign tax defaults, including an unset foreign default. The affected configuration was not verified. If both defaults match, this explanation is incomplete.

    Proposed change, pending confirmation: Derive the selected label from the same workspace-only tax options, using the tax code, matching the existing selector. Prefer this narrow correction over a broad revert once the default mismatch is confirmed. Test selection/reopening with both identical and distinct defaults. Keep the deploy blocker pending verification. No code or GitHub state was changed.
    Browser state when issue verification was blocked
    ❌
    Configure non-USD workspace, Taxes, and Tax Rate 1 (5%) defaultNot verified: environment blocked access.
    ⚠️
    Record foreign-currency defaultNot verified: environment blocked access.
    ⚠️
    Open workspace chatNot verified: environment blocked access.
    ⚠️
    Create two expensesNot verified: environment blocked access.
    ⚠️
    Open their reportNot verified: environment blocked access.
    ⚠️
    Bulk-select both expensesNot verified: environment blocked access.
    ⚠️
    Click Edit multipleNot verified: environment blocked access.
    ⚠️
    Open Tax dropdownNot verified: environment blocked access.
    ⚠️
    Select Tax Rate 1 (5%)Not verified: environment blocked access.
    ⚠️
    Reopen Tax dropdown and check for duplicationNot verified: environment blocked access.
    ⚠️
    Compare identical versus distinct workspace/foreign defaultsNot verified: environment blocked access.
    ⚠️

    view run · no recording available

  9. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 20, 2026
  10. mountiny commented on Nov 20, 2026

    @mountiny
    Contributor

    I think the user is not blocked here so we can demote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions