You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - Selected tax rate appears twice in Tax dropdown when bulk editing #107604
Version Number: 9.5.491 Reproducible in staging?: Yes Reproducible in production?: No If this was caught during regression testing, add the test name, ID and link from BrowserStack:#106067 Email or phone of affected tester (no customers):joisdnjosnjdiosjio@gmail.com Issue reported by: Applause Internal Team Bug source: Exploratory - Significant User Experience Deterioration Device used: Mac 26.5 / Chrome App Component: Money Requests
Action Performed:
Precondition:
Create a non-USD workspace.
Enable Taxes.
Set Tax Rate 1 (5%) as workspace currency default in Tax settings.
Go to staging.new.expensify.com
Go to workspace chat.
Create two expenses.
Open the report.
Bulk select both expenses.
Click Edit multiple.
Click Tax dropdown.
Select Tax Rate 1 (5%).
Open Tax dropdown again.
Expected Result:
The selected tax rate will not appear twice.
Actual Result:
The selected tax rate appears twice in Tax dropdown when bulk editing.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Proposal — root cause: The new dropdown receives a transaction-aware selected label but builds its options without transaction context. Their “Default” suffixes can differ. Because filtering compares decorated names rather than tax IDs, the same tax survives as two entries. Evidence: selected-label calculation, dropdown configuration, and name-based filtering.
Important qualification: This mechanism requires different workspace/foreign tax defaults, including an unset foreign default. The affected configuration was not verified. If both defaults match, this explanation is incomplete.
Proposed change, pending confirmation: Derive the selected label from the same workspace-only tax options, using the tax code, matching the existing selector. Prefer this narrow correction over a broad revert once the default mismatch is confirmed. Test selection/reopening with both identical and distinct defaults. Keep the deploy blocker pending verification. No code or GitHub state was changed.
Activity
applause-bot commentedon Nov 20, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/7b362b97369d1c2aa62a1fe1dcbff24429c8188c38cf53fdd2928de8d06cb1b0
expensify-chore-bot commentedon Nov 20, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #106067
expensify-chore-bot commentedon Nov 20, 2026
@mountiny @ikevin127 you have been assigned to this deploy blocker because you reviewed the offending PR: #106067
expensify-chore-bot commentedon Nov 20, 2026
@DylanDylann you have been assigned to this deploy blocker because you authored the offending PR: #106067
expensify-chore-bot commentedon Nov 20, 2026
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 20, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
MelvinBot commentedon Nov 20, 2026
🤖 Web test steps verification results:⚠️ partial
Environment failure blocked all requested product checks. Issue 107604 was not reproduced or disproved.
App available for testing — investigation findings inside
The browser session was suspended; retry failed and snapshots returned zero nodes.Investigation: The deploy-blocker-investigator identified Update the Edit multiple flow to use inline editing and dropdown down style rows as the leading suspected introducing PR. Confidence is medium: code and staging/production comparisons support attribution, but runtime confirmation is blocked.
Proposal — root cause: The new dropdown receives a transaction-aware selected label but builds its options without transaction context. Their “Default” suffixes can differ. Because filtering compares decorated names rather than tax IDs, the same tax survives as two entries.
Evidence: selected-label calculation, dropdown configuration, and name-based filtering.
Important qualification: This mechanism requires different workspace/foreign tax defaults, including an unset foreign default. The affected configuration was not verified. If both defaults match, this explanation is incomplete.
Proposed change, pending confirmation: Derive the selected label from the same workspace-only tax options, using the tax code, matching the existing selector. Prefer this narrow correction over a broad revert once the default mismatch is confirmed. Test selection/reopening with both identical and distinct defaults. Keep the deploy blocker pending verification. No code or GitHub state was changed.
Configure non-USD workspace, Taxes, and Tax Rate 1 (5%) default
Not verified: environment blocked access.Record foreign-currency default
Not verified: environment blocked access.Open workspace chat
Not verified: environment blocked access.Create two expenses
Not verified: environment blocked access.Open their report
Not verified: environment blocked access.Bulk-select both expenses
Not verified: environment blocked access.Click Edit multiple
Not verified: environment blocked access.Open Tax dropdown
Not verified: environment blocked access.Select Tax Rate 1 (5%)
Not verified: environment blocked access.Reopen Tax dropdown and check for duplication
Not verified: environment blocked access.Compare identical versus distinct workspace/foreign defaults
Not verified: environment blocked access.view run · no recording available
mountiny commentedon Nov 20, 2026
I think the user is not blocked here so we can demote