Skip to content

Rules - "Approve Only" member appears on "Submitters" list on expense defaults rule. #107651

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.52-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #105390
Email or phone of affected tester (no customers): ibellicotest+3215@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Motorola MotoG60 / Android 12 (Hybrid app) - Windows 11 / Chrome
App Component: Workspace Settings

Action Performed:

Prerequisite: User is owner of a "Control" workspace.
Prerequisite 2: "Rules" enabled.

  1. Open the staging.new.expensify.com website.
  2. Navigate to "Workspaces" > Workspace > "Members"
  3. Invite another user to workspace with "Approve Only" role.
  4. Navigate to "Rules" > "Add Rule" > "Apply expense defaults"
  5. Click on "Submitter" field.
  6. Note that just invited member appears on "Submitters" list despite not being able to submit expenses to workspace.

Expected Result:

Only members that are able to submit expenses to workspace should appear on "Submitter" list while creating expense defaults rule.

Actual Result:

Member with "Approve Only" role, is displayed in "Submitters" list while creating expense default rule, despite not being able to submit expenses to workspace.

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7320382_1795231911173.Exp_Default_1.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Chandana Kiran
Bug ID: 7320382

Activity

  1. applause-bot commented on Nov 21, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/3b1affeb34305b996d1428505fc7555cb2c8eff73cae90b2e30d92874404deaf

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 21, 2026
  3. expensify-chore-bot commented on Nov 21, 2026

    @expensify-chore-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #105390

  4. expensify-chore-bot commented on Nov 21, 2026

    @expensify-chore-bot

    @luacmartins @situchan @daledah you have been assigned to this deploy blocker because you reviewed the offending PR: #105390

  5. expensify-chore-bot commented on Nov 21, 2026

    @expensify-chore-bot

    @Krishna2323 you have been assigned to this deploy blocker because you authored the offending PR: #105390

  6. expensify-chore-bot commented on Nov 21, 2026

    @expensify-chore-bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions commented on Nov 21, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. MelvinBot commented on Nov 21, 2026

    @MelvinBot
    Contributor

    Proposal

    What is the root cause of that problem?

    The Submitter picker checks whether someone is a workspace member, but not whether their role allows creating expenses. An “Approve Only” member therefore appears as an eligible submitter.

    Introducing PR: Support more expense default conditions. It introduced the picker with this missing permission check.

    Evidence and release attribution

    Confidence: High from code and release history; not independently browser-reproduced.

    What changes do you think we should make in order to solve the problem?

    Roll forward with a targeted fix; keep the deploy blocker until verified.

    Filter new submitter candidates using each member’s role and the existing canRoleCreateExpenses helper, retaining the identity checks.

    Do not remove Approve Only users from workspace membership globally. Preserve previously saved conditions so they remain visible and removable.

    Verify on web that:

    • A newly invited Approve Only member is excluded.
    • Eligible members remain selectable.
    • “Select all” excludes ineligible members.
    • Previously saved conditions remain removable.

    What alternative solutions did you explore?

    Reverting the introducing PR would remove a substantially broader feature. Prefer the focused fix; consider reverting only if a tested fix cannot land promptly. Revert safety and dependencies were not established.

    Related: Missing search field in the new picker is a separate issue, not a duplicate.


    Next Steps for Contributor+ team:
    To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/107651) to create a draft PR.
    To refine: @MelvinBot <your feedback>
    To reject: Explain why you are rejecting Melvin's proposal.


    view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DeployBlockerCashThis issue or pull request should block deploymentEngineeringHourlyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions