Skip to content

Android - Chat - App crashed after sign in with specific account #11003

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with account applausetester+0901abb@applause.expensifail.com

Expected Result:

Able to sign in with specific account

Actual Result:

App crashed after sign in with specific account

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.2.0.3

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com/Feya86Katya

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220914-173135_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Sep 14, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Sep 14, 2022

    @melvin-bot

    Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. francoisl commented on Sep 14, 2022

    @francoisl
    Contributor

    I can reproduce on v1.2.0-3. I was also able to confirm signing in worked fine on 1.2.0-1 before I manually updated my phone to the latest staging version.
    Looking now to find where the regression happened.

  4. francoisl commented on Sep 15, 2022

    @francoisl
    Contributor

    I can't reproduce the issue on dev so I think it's dependent on the account (maybe it only happens with High Traffic accounts).

    Anyway, this crash we logged in these Authenticate logs could be interesting

     [alXt] NewExpensify crash caught by error boundary - Cannot read property 'avatar' of undefined ~~ errorInfo: '
    {
        "componentStack": "
        in SidebarLinks
        in withOnyx(SidebarLinks)
        in Unknown
        in WithCurrentUserPersonalDetails(Component)
        in Unknown
        in withOnyx(Component)
        in Unknown
        in Unknown
        in RCTView
        in Unknown
        in RCTView
        in Unknown
        in LoginKeyboardAvoidingView
        in RCTView
        in Unknown
        in BaseScreenWrapper
        in Unknown
        in withOnyx(withNetwork(BaseScreenWrapper))
        in Unknown
        in withWindowDimensions(Component)
        in Unknown
        in withNavigation(Component)
        in Unknown
        in ScreenWrapper
        in BaseSidebarScreen
        in SidebarScreen
        in withOnyx(SidebarScreen)
        in Unknown
        in withWindowDimensions(Component)
        in Unknown
        in Unknown
        in withNavigation(withLocalize(Component))
        in Unknown
        in RCTView
        in Unknown
        in AnimatedComponent(View)
        in Unknown
        in RCTView
        in Unknown
        in AnimatedComponent(View)
        in Unknown
        in PanGestureHandler
        in PanGestureHandler
        in DrawerView
        in DrawerViewBase
        in RNGestureHandlerRootView
        in GestureHandlerRootView
        in RCTView
        in Unknown
        in SafeAreaProviderCompat
        in DrawerView
        in Unknown
        in DrawerNavigator
        in BaseDrawerNavigator
        in withWindowDimensions(BaseDrawerNavigator)
        in Unknown
        in MainDrawerNavigator
        in withOnyx(MainDrawerNavigator)
        in Unknown
        in StaticContainer
        in EnsureSingleNavigator
        in SceneView
        in RCTView
        in Unknown
        in RCTView
        in Unknown
        in RCTView
        in Unknown
        in CardSheet
        in RCTView
        in Unknown
        in AnimatedComponent
        in AnimatedComponentWrapper
        in PanGestureHandler
        in PanGestureHandler
        in RCTView
        in Unknown
        in AnimatedComponent
        in AnimatedComponentWrapper
        in RCTView
        in Unknown
        in Card
        in CardContainer
        in RNSScreen
        in AnimatedComponent
        in AnimatedComponentWrapper
        in MaybeFreeze
        in Screen
        in MaybeScreen
        in RNSScreenContainer
        in ScreenContainer
        in MaybeScreenContainer
        in RCTView
        in Unknown
        in Background
        in CardStack
        in RCTView
        in Unknown
        in SafeAreaProviderCompat
        in RNGestureHandlerRootView
        in GestureHandlerRootView
        in StackView
        in CustomRootStackNavigator
        in AuthScreens
        in withOnyx(AuthScreens)
        in Unknown
        in withWindowDimensions(Component)
        in Unknown
        in AppNavigator
        in EnsureSingleNavigator
        in BaseNavigationContainer
        in ThemeProvider
        in NavigationContainerInner
        in NavigationRoot
        in Expensify
        in withOnyx(Expensify)
        in Unknown
        in Unknown
        in BaseErrorBoundary
        in RenderersPropsProvider
        in ListStyleSpecsProvider
        in SharedPropsProvider
        in RenderRegistryProvider
        in RenderHTMLConfigProvider
        in TRenderEngineProvider
        in BaseHTMLEngineProvider
        in HTMLEngineProvider
        in LocaleContextProvider
        in withOnyx(LocaleContextProvider)
        in Unknown
        in _default
        in RNCSafeAreaProvider
        in SafeAreaProvider
        in CurrentDateProvider
        in withOnyx(CurrentDateProvider)
        in Unknown
        in ReportActionsDrafts_Provider
        in withOnyx(ReportActionsDrafts_Provider)
        in Unknown
        in PersonalDetailsProvider
        in withOnyx(PersonalDetailsProvider)
        in Unknown
        in NetworkProvider
        in withOnyx(NetworkProvider)
        in Unknown
        in ComposeProviders
        in OnyxProvider
        in ComposeProviders
        in RNGestureHandlerRootView
        in GestureHandlerRootView
        in App
        in RCTView
        in Unknown
        in RCTView
        in Unknown
        in AppContainer"
    }
    
  5. melvin-bot commented on Sep 15, 2022

    @melvin-bot

    Looks like something related to react-navigation may have been mentioned in this issue discussion.

    As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

    Feel free to drop a note in #expensify-open-source with any questions.

  6. francoisl commented on Sep 15, 2022

    @francoisl
    Contributor

    cc @tgolen - this PR is one of the PRs that also got CP'ed to staging, and it modified SidebarLinks, which appears in the stacktrace. Specifically this line uses .avatar, which could cause the Cannot read property 'avatar' of undefined if personalDetail is undefined.

    https://github.com/Expensify/App/pull/10784/files#diff-733528d957ae6a80eb863637fa5d54278c89c6121998f3574fa8c0aba935daebR352

    Not sure yet if that's the exact issue - I'm mostly just poking around for now.

  7. francoisl commented on Sep 15, 2022

    @francoisl
    Contributor

    Ah wait nevermind, that change is in OptionsListUtils, not SidebarLinks :/

  8. francoisl commented on Sep 15, 2022

    @francoisl
    Contributor

    I posted the issue in Slack to get more eyes on it since I'm kinda stumped at this point.

  9. trjExpensify commented on Sep 15, 2022

    @trjExpensify
    Contributor

    Coming from here, this is impacting iOS, desktop and Web on v1.2.0.3 for me:

    Web:
    image

    iOS:
    image

    Desktop:
    image

  10. self-assigned this
    on Sep 15, 2022
  11. Julesssss commented on Sep 15, 2022

    @Julesssss
    Contributor

    I can reproduce on staging with the account details listed in the description.

    The crash is occurring on this line because the personalDetails object is missing. I see 5500+ unique personal details in Onyx, but applausetester+033122abb@applause.expensifail.com is missing.

    However, on a separate account I can chat with the same user without a crash occurring. So I believe the issue is due to the Onyx updateData not returning all personal details, rather than there being an issue with the specific user account.

  12. Julesssss commented on Sep 15, 2022

    @Julesssss
    Contributor

    I'm going to CP a PR which prevents the crash. I think the missing personalDetails object is the underlying issue that needs to be fixed, but this solution prevents a crash and will let us deploy in the meantime.

  13. Julesssss commented on Sep 15, 2022

    @Julesssss
    Contributor

    Fixed

  14. melvin-bot commented on Sep 15, 2022

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. melvin-bot commented on Sep 15, 2022

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions