Skip to content

[HOLD for payment 2022-12-15] [Image] Web - Profile - The white background in the image changes to black #11063

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
    and login with any account
  2. Go to Settings->Profile->Upload photo
  3. Select an image with a white background and click save

Attachment:
1f98b (2)

Expected Result:

The background on the avatar should remain white

Actual Result:

The white background changes to black

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.1.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5734779_Recording__1914.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Sep 16, 2022

    @melvin-bot

    Triggered auto assignment to @tgolen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. thesahindia commented on Sep 16, 2022

    @thesahindia
    Member

    It's not an issue, it happens because the background is transparent. The result will be the same if we try it on other platforms (e.g. Slack, Whatsapp)

  3. tgolen commented on Sep 16, 2022

    @tgolen
    Contributor

    Shouldn't the transparent background remain transparent though? Is this because it's being converted to a JPEG at some point (and transparency isn't supported)?

  4. parasharrajat commented on Sep 16, 2022

    @parasharrajat
    Member

    It seems like the backend is removing the transparency after processing the image.

  5. varshamb commented on Sep 17, 2022

    @varshamb
    Contributor

    Yes, while saving, image is converting jpeg and jpeg doesn't support transparency.

  6. tgolen commented on Sep 19, 2022

    @tgolen
    Contributor

    All right, sounds like this would be an internal issue for us to fix then on the server. It would be nice to support images with transparent backgrounds.

  7. removed their assignment
    on Sep 19, 2022
  8. added
    InternalRequires API changes or must be handled by Expensify staff
    on Sep 19, 2022
  9. 52 remaining items

  10. Beamanator commented on Dec 2, 2022

    @Beamanator
    Contributor

    HECK ya we are.

    And yes good idea I'll add that ^ follow-up to the tracker! Still won't take it off HOLD till the PR for this one gets to Production (to make sure there's no weird regressions)

  11. trjExpensify commented on Dec 2, 2022

    @trjExpensify
    Contributor

    Cool, makes sense!

  12. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 8, 2022
  13. changed the title [-][Image] Web - Profile - The white background in the image changes to black[/-] [+][HOLD for payment 2022-12-15] [Image] Web - Profile - The white background in the image changes to black[/+] on Dec 8, 2022
  14. melvin-bot commented on Dec 8, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.36-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-12-15. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  15. melvin-bot commented on Dec 8, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Beamanator] The PR that introduced the bug has been identified. Link to the PR: (none, this wasn't a regression)
    • [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: (none, this wasn't a regression)
    • [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: (none, this wasn't a regression)
    • [@trjExpensify / @mallenexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: Adding a profile avatar is covered already here.
  16. Santhosh-Sellavel commented on Dec 9, 2022

    @Santhosh-Sellavel
    Collaborator

    Please assign me this for tracking payment thanks!

  17. trjExpensify commented on Dec 16, 2022

    @trjExpensify
    Contributor

    Sent you a contract, @Santhosh-Sellavel.

  18. trjExpensify commented on Dec 16, 2022

    @trjExpensify
    Contributor

    Cool, settled!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions