You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2022-12-15] [Image] Web - Profile - The white background in the image changes to black #11063
It's not an issue, it happens because the background is transparent. The result will be the same if we try it on other platforms (e.g. Slack, Whatsapp)
Shouldn't the transparent background remain transparent though? Is this because it's being converted to a JPEG at some point (and transparency isn't supported)?
All right, sounds like this would be an internal issue for us to fix then on the server. It would be nice to support images with transparent backgrounds.
And yes good idea I'll add that ^ follow-up to the tracker! Still won't take it off HOLD till the PR for this one gets to Production (to make sure there's no weird regressions)
changed the title [-][Image] Web - Profile - The white background in the image changes to black[/-][+][HOLD for payment 2022-12-15] [Image] Web - Profile - The white background in the image changes to black[/+]on Dec 8, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.36-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Beamanator] The PR that introduced the bug has been identified. Link to the PR: (none, this wasn't a regression)
[@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: (none, this wasn't a regression)
[@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: (none, this wasn't a regression)
[@trjExpensify / @mallenexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: Adding a profile avatar is covered already here.
Activity
melvin-bot commentedon Sep 16, 2022
Triggered auto assignment to @tgolen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.thesahindia commentedon Sep 16, 2022
It's not an issue, it happens because the background is transparent. The result will be the same if we try it on other platforms (e.g. Slack, Whatsapp)
tgolen commentedon Sep 16, 2022
Shouldn't the transparent background remain transparent though? Is this because it's being converted to a JPEG at some point (and transparency isn't supported)?
parasharrajat commentedon Sep 16, 2022
It seems like the backend is removing the transparency after processing the image.
varshamb commentedon Sep 17, 2022
Yes, while saving, image is converting jpeg and jpeg doesn't support transparency.
tgolen commentedon Sep 19, 2022
All right, sounds like this would be an internal issue for us to fix then on the server. It would be nice to support images with transparent backgrounds.
52 remaining items
Beamanator commentedon Dec 2, 2022
HECK ya we are.
And yes good idea I'll add that ^ follow-up to the tracker! Still won't take it off HOLD till the PR for this one gets to Production (to make sure there's no weird regressions)
trjExpensify commentedon Dec 2, 2022
Cool, makes sense!
[-][Image] Web - Profile - The white background in the image changes to black[/-][+][HOLD for payment 2022-12-15] [Image] Web - Profile - The white background in the image changes to black[/+]melvin-bot commentedon Dec 8, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.36-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-12-15. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Dec 8, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Santhosh-Sellavel commentedon Dec 9, 2022
Please assign me this for tracking payment thanks!
trjExpensify commentedon Dec 16, 2022
Sent you a contract, @Santhosh-Sellavel.
trjExpensify commentedon Dec 16, 2022
Cool, settled!