Skip to content

[HOLD for payment 2023-09-29] [Image] Feature Request: Introduce an ability to view workspace picture with a single tap - reported by @chauchausoup #11197

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Problem:

We cannot see a workspace avatar picture in tap and view manner. Once a user uploads a workspace avatar image then there is no way for them to view it by any means.

Solution:

As in profile picture, avatar can be viewed by tapping on it while being on chat. We should implement similar feature with workspace avatar image too. We can make view ability if a user taps in Avatar under general settings. Only if they taps in camera icon then the usual Upload / Remove option should be shown.

##Context:
https://expensify.slack.com/files/U040F2ZTA3G/F040ZBKE2CB/rpreplay_final1662273851.mp4

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1662273851.MP4

Expensify/Expensify Issue URL:
Issue reported by: @chauchausoup
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662273908091079

View all open jobs on GitHub

Activity

  1. added
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    NewFeatureSomething to build that is a new item.
    on Sep 22, 2022
  2. melvin-bot commented on Sep 22, 2022

    @melvin-bot

    Triggered auto assignment to @kadiealexander (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  3. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Sep 22, 2022
  4. Puneet-here commented on Sep 22, 2022

    @Puneet-here
    Contributor

    Proposal

    I think instead we should show an option to view the image like this
    Screenshot 2022-09-23 at 12 14 35 AM

    To implement this we have to add a new item here

    const menuItems = [
    {
    icon: Expensicons.Upload,
    text: this.props.translate('avatarWithImagePicker.uploadPhoto'),
    onSelected: () => {
    openPicker({

     if (!this.props.isUsingDefaultAvatar) {
                menuItems.unshift({
                    icon: Expensicons.Eye,
                    text: this.props.translate('avatarWithImagePicker.viewPhoto'),
                    onSelected: () => show(),
                });
            }

    If we wanna show this all the time even for default avatar then we can just add this without any condition and if we wanna keep this option at bottom then we just need to push it.

    We can reuse AttachmentModal. Wrap the Pressable below with AttachmentModal


    We have to wrap it so that we can pass so that we can pass show function in the

    menuItems={this.createMenuItems(openPicker)}

    like we pass here in the Pressable's onPress

    <AttachmentModal
    headerTitle={isSMSLogin ? this.props.toLocalPhone(details.displayName) : details.displayName}
    sourceURL={details.avatar}
    isAuthTokenRequired
    >
    {({show}) => (
    <PressableWithoutFocus
    style={styles.noOutline}
    onPress={show}

    we can also make some changes in the AttachmentModal so that it shows when we pass a prop.

    In the end we just need to pass needed props to AttachmentModal
    Questions:-

    1. What should be the headerTitle? Should we just say "Avatar"
    2. Do we need to pass isAuthTokenRequired?
    3. Should we allow downloading image?
  5. removed their assignment
    on Sep 23, 2022
  6. melvin-bot commented on Sep 23, 2022

    @melvin-bot

    Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  7. melvin-bot commented on Sep 26, 2022

    @melvin-bot

    @Gonals Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  8. added and removed on Sep 26, 2022
  9. 171 remaining items

  10. trjExpensify commented on Oct 2, 2023

    @trjExpensify
    Contributor

    Alright, seems like we're ready to make payments here! Old bounty levels of $1,000 apply on this issue because it was created prior to August 30th, but it's still a new feature request which we don't pay for reporting as bugs.

    This PR took longer than 9 days, so a 50% reduction in the bounty applies per here. That makes the payouts by my calculation:

    • @Puneet-here - $500 for the implementation
    • @rushatgabhane - $500 for the review
    • @chauchausoup - $250 for the feature request (this issue was created in Sept 22 prior to the change in policy to not pay for these in Nov 22).

    Everyone agree on that? Let me know, and I'll send @Puneet-here an offer in Upwork, and Rushat you can proceed to request.

  11. krishnemd commented on Oct 3, 2023

    @krishnemd

    @trjExpensify while I was reporting the Feature Request , it was written in FR guideline that FR is viable for a bounty.

  12. melvin-bot commented on Oct 3, 2023

    @melvin-bot

    📣 @chauchausoup! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  13. trjExpensify commented on Oct 3, 2023

    @trjExpensify
    Contributor

    Oh hm, fair enough. That policy went into place in Nov 2022 here. This issue was created in Sept 22 originally, so yes, $250 is due for the report.

    Added that to my post above and sent you an offer. Waiting for confo from @rushatgabhane on the payments above to proceed!

  14. krishnemd commented on Oct 3, 2023

    @krishnemd

    Thank you @trjExpensify .

  15. trjExpensify commented on Oct 4, 2023

    @trjExpensify
    Contributor

    @chauchausoup paid!
    @Puneet-here offer sent.
    @rushatgabhane free to proceed to request.

  16. Puneet-here commented on Oct 6, 2023

    @Puneet-here
    Contributor

    Accepted.

  17. trjExpensify commented on Oct 6, 2023

    @trjExpensify
    Contributor

    Paid!

  18. JmillsExpensify commented on Oct 7, 2023

    @JmillsExpensify
    Contributor

    $500 payment approved for @rushatgabhane based on BZ summary

  19. trjExpensify commented on Oct 9, 2023

    @trjExpensify
    Contributor

    Okay great, closing now then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions