Repository navigation
[Refactor] Able to remove PayPal account while offline, when enabled wifi - account still present #11260
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Launch the app
- Log in any account
- Go to Settings - Payments
- Add Paypal account
- Disable in internet connection
- Remove the Paypal account while offline
- Enable the internet connection
Expected Result:
Paypal account should not be visible after enable the internet connection
Actual Result:
Able to remove PayPal account while offline, when enabled wifi - account still present
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.2.6.0
Reproducible in staging?: Yes
Reproducible in production?: n/a
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen_Recording_20220923-222858_New.Expensify.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Activity
melvin-bot commentedon Sep 24, 2022
Triggered auto assignment to @Justicea83 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Justicea83 commentedon Sep 26, 2022
I can't reproduce this, but it can be external
melvin-bot commentedon Sep 26, 2022
Triggered auto assignment to @laurenreidexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 26, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)melvin-bot commentedon Sep 26, 2022
Triggered auto assignment to @mountiny (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.[-]Android - Able to remove PayPal account while offline, when enabled wifi - account still present[/-][+][$250] Android - Able to remove PayPal account while offline, when enabled wifi - account still present[/+][-][$250] Android - Able to remove PayPal account while offline, when enabled wifi - account still present[/-][+][Refactor] Able to remove PayPal account while offline, when enabled wifi - account still present[/+]mountiny commentedon Sep 26, 2022
I can reproduce this and I think this must be Internal issue. We had refactored the Delete paypal.me address in this PR (cc @danieldoglas) but we need to make sure to check the Web part of API and see what is done there to make sure client is updated correctly (and the paypal.me address does not appear after being deleted.
mountiny commentedon Sep 26, 2022
Asked in Slack for an internal employee to investigate this.
arosiclair commentedon Sep 27, 2022
I can confirm this is an issue with API reads being executed before offline writes on reconnect. We're running
ReconnectAppandOpenPaymentsPagebeforeDeletePayPalMeAddresswhich causes the deleted paypal to be re-added before it is eventually removed again.Closing this in favor of https://github.com/Expensify/Expensify/issues/229696 which should fix the issue