Skip to content

[HOLD for payment 2022-12-15] [$500] Connect manually step show up when going back from the middle of the flow - reported by @Puneet-here #11317

Closed

Description

@mvtglobally

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to bank account > add info > company step > personal details
  2. Dismiss the modal by pressing cross
  3. Now go to workspace > "connect bank account" > continue with the setup
  4. Now keep going back

Expected Result:

Connect manually step shouldn't be shown because we have already filled the info and we have option to start over or continue

Actual Result:

Connect manually step show up and

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.98-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2022-09-08.at.5.19.30.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @Puneet-here
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1662750200732219

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Sep 27, 2022

    @melvin-bot

    Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Sep 27, 2022
  3. removed their assignment
    on Sep 27, 2022
  4. melvin-bot commented on Sep 27, 2022

    @melvin-bot

    Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  5. alexpensify commented on Sep 27, 2022

    @alexpensify
    Contributor

    The workflow update is to show the Continue with Setup instead of showing the add manually option. Assigning to engineering for the next review.

  6. dangrous commented on Sep 28, 2022

    @dangrous
    Contributor

    Yep, this is pretty easily reproducible. i THINK this should be fully front end so I'm going to make it external; weekly because it's not a huge deal.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Sep 28, 2022
  8. 52 remaining items

  9. AndrewGable commented on Dec 1, 2022

    @AndrewGable
    Contributor

    Merged 👍

  10. allroundexperts commented on Dec 1, 2022

    @allroundexperts
    Contributor

    Awesome. Merged within 3 days. @adelekennedy is this eligible for the bonus?

  11. adelekennedy commented on Dec 1, 2022

    @adelekennedy
    Contributor

    Ah - I think the job expired (Upwork is the worst with that) @allroundexperts @rushatgabhane I just hired you for C/C+ @Puneet-here just hired for the reporting bonus!

    @allroundexperts You are eligible for the bonus! I'll add that on!

  12. adelekennedy commented on Dec 3, 2022

    @adelekennedy
    Contributor

    Note when paying out - 50% bonus

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 5, 2022
  14. changed the title [-][$500] Connect manually step show up when going back from the middle of the flow - reported by @Puneet-here[/-] [+][HOLD for payment 2022-12-15] [$500] Connect manually step show up when going back from the middle of the flow - reported by @Puneet-here[/+] on Dec 8, 2022
  15. melvin-bot commented on Dec 8, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.36-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-12-15. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  16. adelekennedy commented on Dec 16, 2022

    @adelekennedy
    Contributor

    Paid out with 50% bonus!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions