Skip to content

[Hold for Payment 30-11-22][$500] Close account - Refactor to use Form component #11341

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


New problem:

New plan = refactor Close Account page to use the Form component. When testing, make sure everything on that page looks good (success, errors, offline behavior, etc)

Old problem: The close account button is active in offline mode

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with any account
  3. Disable the internet connection in the device
  4. Go to Settings > Security > Close Account
  5. Copy email address from "Default contact method"
  6. Insert into "Enter your default contact method"
  7. Leave the top field blank "Enter message here"

Expected Result:

The close account button is not active in offline mode

Actual Result:

The close account button is active in offline mode

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.7.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5751243_Bandicam_2022-09-27_17-14-19-339.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause- Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Sep 27, 2022

    @melvin-bot

    Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. Beamanator commented on Sep 28, 2022

    @Beamanator
    Contributor

    Nice, good call - the Close Account button should be disabled while offline, as this flow is Pattern C (Blocking Form)

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Sep 28, 2022
  4. melvin-bot commented on Sep 28, 2022

    @melvin-bot

    Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  5. melvin-bot commented on Sep 28, 2022

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Sep 28, 2022
  7. melvin-bot commented on Sep 28, 2022

    @melvin-bot

    Current assignee @Beamanator is eligible for the External assigner, not assigning anyone new.

  8. changed the title [-]Web -Close account -The close account button is active in offline mode[/-] [+][$250] Web -Close account -The close account button is active in offline mode[/+] on Sep 28, 2022
  9. changed the title [-][$250] Web -Close account -The close account button is active in offline mode[/-] [+][$250] Close account -The close account button is active in offline mode[/+] on Sep 28, 2022
  10. Beamanator commented on Sep 28, 2022

    @Beamanator
    Contributor

    Removing "Web" from the title since this probably affects all platforms?

  11. 80 remaining items

  12. Beamanator commented on Nov 22, 2022

    @Beamanator
    Contributor

    That's fair to me! cc @laurenreidexpensify so you see this 👍

  13. changed the title [-][$250] Close account - Refactor to use Form component[/-] [+][$500] Close account - Refactor to use Form component[/+] on Nov 23, 2022
  14. laurenreidexpensify commented on Nov 23, 2022

    @laurenreidexpensify
    Contributor

    Sounds good, I'll make sure the final payment issued is $500, pls ignore the current price in Upwork

  15. Beamanator commented on Nov 24, 2022

    @Beamanator
    Contributor

    PR was deployed to production 10 hrs ago - was the title supposed to change? Or does that happen later?

  16. laurenreidexpensify commented on Nov 25, 2022

    @laurenreidexpensify
    Contributor

    @Beamanator it should have changed automagically.... 🤔

  17. changed the title [-][$500] Close account - Refactor to use Form component[/-] [+][Hold for Payment 30-11-22][$500] Close account - Refactor to use Form component[/+] on Nov 25, 2022
  18. Beamanator commented on Nov 25, 2022

    @Beamanator
    Contributor

    Thought soooo 🤷 Thanks for updating!

  19. laurenreidexpensify commented on Nov 28, 2022

    @laurenreidexpensify
    Contributor

    @Beamanator just so I follow, both @thesahindia and @Puneet-here are due $500 payment for this on 30 Nov right?

    I've sort of lost the plot a bit here for whether we need these next steps and who is responsible for first 2, as this issue changed a few times! Can you loop me on :)

    • The PR that introduced the bug has been identified. Link to the PR: (this wasn't a regression)
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. (this wasn't a regression)
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: (this wasn't a regression)
    • [@laurenreidexpensify] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/245103 (this wasn't a regression)
    • [@laurenreidexpensify] Applicable payments have been made. This potentially includes the issue reporter, the contributor that fixed the issue, and/or the contributor+ that helped on the issue.
  20. laurenreidexpensify commented on Nov 28, 2022

    @laurenreidexpensify
    Contributor
  21. cryptosmiler commented on Nov 28, 2022

    @cryptosmiler

    @Puneet-here, can you check if it works fine after the refactor and share some code here. Screen recording will be great.
    Sounds good, I'll make sure the final payment issued is $600, pls ignore the current price in Upwork

  22. Beamanator commented on Nov 29, 2022

    @Beamanator
    Contributor

    @laurenreidexpensify ok I crossed out the first 4 points, since this issue wasn't a regression from any PR, it was actually part of the Form Refactor project - so I don't think those first 4 points apply anymore.

    As for payment - $500 for each looks to be correct 👍

    @whroyal I'm not sure what you're talking about the code is already in production so you can test on a live device if you'd like, the code is linked in the PR (you can find it above). Also I don't think you're due any payment for this job.

  23. laurenreidexpensify commented on Dec 1, 2022

    @laurenreidexpensify
    Contributor

    Sorry the automation not working meant I missed this yesterday. Paid 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DesignEngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions