You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Hold for Payment 30-11-22][$500] Close account - Refactor to use Form component #11341
New plan = refactor Close Account page to use the Form component. When testing, make sure everything on that page looks good (success, errors, offline behavior, etc)
Old problem: The close account button is active in offline mode
changed the title [-]Web -Close account -The close account button is active in offline mode[/-][+][$250] Web -Close account -The close account button is active in offline mode[/+]on Sep 28, 2022
changed the title [-][$250] Web -Close account -The close account button is active in offline mode[/-][+][$250] Close account -The close account button is active in offline mode[/+]on Sep 28, 2022
changed the title [-][$250] Close account - Refactor to use Form component[/-][+][$500] Close account - Refactor to use Form component[/+]on Nov 23, 2022
changed the title [-][$500] Close account - Refactor to use Form component[/-][+][Hold for Payment 30-11-22][$500] Close account - Refactor to use Form component[/+]on Nov 25, 2022
I've sort of lost the plot a bit here for whether we need these next steps and who is responsible for first 2, as this issue changed a few times! Can you loop me on :)
The PR that introduced the bug has been identified. Link to the PR: (this wasn't a regression)
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. (this wasn't a regression)
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: (this wasn't a regression)
[@laurenreidexpensify] Applicable payments have been made. This potentially includes the issue reporter, the contributor that fixed the issue, and/or the contributor+ that helped on the issue.
@Puneet-here, can you check if it works fine after the refactor and share some code here. Screen recording will be great.
Sounds good, I'll make sure the final payment issued is $600, pls ignore the current price in Upwork
@laurenreidexpensify ok I crossed out the first 4 points, since this issue wasn't a regression from any PR, it was actually part of the Form Refactor project - so I don't think those first 4 points apply anymore.
As for payment - $500 for each looks to be correct 👍
@whroyal I'm not sure what you're talking about the code is already in production so you can test on a live device if you'd like, the code is linked in the PR (you can find it above). Also I don't think you're due any payment for this job.
Activity
melvin-bot commentedon Sep 27, 2022
Triggered auto assignment to @Beamanator (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Beamanator commentedon Sep 28, 2022
Nice, good call - the
Close Accountbutton should be disabled while offline, as this flow is Pattern C (Blocking Form)melvin-bot commentedon Sep 28, 2022
Triggered auto assignment to @laurenreidexpensify (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 28, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (
External)melvin-bot commentedon Sep 28, 2022
Current assignee @Beamanator is eligible for the External assigner, not assigning anyone new.
[-]Web -Close account -The close account button is active in offline mode[/-][+][$250] Web -Close account -The close account button is active in offline mode[/+][-][$250] Web -Close account -The close account button is active in offline mode[/-][+][$250] Close account -The close account button is active in offline mode[/+]Beamanator commentedon Sep 28, 2022
Removing "Web" from the title since this probably affects all platforms?
80 remaining items
Beamanator commentedon Nov 22, 2022
That's fair to me! cc @laurenreidexpensify so you see this 👍
[-][$250] Close account - Refactor to use Form component[/-][+][$500] Close account - Refactor to use Form component[/+]laurenreidexpensify commentedon Nov 23, 2022
Sounds good, I'll make sure the final payment issued is $500, pls ignore the current price in Upwork
Beamanator commentedon Nov 24, 2022
PR was deployed to production 10 hrs ago - was the title supposed to change? Or does that happen later?
laurenreidexpensify commentedon Nov 25, 2022
@Beamanator it should have changed automagically.... 🤔
[-][$500] Close account - Refactor to use Form component[/-][+][Hold for Payment 30-11-22][$500] Close account - Refactor to use Form component[/+]Beamanator commentedon Nov 25, 2022
Thought soooo 🤷 Thanks for updating!
laurenreidexpensify commentedon Nov 28, 2022
@Beamanator just so I follow, both @thesahindia and @Puneet-here are due $500 payment for this on 30 Nov right?
I've sort of lost the plot a bit here for whether we need these next steps and who is responsible for first 2, as this issue changed a few times! Can you loop me on :)
The PR that introduced the bug has been identified. Link to the PR:(this wasn't a regression)The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.(this wasn't a regression)A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:(this wasn't a regression)A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/245103(this wasn't a regression)laurenreidexpensify commentedon Nov 28, 2022
New job on Upwork here https://www.upwork.com/jobs/~01340bc7f6c1a9b82c
cryptosmiler commentedon Nov 28, 2022
@Puneet-here, can you check if it works fine after the refactor and share some code here. Screen recording will be great.
Sounds good, I'll make sure the final payment issued is $600, pls ignore the current price in Upwork
Beamanator commentedon Nov 29, 2022
@laurenreidexpensify ok I crossed out the first 4 points, since this issue wasn't a regression from any PR, it was actually part of the Form Refactor project - so I don't think those first 4 points apply anymore.
As for payment - $500 for each looks to be correct 👍
@whroyal I'm not sure what you're talking about the code is already in production so you can test on a live device if you'd like, the code is linked in the PR (you can find it above). Also I don't think you're due any payment for this job.
laurenreidexpensify commentedon Dec 1, 2022
Sorry the automation not working meant I missed this yesterday. Paid 👍