Skip to content

[HOLD on #8503] : Reintroduce shouldFocusOnSelectRow in OptionsSelector after Fabric is enabled #11679

Closed

Description

@rushatgabhane

Context

shouldFocusOnSelectRow was temporarily removed from OptionsSelector in #11673 because migrating from setNativeProps to state led to regeressions.

This is a tracking issue to reintroduce shouldFocusOnSelectRow after Fabric has been enabled (as discussed here).

Steps to reintroduce shouldFocusOnSelectRow

  1. Revert OptionsSelector - remove setNativeProps #11673
  2. Make sure to remove findNodeHandle like in Remove unnecessary findNodeHandle #11657
  3. Apply OptionsSelector - Migrate setNativeProps to state #11036

Activity

  1. melvin-bot commented on Oct 7, 2022

    @melvin-bot

    Triggered auto assignment to @jliexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

  2. removed
    AutoAssignerTriageAuto assign issues for triage to an available triage team member
    on Oct 7, 2022
  3. rushatgabhane commented on Oct 7, 2022

    @rushatgabhane
    MemberAuthor

    @jliexpensify feel free to unassign, and sorry for the ping (i can't change labels).

  4. rushatgabhane commented on Oct 7, 2022

    @rushatgabhane
    MemberAuthor

    Holding on #8503

  5. removed their assignment
    on Oct 9, 2022
  6. jliexpensify commented on Oct 9, 2022

    @jliexpensify
    Contributor

    @rushatgabhane do you want me to assign this to you?

  7. rushatgabhane commented on Oct 9, 2022

    @rushatgabhane
    MemberAuthor
  8. rushatgabhane commented on Oct 9, 2022

    @rushatgabhane
    MemberAuthor

    could you please also make this a monthly? @jliexpensify

  9. hannojg commented on Oct 10, 2022

    @hannojg
    Contributor

    Important to mention: I think the function can already be added back today, as for none fabric and fabric the TextInput component has an undocumented function called setSelection.
    See this comment for more details: #11053 (comment)

  10. rushatgabhane commented on Oct 17, 2022

    @rushatgabhane
    MemberAuthor

    Because of @ hannojg's suggestion, this issue isn't needed anymore.
    Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions