Skip to content

Get rid of deprecated set-output commands in GitHub Actions #11877

Closed

Description

@roryabraham

Problem

GitHub deprecated the set-output command in workflows, and they will "soon be disabled".

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
https://github.com/Expensify/App/actions/runs/3252739822/jobs/5339300870

Why is this important?

These were deprecated for security reasons, and if we don't update our workflows then they will stop working soon.

Solution

Update to using the new environment files.

Activity

  1. self-assigned this
    on Oct 15, 2022
  2. roryabraham commented on Oct 18, 2022

    @roryabraham
    ContributorAuthor

    Got a PR up for most of our usages of set-output, but not necessarily all the usages in the community actions we're using.

  3. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2022
  4. melvin-bot commented on Oct 25, 2022

    @melvin-bot

    @roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  5. roryabraham commented on Nov 2, 2022

    @roryabraham
    ContributorAuthor

    Reopening to continue migrating community actions.

  6. 10 remaining items

  7. miljakljajic commented on Nov 4, 2022

    @miljakljajic
    Contributor

    What action should I take here, sorry?

  8. roryabraham commented on Nov 9, 2022

    @roryabraham
    ContributorAuthor

    This is not a bug, going to remove you and the bug label

  9. removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 9, 2022
  10. roryabraham commented on Nov 15, 2022

    @roryabraham
    ContributorAuthor

    tspascoal/get-user-teams-membership is an outdated action I need to migrate. Probably will just replace it with the GH cli

  11. roryabraham commented on Nov 28, 2022

    @roryabraham
    ContributorAuthor

    Anyone can continue working on this, but I'm not going to prioritize it right now. Adding it to the tracking issue and dropping it for now.

  12. removed their assignment
    on Nov 28, 2022
  13. self-assigned this
    on May 31, 2023
  14. fukawi2 commented on Jun 1, 2023

    @fukawi2
    Contributor

    Looks like this has all been done now:

    phs ~/Expensidev [main !?] $ grep -RH ::set-output */.github
    phs ~/Expensidev [main !?] $
    
  15. fukawi2 commented on Jun 1, 2023

    @fukawi2
    Contributor

    Reassigning to @roryabraham since he did most of the work by the look of it, so credit due.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

EngineeringInternalRequires API changes or must be handled by Expensify staffTaskWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions