Skip to content

[HOLD for payment 2022-10-31] Software keyboard hides when you scroll the chat #11915

Closed

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open a chat
  2. Click on the compose input to open the keyboard
  3. Scroll the chat

Expected Result:

The keyboard should stay open.

Actual Result:

The keyboard closes.

Workaround:

None, this is a pain point for users and a critical regression.

Platform:

Where is this issue occurring?

  • iOS
  • Android
  • Mobile Web

Version Number: 1.2.16-4
Reproducible in staging?: yes
Reproducible in production?: yes
Email or phone of affected tester (no customers): n/a
Issue reported by: (I don't know their GH name)
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1665991322162069

View all open jobs on GitHub

Activity

  1. self-assigned this
    on Oct 17, 2022
  2. parasharrajat commented on Oct 17, 2022

    @parasharrajat
    Member

    Previously, we added this so that the user is able to see the whole list instead of a few items.

    So the thought was that if a user is trying to scroll the list, the user probably wants to see the items below the keyboard. This kind of helped on small screens.

  3. roryabraham commented on Oct 17, 2022

    @roryabraham
    ContributorAuthor

    Working on this ... currently blocked by infra process here. Once that's done hopefully we can push this forward quickly

  4. roryabraham commented on Oct 17, 2022

    @roryabraham
    ContributorAuthor
  5. roryabraham commented on Oct 17, 2022

    @roryabraham
    ContributorAuthor

    WIP PR: #11944

  6. roryabraham commented on Oct 18, 2022

    @roryabraham
    ContributorAuthor

    PR ready for review. I'm choosing not to CP it so that it gets to undergo a full regression suite.

  7. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2022
  8. added and removed on Oct 24, 2022
  9. changed the title [-]Software keyboard hides when you scroll the chat[/-] [+][HOLD for payment 2022-10-31] Software keyboard hides when you scroll the chat[/+] on Oct 24, 2022
  10. 6 remaining items

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 24, 2022
  12. mountiny commented on Oct 24, 2022

    @mountiny
    Contributor

    Assigning @dylanexpensify who kindly agreed to help out with paying out this bonus to @aimane-chnaif in weeks time

  13. aimane-chnaif commented on Oct 24, 2022

    @aimane-chnaif
    Contributor
  14. dylanexpensify commented on Oct 31, 2022

    @dylanexpensify
    Contributor

    @aimane-chnaif here's the job post for you to apply!

  15. aimane-chnaif commented on Oct 31, 2022

    @aimane-chnaif
    Contributor
  16. dylanexpensify commented on Oct 31, 2022

    @dylanexpensify
    Contributor

    Offer sent @aimane-chnaif !

  17. dylanexpensify commented on Oct 31, 2022

    @dylanexpensify
    Contributor

    Payment sent, contract ended, posting closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringImprovementItem broken or needs improvement.ReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions