Skip to content

IOUBadge displayed with 0.00 total for any chat with an associated iouReport that has a total of 0 #12115

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in with any account
  3. Refresh the page
  4. Cancelled all unpaid money requests
  5. Refresh the page

Expected Result:

LHN now shows many red and green bars next to new chats at top for amounts owed to me and others

Actual Result:

IOU icons should not be displayed for canceled money requests

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web

Version Number: 1.2.19.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2546.mp4

2510

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Oct 25, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Oct 25, 2022

    @melvin-bot

    Triggered auto assignment to @Gonals (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. mountiny commented on Oct 25, 2022

    @mountiny
    Contributor

    Trying to get this auth PR merged to fix this hopefully https://github.com/Expensify/Auth/pull/7095

  4. Julesssss commented on Oct 25, 2022

    @Julesssss
    Contributor

    This is an internal issue.

    Thankfully I have a PR in review which was improving this logic, and will resolve the issue. Preventing the need for a revert.

  5. changed the title [-]Web/mWeb - LHN shows many red and green bars next to new chats at top for amounts owed to me and others[/-] [+]IOUBadge displayed with 0.00 total for any chat with an associated iouReport that has a total of 0[/+] on Oct 25, 2022
  6. Julesssss commented on Oct 25, 2022

    @Julesssss
    Contributor

    Until the last Web-E deploy, this issue existed on staging. A fix for that issue uncovered this bug.

    The problem is that getActiveIOUReport retrieves IOUReports with a total of 0. This occurs when an iouReport is opened, but then all ious are rejected or canceled. This Auth PR introduces a change where the iouReportID is only returned from GetChats if the iouReport has a non-zero total. We then set the iouReportID as a param on the chatReport.

    In addition, this Web-E PR will complete the fix, by linking and returning iouReports in our API commands ONLY if the iouReportID is included.

  7. mountiny commented on Oct 25, 2022

    @mountiny
    Contributor
  8. Julesssss commented on Oct 25, 2022

    @Julesssss
    Contributor

    Auth PR has been approved, now we're just awaiting @cead22's review as he previously added some comments which were resolved.

  9. Julesssss commented on Oct 26, 2022

    @Julesssss
    Contributor

    This was merged, but awaiting Auth deployment. Adding a note to the deploy checklist that it should be unblocked soon.

  10. Julesssss commented on Oct 26, 2022

    @Julesssss
    Contributor

    Fixed, removing this blocker from the deploy checklist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions