You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
IOUBadge displayed with 0.00 total for any chat with an associated iouReport that has a total of 0 #12115
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Web/mWeb - LHN shows many red and green bars next to new chats at top for amounts owed to me and others[/-][+]IOUBadge displayed with 0.00 total for any chat with an associated iouReport that has a total of 0[/+]on Oct 25, 2022
Until the last Web-E deploy, this issue existed on staging. A fix for that issue uncovered this bug.
The problem is that getActiveIOUReport retrieves IOUReports with a total of 0. This occurs when an iouReport is opened, but then all ious are rejected or canceled. This Auth PR introduces a change where the iouReportID is only returned from GetChats if the iouReport has a non-zero total. We then set the iouReportID as a param on the chatReport.
In addition, this Web-E PR will complete the fix, by linking and returning iouReports in our API commands ONLY if the iouReportID is included.
Activity
OSBotify commentedon Oct 25, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 25, 2022
Triggered auto assignment to @Gonals (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mountiny commentedon Oct 25, 2022
Trying to get this auth PR merged to fix this hopefully https://github.com/Expensify/Auth/pull/7095
Julesssss commentedon Oct 25, 2022
This is an internal issue.
Thankfully I have a PR in review which was improving this logic, and will resolve the issue. Preventing the need for a revert.
[-]Web/mWeb - LHN shows many red and green bars next to new chats at top for amounts owed to me and others[/-][+]IOUBadge displayed with 0.00 total for any chat with an associated iouReport that has a total of 0[/+]Julesssss commentedon Oct 25, 2022
Until the last Web-E deploy, this issue existed on staging. A fix for that issue uncovered this bug.
The problem is that
getActiveIOUReportretrieves IOUReports with a total of 0. This occurs when an iouReport is opened, but then all ious are rejected or canceled. This Auth PR introduces a change where the iouReportID is only returned from GetChats if the iouReport has a non-zero total. We then set the iouReportID as a param on the chatReport.In addition, this Web-E PR will complete the fix, by linking and returning iouReports in our API commands ONLY if the iouReportID is included.
mountiny commentedon Oct 25, 2022
Auth PR here https://github.com/Expensify/Auth/pull/7095
Julesssss commentedon Oct 25, 2022
Auth PR has been approved, now we're just awaiting @cead22's review as he previously added some comments which were resolved.
Julesssss commentedon Oct 26, 2022
This was merged, but awaiting Auth deployment. Adding a note to the deploy checklist that it should be unblocked soon.
Julesssss commentedon Oct 26, 2022
Fixed, removing this blocker from the deploy checklist.