Skip to content

[HOLD for payment 2022-11-16] [$250] Web - LHN - The modal key combination doubles when the window is resized #12116

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing PR #12071

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Login with any account
  3. Click CTRL + I
  4. Resize the window to a minimum

Expected Result:

The modal key combination should not be duplicated

Actual Result:

The modal key combination doubles when the window is resized

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.19.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image (16)
image (15)
image (14)

Recording.2553.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Oct 25, 2022

    @melvin-bot

    Triggered auto assignment to @Justicea83 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. Justicea83 commented on Oct 25, 2022

    @Justicea83

    I can reproduce this, and its can be external

  3. removed their assignment
    on Oct 25, 2022
  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 25, 2022
  5. melvin-bot commented on Oct 25, 2022

    @melvin-bot

    Triggered auto assignment to @conorpendergrast (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  6. melvin-bot commented on Oct 25, 2022

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 25, 2022
  8. melvin-bot commented on Oct 25, 2022

    @melvin-bot

    Triggered auto assignment to @luacmartins (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  9. changed the title [-]Web - LHN - The modal key combination doubles when the window is resized[/-] [+][$250] Web - LHN - The modal key combination doubles when the window is resized[/+] on Oct 25, 2022
  10. 24 remaining items

  11. 0xmiroslav commented on Nov 7, 2022

    @0xmiroslav
    Contributor

    I am heard that Carlos is OOO for 2 weeks (#10654 (comment)).
    If so, can anyone be assigned as CME for PR to be reviewed soon?
    cc: @conorpendergrast

  12. luacmartins commented on Nov 7, 2022

    @luacmartins
    Contributor

    @0xmiroslav im still around until Wednesday. Let’s try to get this merged before then!

  13. 0xmiroslav commented on Nov 7, 2022

    @0xmiroslav
    Contributor
  14. luacmartins commented on Nov 7, 2022

    @luacmartins
    Contributor

    PR merged!

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 9, 2022
  16. changed the title [-][$250] Web - LHN - The modal key combination doubles when the window is resized[/-] [+][HOLD for payment 2022-11-16] [$250] Web - LHN - The modal key combination doubles when the window is resized[/+] on Nov 9, 2022
  17. melvin-bot commented on Nov 9, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.25-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-11-16. 🎊

  18. mvtglobally commented on Nov 16, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  19. conorpendergrast commented on Nov 17, 2022

    @conorpendergrast

    Today is the day. It's time to follow these steps.

    This is the job:

    I am paying:

    Important: Payment amounts are variable, dependent on when the PR was merged. Payment timeline all based on the day the contributor has an accepted proposal and is assigned to the Github issue
    - Merged PR within 3 business days - 50% bonus
    - Merged PR within 6 business days - 0% bonus
    - Merged PR within 9 business days - 50% penalty
    - No PR within 12 business days - Contract terminated
    
    After you've reviewed the PR and issued payment, comment on the GH issue and include any bonuses or penalties and the total amount paid.
    (the above was added on 2022-11-4, post in #bug-zero if you have questions)
    

    Assignment happened on 2022-11-04, and the PR merged on 2022-11-08. With the weekend, that's within 3 business days. So, it's a 50% bonus.

    Paying $250.00 + 50% = $375 each. I'll do that tonight

  20. conorpendergrast commented on Nov 17, 2022

    @conorpendergrast

    Contributors have been paid, contracts have been ended and job post has been removed. We're all done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions