Skip to content

[HOLD for payment 2022-11-08] [$250] VBA - Error message not dismissed after selecting address from autofill option #12122

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #11611

Action Performed:

  1. Launch the app and login
  2. Select a workspace > Connect a bank account > Proceed to company info page
  3. Click save and continue without entering any info
  4. Enter company name
    5.Type an address and select from the auto fill option

Expected Result:

Validation error message dismissed for city and zip code field

Actual Result:

Validation error message not dismissed for city and zip code field

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
  • Desktop App

Version Number: 1.2.19-1
Reproducible in staging?: y
Reproducible in production?: Could not check in production
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5791732_Screen_Shot_2022-10-25_at_10 52 26_AM

Bug5791732_error_msg.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Oct 25, 2022

    @melvin-bot

    Triggered auto assignment to @arosiclair (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  2. mvtglobally commented on Oct 25, 2022

    @mvtglobally

    Added Blocker label since we are not able to verify in PROD. Pls remove if you think this is not a blocker

  3. OSBotify commented on Oct 25, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. arosiclair commented on Oct 26, 2022

    @arosiclair
    Contributor

    @kavimuru was there any issue submitting the form even with this error message problem?

  5. kavimuru commented on Oct 26, 2022

    @kavimuru
    Author

    @arosiclair We didn't have any issue in submitting the form.

  6. thesahindia commented on Oct 26, 2022

    @thesahindia
    Member

    Not a deploy blocker. It is reproducible on production. I had reported it on slack.

  7. arosiclair commented on Oct 26, 2022

    @arosiclair
    Contributor

    Reproduced on web in staging v1.2.19-2 and prod v1.2.18-10. This also seems to be purely cosmetic since you can still submit the form with the error message not dismissed so not a deploy blocker IMO. Removing deploy blocker label and marking as external.

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 26, 2022
  9. 34 remaining items

  10. thesahindia commented on Nov 8, 2022

    @thesahindia
    Member

    I'm guessing not cuz that's why this issue was worked on.

    Correct. PR for #10738 was already merged 18 days ago and didn't fix this.

  11. removed their assignment
    on Nov 9, 2022
  12. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 9, 2022
  13. melvin-bot commented on Nov 9, 2022

    @melvin-bot

    Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

  14. melvin-bot commented on Nov 9, 2022

    @melvin-bot

    Current assignee @sobitneupane is eligible for the External assigner, not assigning anyone new.

  15. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 9, 2022
  16. melvin-bot commented on Nov 9, 2022

    @melvin-bot

    Current assignee @jasperhuangg is eligible for the External assigner, not assigning anyone new.

  17. mallenexpensify commented on Nov 9, 2022

    @mallenexpensify
    Contributor

    @thesahindia and @Uros787 have been hired. Please comment once you've accepted and @kevinksullivan will pay (I'll be OOO). Thanks Kev
    https://www.upwork.com/jobs/~0169752bebd6f85148

  18. mvtglobally commented on Nov 9, 2022

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  19. thesahindia commented on Nov 9, 2022

    @thesahindia
    Member

    Accepted, thanks!

  20. Uros787 commented on Nov 9, 2022

    @Uros787
    Contributor

    Also accepted, thanks

  21. kevinksullivan commented on Nov 9, 2022

    @kevinksullivan
    Contributor

    All set! Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions