Skip to content

Split Request - User receives a long wait time with no spinner after tapping on "Split Bill" #12204

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

. Open the New expensify beta app
2. Sign into a valid user
3. Tap on "+" > Split Bill
4. Proceed with the flow until you reach the final page.
5. Tap on "Split" green button

Expected Result:

User expects the response to be immediate or for the app to display a loading spinner if there is a wait time

Actual Result:

Nothing happens at first when you tap on the button, no loading spinner is shown. After a couple of seconds the app will redirect correctly but if the user tapped on the button multiple times when "waiting" then there will be multiple "split bill" messages in the chat.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.2.20.1

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5795210_No_loading_spinner_is_shown_when_tapping_on_split_bill.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Oct 27, 2022

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Oct 27, 2022

    @melvin-bot

    Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. luacmartins commented on Oct 27, 2022

    @luacmartins
    Contributor

    CreateIOUSplit is taking ~1.5s to return and the UI sits still while we wait. I couldn't see any recent changes to CreateIOUSplit in App or Web-E. We did make changes to the Auth command that hit prod 7 days ago though, maybe that slowed things down.

    This issue should be solved with #11597, since we will start creating the reports and IOU splits optimistically and don't have to wait on the API request.

    I'm not sure that this should be a blocker

  4. luacmartins commented on Oct 27, 2022

    @luacmartins
    Contributor

    I took a look at the total time taken to process this command over the past 30 days and it seems like this is consistent with the mean times before those Auth changes went live:

    Screen Shot 2022-10-27 at 12 00 06 PM

  5. Julesssss commented on Oct 28, 2022

    @Julesssss
    Contributor

    Nice fix @luacmartins. I agree this won't be a problem for much longer 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions