You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #11784 failing with #12265. repro in PROD checking off
PR #12124 is failing due to #12249. It is PR fail, so we did not add DeployBlocker label. Pls double check
PR #12136 looks PROD QA. Are we ok to check off?
Open PRs
PR #12124 is failing due to #12249. It is PR fail, so we did not add DeployBlocker label. Pls double check
PR #12136 looks PROD QA. Are we ok to check off?
Hi @mvtglobally. I agree with #12249 being a bug, but not a deploy blocker. I've checked off #12124 as the PR test steps are passing (at least on the first use).
Switch Report is looking better in the App performance timing dashboard. Homepage initial render is worse, but we are aligned on the fact that this is due to a change in the timing logic and doesn't accurately represent a regression.
Okay, all is good except this bug which was raised against an old issue. I have asked for help with testing as I'm unable to proceed past the 2nd step.
Hi, @Expensify/applauseleads. I saw that this crash was raised, which could well be a deploy blocker. I closed the original issue because it has a different underlying issue, but it would be great if you could open a new issue if it is still occurring and please test on both staging and prod.
@chiragsalian kindly tested the issue above and wasn't able to reproduce it. @Expensify/applauseleads if you are still able to reliably reproduce this, please open a new issue and I'll investigate further:
Activity
OSBotify commentedon Oct 28, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.21-4 🚀
mountiny commentedon Oct 28, 2022
Checking #12193 off since it is also noQA
Same for #12030
mvtglobally commentedon Oct 28, 2022
Interim summary
PR #11784 failing with #12265. repro in PROD checking off
PR #12124 is failing due to #12249. It is PR fail, so we did not add DeployBlocker label. Pls double check
PR #12136 looks PROD QA. Are we ok to check off?
mvtglobally commentedon Oct 29, 2022
Regression is completed
Deploy Blocker
#12275
Open PRs
PR #12124 is failing due to #12249. It is PR fail, so we did not add DeployBlocker label. Pls double check
PR #12136 looks PROD QA. Are we ok to check off?
Julesssss commentedon Oct 31, 2022
Hi @mvtglobally. I agree with #12249 being a bug, but not a deploy blocker. I've checked off #12124 as the PR test steps are passing (at least on the first use).
Julesssss commentedon Oct 31, 2022
#12136 was checked off as it's untestable outside of prod.
Julesssss commentedon Oct 31, 2022
#12275 is now reproducable on prod, so this is not a mobile regression. Continueing to move forward once the last regression is resolved
Julesssss commentedon Oct 31, 2022
I checked off the final blocker, #12281 as it was not reproducible for me on web or iOS
Julesssss commentedon Oct 31, 2022
Switch Report is looking better in the App performance timing dashboard. Homepage initial render is worse, but we are aligned on the fact that this is due to a change in the timing logic and doesn't accurately represent a regression.
Julesssss commentedon Oct 31, 2022
The only new crashlytics issues were from the SVG library crash that was resolved in the last deploy. I cleared up the console while I was there.
Julesssss commentedon Oct 31, 2022
Okay, all is good except this bug which was raised against an old issue. I have asked for help with testing as I'm unable to proceed past the 2nd step.
Julesssss commentedon Oct 31, 2022
Hi, @Expensify/applauseleads. I saw that this crash was raised, which could well be a deploy blocker. I closed the original issue because it has a different underlying issue, but it would be great if you could open a new issue if it is still occurring and please test on both staging and prod.
Thanks!
Julesssss commentedon Oct 31, 2022
@chiragsalian kindly tested the issue above and wasn't able to reproduce it. @Expensify/applauseleads if you are still able to reliably reproduce this, please open a new issue and I'll investigate further:
Julesssss commentedon Oct 31, 2022