Skip to content

Deploy Checklist: New Expensify 2022-10-28 #12223

Closed

Activity

  1. OSBotify commented on Oct 28, 2022

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.21-4 🚀

  2. mountiny commented on Oct 28, 2022

    @mountiny
    Contributor

    Checking #12193 off since it is also noQA

    Same for #12030

  3. mvtglobally commented on Oct 28, 2022

    @mvtglobally

    Interim summary

    PR #11784 failing with #12265. repro in PROD checking off
    PR #12124 is failing due to #12249. It is PR fail, so we did not add DeployBlocker label. Pls double check
    PR #12136 looks PROD QA. Are we ok to check off?

  4. mvtglobally commented on Oct 29, 2022

    @mvtglobally

    Regression is completed

    Deploy Blocker
    #12275

    Open PRs
    PR #12124 is failing due to #12249. It is PR fail, so we did not add DeployBlocker label. Pls double check
    PR #12136 looks PROD QA. Are we ok to check off?

  5. self-assigned this
    on Oct 31, 2022
  6. Julesssss commented on Oct 31, 2022

    @Julesssss
    Contributor

    Hi @mvtglobally. I agree with #12249 being a bug, but not a deploy blocker. I've checked off #12124 as the PR test steps are passing (at least on the first use).

  7. Julesssss commented on Oct 31, 2022

    @Julesssss
    Contributor

    #12136 was checked off as it's untestable outside of prod.

  8. Julesssss commented on Oct 31, 2022

    @Julesssss
    Contributor

    #12275 is now reproducable on prod, so this is not a mobile regression. Continueing to move forward once the last regression is resolved

  9. Julesssss commented on Oct 31, 2022

    @Julesssss
    Contributor

    I checked off the final blocker, #12281 as it was not reproducible for me on web or iOS

  10. Julesssss commented on Oct 31, 2022

    @Julesssss
    Contributor

    Switch Report is looking better in the App performance timing dashboard. Homepage initial render is worse, but we are aligned on the fact that this is due to a change in the timing logic and doesn't accurately represent a regression.

  11. Julesssss commented on Oct 31, 2022

    @Julesssss
    Contributor

    The only new crashlytics issues were from the SVG library crash that was resolved in the last deploy. I cleared up the console while I was there.

  12. Julesssss commented on Oct 31, 2022

    @Julesssss
    Contributor

    Okay, all is good except this bug which was raised against an old issue. I have asked for help with testing as I'm unable to proceed past the 2nd step.

  13. Julesssss commented on Oct 31, 2022

    @Julesssss
    Contributor

    Hi, @Expensify/applauseleads. I saw that this crash was raised, which could well be a deploy blocker. I closed the original issue because it has a different underlying issue, but it would be great if you could open a new issue if it is still occurring and please test on both staging and prod.

    Thanks!

  14. Julesssss commented on Oct 31, 2022

    @Julesssss
    Contributor

    @chiragsalian kindly tested the issue above and wasn't able to reproduce it. @Expensify/applauseleads if you are still able to reliably reproduce this, please open a new issue and I'll investigate further:

    image (35)

  15. Julesssss commented on Oct 31, 2022

    @Julesssss
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions