Skip to content

[HOLD for payment 2022-11-16] [$250] URL address popup won’t show when hovered on terms/privacy links on about page reported by @huzaifa-99 #12238

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com/settings/about
  2. Hover over the ‘terms of service’ and ‘privacy policy’ links on the bottom right corner of the screen.
  3. The url address does not show up when hovered over links (it)

Expected Result:

When hovered over a link, the url address should show up

Actual Result:

The url address does not show up

Workaround:

unknown

Platform:

Where is this issue occurring?

  • Web
    -Desktop

Version Number: 1.2.21-4
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

URL.address.popup.wont.show.when.hovered.on.terms-privacy.links.on.about.page.Screen.Recording.2022-10-28.at.4.36.39.AM.mp4
Recording.800.mp4

Expensify/Expensify Issue URL:
Issue reported by: @huzaifa-99
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666914137280919

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2022
  2. melvin-bot commented on Oct 28, 2022

    @melvin-bot

    Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. huzaifa-99 commented on Oct 31, 2022

    @huzaifa-99
    Contributor

    Are external devs open to contribute? I understand the external label is not applied

  4. strepanier03 commented on Oct 31, 2022

    @strepanier03
    Contributor

    Reviewing this shortly and if the External label is put on the issue then an external dev can contribute. This was assigned after I logged off Friday so I haven't had a chance to action it yet.

  5. strepanier03 commented on Oct 31, 2022

    @strepanier03
    Contributor

    I am able to recreate this so sending to External.

    Steps to recreate:

    1. Log into staging.new.expensify.com
    2. Click on Icon > About
    3. Hover over links with mouse,
    4. Notice the links don't preview
      2022-10-31_12-52-27 (1)
  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 31, 2022
  7. melvin-bot commented on Oct 31, 2022

    @melvin-bot

    Current assignee @strepanier03 is eligible for the External assigner, not assigning anyone new.

  8. melvin-bot commented on Oct 31, 2022

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 31, 2022
  10. 43 remaining items

  11. parasharrajat commented on Nov 10, 2022

    @parasharrajat
    Member

    Again, this is not a bug or regression but a new feature. This never existed in th app.

    We should make clear distinction between regressions and new features. If you are not sure please reach out to the public channel or ask the author whom you think added this.

  12. eVoloshchak commented on Nov 10, 2022

    @eVoloshchak
    Contributor

    We should make clear distinction between regressions and new features. If you are not sure please reach out to the public channel or ask the author whom you think added this.

    Will do, thank you

  13. strepanier03 commented on Nov 11, 2022

    @strepanier03
    Contributor

    I am out of the office tomorrow. If there is an urgent need on this GH from a BugZero team member, please post in #expensify-open-source for assistance.

  14. strepanier03 commented on Nov 11, 2022

    @strepanier03
    Contributor

    Oops, didn't mean to close that, sorry!

  15. strepanier03 commented on Nov 14, 2022

    @strepanier03
    Contributor

    Will check back in on the 16th to issue payment.

    @0xmiroslav - Please apply for the job here @0xmiroslav and I'll let me know here or in Slack once you do. Cheers!

  16. 0xmiroslav commented on Nov 15, 2022

    @0xmiroslav
    Contributor

    @strepanier03 applied. thanks

    Payment timeline all based on the day the contributor has an accepted proposal and is assigned to the Github issue
    Merged PR within 3 business days - 50% bonus

    Am I eligible for bonus? PR was merged within 3 business days.

  17. strepanier03 commented on Nov 17, 2022

    @strepanier03
    Contributor

    Thank you @0xmiroslav - I'm going to confirm that, since I know it was only recently started and it'll be my first time with the bonus being applicable. I'll follow up here shortly.

  18. strepanier03 commented on Nov 17, 2022

    @strepanier03
    Contributor

    @0xmiroslav -- After reviewing the announcement here which took place on November 5, it says the new bonus structure applied to new (from Nov 5) PRs only.

    The PR you submitted is dated November 3, so a couple of days before the new process started.

    I won't be able to grant the bonus this time, I am sorry about that, but any PR created from November 5 onward will be eligible.

    I have accepted your offer on Upwork but I think there's something you need to accept so I can pay you out.

  19. strepanier03 commented on Nov 17, 2022

    @strepanier03
    Contributor

    I'll check in tomorrow morning when I log back on to see if you've accepted and I have the option to pay you. Thanks!

  20. strepanier03 commented on Nov 18, 2022

    @strepanier03
    Contributor

    Fantastic, this is all paid out and we're ready to close it down.

    Thank you @0xmiroslav, @eVoloshchak, @huzaifa-99, and @Beamanator for working on this one and getting it done. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions