You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Failed workflow comments in slack do not have the correct URL #12392
@roryabraham , we're wanting BZ assigned for internal bugs and for them to remain daily, does the OP have everything needed to be worked on? Also.. I'm double checking here on the exact process here for engineers and bug issues
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-]Failed workflow comments in slack do not have the correct URL[/-][+][HOLD for payment 2022-12-08] Failed workflow comments in slack do not have the correct URL[/+]on Dec 1, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@roryabraham] The PR that introduced the bug has been identified. Link to the PR: n/a this was an improvement over functionality that has been there since the very early days of NewDot, back when it was still called Expensify/ReactNativeChat (even before it was temporarily called Expensify.cash)
[@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
[@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
[@conorpendergrast] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: n/a
changed the title [-][HOLD for payment 2022-12-08] Failed workflow comments in slack do not have the correct URL[/-][+]Failed workflow comments in slack do not have the correct URL[/+]on Dec 1, 2022
Activity
melvin-bot commentedon Nov 2, 2022
Triggered auto assignment to @conorpendergrast (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.roryabraham commentedon Nov 2, 2022
Since this is internal, I'm going to remove @conorpendergrast as an assignee.
roryabraham commentedon Nov 4, 2022
Screw you melvin, this should be a weekly, at best.
mallenexpensify commentedon Nov 5, 2022
@roryabraham , we're wanting BZ assigned for internal bugs and for them to remain daily, does the OP have everything needed to be worked on? Also.. I'm double checking here on the exact process here for engineers and bug issues
17 remaining items
roryabraham commentedon Nov 28, 2022
My upstream fix was merged over the weekend. I'll keep this open for now to switch from the workaround to the upstream fix.
roryabraham commentedon Nov 29, 2022
Final cleanup PR ready for review: #13121
melvin-bot commentedon Dec 1, 2022
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2022-12-08. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
[-]Failed workflow comments in slack do not have the correct URL[/-][+][HOLD for payment 2022-12-08] Failed workflow comments in slack do not have the correct URL[/+]melvin-bot commentedon Dec 1, 2022
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
roryabraham commentedon Dec 1, 2022
This was all internal, no C+ review. So no payment due
[-][HOLD for payment 2022-12-08] Failed workflow comments in slack do not have the correct URL[/-][+]Failed workflow comments in slack do not have the correct URL[/+]