Skip to content

Failed workflow comments in slack do not have the correct URL #12392

Closed

Description

@roryabraham

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Have a failed GitHub Actions workflow ping in Slack.
  2. Click on the link to the failed workflow.

Expected Result:

You should be taken to the failed workflow.

Actual Result:

You are taken to the GitHub Actions dashboard and have to look for the failed workflow manually.

Workaround:

n/a

Platform:

GitHub Actions

View all open jobs on GitHub

Activity

  1. added
    InternalRequires API changes or must be handled by Expensify staff
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 2, 2022
  2. self-assigned this
    on Nov 2, 2022
  3. melvin-bot commented on Nov 2, 2022

    @melvin-bot

    Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. roryabraham commented on Nov 2, 2022

    @roryabraham
    ContributorAuthor

    Since this is internal, I'm going to remove @conorpendergrast as an assignee.

  5. roryabraham commented on Nov 4, 2022

    @roryabraham
    ContributorAuthor

    Screw you melvin, this should be a weekly, at best.

  6. mallenexpensify commented on Nov 5, 2022

    @mallenexpensify
    Contributor

    @roryabraham , we're wanting BZ assigned for internal bugs and for them to remain daily, does the OP have everything needed to be worked on? Also.. I'm double checking here on the exact process here for engineers and bug issues

  7. 17 remaining items

  8. roryabraham commented on Nov 28, 2022

    @roryabraham
    ContributorAuthor

    My upstream fix was merged over the weekend. I'll keep this open for now to switch from the workaround to the upstream fix.

  9. roryabraham commented on Nov 29, 2022

    @roryabraham
    ContributorAuthor

    Final cleanup PR ready for review: #13121

  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Dec 1, 2022
  11. melvin-bot commented on Dec 1, 2022

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.34-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2022-12-08. 🎊

    After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. changed the title [-]Failed workflow comments in slack do not have the correct URL[/-] [+][HOLD for payment 2022-12-08] Failed workflow comments in slack do not have the correct URL[/+] on Dec 1, 2022
  13. melvin-bot commented on Dec 1, 2022

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@roryabraham] The PR that introduced the bug has been identified. Link to the PR: n/a this was an improvement over functionality that has been there since the very early days of NewDot, back when it was still called Expensify/ReactNativeChat (even before it was temporarily called Expensify.cash)
    • [@roryabraham] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: n/a
    • [@roryabraham] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: n/a
    • [@conorpendergrast] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: n/a
  14. roryabraham commented on Dec 1, 2022

    @roryabraham
    ContributorAuthor

    This was all internal, no C+ review. So no payment due

  15. changed the title [-][HOLD for payment 2022-12-08] Failed workflow comments in slack do not have the correct URL[/-] [+]Failed workflow comments in slack do not have the correct URL[/+] on Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions