Repository navigation
Deploy Checklist: New Expensify 2022-11-02 #12397
Description
Release Version: 1.2.23-9
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Allow uploading attachments of any file type #11313
- Hide report recipient local time if report recipient is unvalidated #11591
- Create splitBill in the client #11597
- Clarify the instructions and names of the checklists #11757
- set default value on picker when data has only 1 element #11819
- Fix: Onfido error and step back #11842
- Fix options list input unfocus #12057
- Fix: Log in - Leave the login input when the user hits back from the password page #12062
- Show errors after workspace creation failure #12117
- Add reviewer checklist to a markdown file #12148
- Send
lastModifiedwith theUpdateWorkspaceCustomUnitandUpdateWorkspaceCustomUnitRatecommands #12162 - Remove password field from personal bank account flow #12175
- Fix: Autofill address errors #12239
- Remove Coming Soon page #12248
- add Other hub and update description in hub pages #12270
- Money Request Pay Button Fix #12285
- Fix: The invalid incorporation date error message doesn't hide after the initial date selection #12288
- Update Emoji Datasource and fix uniform rendering across platforms #12293
- Fix #12244: Pay button is briefly hidden by loading spinner #12299
- fix "The number 1 in the name is lost and not displayed in another user" #12309
- [No QA] DRY up LHN for HelpDot #12310
- Fix concierge card position #12322
- minor fixes for Expensify Help #12326
- Fix - ✏️ icon is shown for archived chats #12332
- [CP Staging] Revert PR 11907 which introduced missing FAB bug #12336
- [NO-QA] Update hermes-pods manually to resolve iOS build issue #12342
- Updating the Free Plan #12347
- DRY up help site #12349
- [No QA] Remove a bunch of unused deprecated APIs #12358
- [Fix]: Black screen on window close in fullscreen mode #12368
- [NO-QA] Temporarily remove turnstyle action to test workflow #12390
- Revert "[NO-QA] Temporarily remove turnstyle action to test workflow" #12398
- [No QA] Point createNewVersion at forked version of turnstyle action #12402
- [No QA] Upgrade nick-invision/retry action #12403
- [No QA] Update umani/changed-files to patch a vulnerability #12406
- [No QA] Update turnstyle everywhere #12407
- Add errors object back to menu item, remove unused isPolicy #12460
- Revert PR11313 #12468
Internal QA:
- Fix members page spinner (and lack of icon on participant page) #12364 - @thienlnam @stitesExpensify
- Fix P2P Debit cards are being displayed twice on the Payments page #12178 - @amyevans @Justicea83
Deploy Blockers:
- Workspace - User does not see the "error message" when deleting a workspace #12452
- Log in - After pressing Go back button, the user's email remains in the log in field #12454
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.
cc @Expensify/applauseleads
Activity
roryabraham commentedon Nov 2, 2022
Please keep this checklist unlocked for now
mvtglobally commentedon Nov 3, 2022
@roryabraham keep us posted whenever we are good to start QA
Julesssss commentedon Nov 3, 2022
@mvtglobally yep, please go ahead!
OSBotify commentedon Nov 3, 2022
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.2.23-7 🚀
Julesssss commentedon Nov 3, 2022
I handled QA of #11757, checked it off.
Julesssss commentedon Nov 3, 2022
I checked off #12349 too and tested manually -- it's unrelated to the app itself.
amyevans commentedon Nov 3, 2022
Checked off #12178
roryabraham commentedon Nov 3, 2022
Sorry about the delay – I forgot to post in here again when we were good-to-go
Julesssss commentedon Nov 3, 2022
Even though testing isn't yet complete, I've checked the Firebase dash and closed both of the new issues. One was non-fatal, and the other was unreproducible and sounded suspiciously like a dev infinite recursion exception.
Julesssss commentedon Nov 3, 2022
Timing graph is nominal (excluding the broken timing metric).
16 remaining items
mvtglobally commentedon Nov 4, 2022
PR #11313 is failing #12459. Not a blocker. checking off
Julesssss commentedon Nov 4, 2022
@mvtglobally I'm reverting #11313 because there's a regression on Android.
Julesssss commentedon Nov 4, 2022
#11313 was reverted. Final step is to retest on staging once the builds complete 😫
mvtglobally commentedon Nov 4, 2022
@Julesssss What are we re-testing? Blocker or All the files?
Julesssss commentedon Nov 4, 2022
@mvtglobally there is one new issue that will be added to this checklist shorty, so just that one. The CP is in progress now and should be released soon 🤞
OSBotify commentedon Nov 4, 2022
👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version
1.2.23-9🚀Julesssss commentedon Nov 4, 2022
Switch report and reports loaded timing is looking good ✅
Julesssss commentedon Nov 4, 2022
One non-fatal issue in Firebase was closed. Not holding the release as it is not a crash.
Julesssss commentedon Nov 4, 2022
Okay, so I believe we're just waiting for the iOS build to be released and tested @mvtglobally? We're 44 minutes into the build so hopefully we should be close 🤞
OSBotify commentedon Nov 4, 2022
🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.2.23-9 has been deployed to staging 🎉
Julesssss commentedon Nov 4, 2022
Hey @Expensify/applauseleads, any luck testing the last issue on iOS?
mvtglobally commentedon Nov 4, 2022
Checking off #12468
Julesssss commentedon Nov 4, 2022
Okay that's it, thanks all.
Julesssss commentedon Nov 4, 2022