Repository navigation
[HOLD for payment 2022-11-16] [$250] Chat - App is crashed after click on expensifail account which is closed #12487
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Precondition:
Create a group conversation with account A and B ( should be expensifail account)
Close the expensifail account under domain account
- Go to staging.new.expensify.com
- Log in with account A
- Select the created conversation between account A and B from LHN
- Click on user's B avatar
Expected Result:
Details for account B should be displayed.
Actual Result:
App is crashed after click on expensifail account which is closed
Workaround:
Unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.2.24.0
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): 508-221-1196/applausetester+0709abb@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Recording.1619.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Activity
OSBotify commentedon Nov 4, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 4, 2022
Triggered auto assignment to @marcaaron (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.kbecciv commentedon Nov 4, 2022
Issue is not reproducible in production
marcaaron commentedon Nov 5, 2022
Not able to reproduce this. Please list the exact testing steps that were performed in order to trigger the bug.
kbecciv commentedon Nov 5, 2022
0xmiroslav commentedon Nov 5, 2022
Proposal
App/src/pages/DetailsPage.js
Line 89 in 0724337
Root cause:
This line was added here - #12364
and regressed by #12399
Solution:
0xmiroslav commentedon Nov 5, 2022
@marcaaron this is clearly reproducible step:
https://staging.new.expensify.com/details?login=anonymous
melvin-bot commentedon Nov 6, 2022
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
tgolen commentedon Nov 7, 2022
Ah yes, it looks like when I changed the signature of
getDisplayNameForParticipant()that I missed a spot. The proposal from @0xmiroslav looks like a good fix for it.46 remaining items
joekaufmanexpensify commentedon Nov 16, 2022
Discussing two new regression tests I think we should add here.
joekaufmanexpensify commentedon Nov 17, 2022
Regression test sent to applause to be added! Linked in BZ checklist above.
joekaufmanexpensify commentedon Nov 17, 2022
Okay, I updated the bug zero checklist above to reflect who is responsible for which tasks (as the checklist itself was just updated, before after it was posted to this issue).
@marcaaron / @parasharrajat let me know if I can help with commenting on the offending PR and beginning the discussion in Slack.
In the interim, I am going to pay everyone.
joekaufmanexpensify commentedon Nov 17, 2022
@parasharrajat Mind accepting the offer for this one so we can pay you?
marcaaron commentedon Nov 17, 2022
@joekaufmanexpensify it is done!
marcaaron commentedon Nov 17, 2022
parasharrajat commentedon Nov 17, 2022
@joekaufmanexpensify Done.
joekaufmanexpensify commentedon Nov 18, 2022
Great ty! Since this PR was merge the same day the contributor was assigned to the issue, both @parasharrajat and @0xmiroslav get a 50% bonus.
Going to issue payment of $375 to both of you now!
joekaufmanexpensify commentedon Nov 18, 2022
@parasharrajat $375 sent!
joekaufmanexpensify commentedon Nov 18, 2022
@0xmiroslav $375 sent!
joekaufmanexpensify commentedon Nov 18, 2022
Applause found this, so no reporting payment to make.
joekaufmanexpensify commentedon Nov 18, 2022
Job closed.
joekaufmanexpensify commentedon Nov 18, 2022
This is all set. Confirming whether the issue needs to remain open until applause adds regression test.
joekaufmanexpensify commentedon Nov 18, 2022
Okay, confirmed we don't need to wait for applause to actually add the regression test. Opening the issue for them is sufficient.
Closing as this is all set. Thanks everyone!