Repository navigation
[HOLD for payment 2023-02-01] [$250] There's no back button at bank offline blocking view reported by @thesahindia #12708
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Disconnect the internet connection
- Navigate to settings > Workspaces
- Select a workspace
- Click on "connect bank account"
Expected Result:
There should be a back button
Actual Result:
There's no back button
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.2.27-3
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation:
https://expensify.slack.com/archives/C049HHMV9SM/p1668369917906139
Activity
melvin-bot commentedon Nov 14, 2022
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Puneet-here commentedon Nov 14, 2022
Proposal
We need to show the back button when the user is offline we can make the changes as suggested at ReimbursementAccountLoadingIndicator
<HeaderWithCloseButton title={props.translate('reimbursementAccountLoadingAnimation.oneMoment')} onCloseButtonPress={Navigation.dismissModal} + shouldShowBackButton={props.network.isOffline} + onBackButtonPress={Navigation.goBack} /> <FullPageOfflineBlockingView> {props.isSubmittingVerificationsData ? ( @@ -49,4 +53,7 @@ const ReimbursementAccountLoadingIndicator = props => ( ReimbursementAccountLoadingIndicator.propTypes = propTypes; ReimbursementAccountLoadingIndicator.displayName = 'ReimbursementAccountLoadingIndicator'; -export default withLocalize(ReimbursementAccountLoadingIndicator); +export default compose( + withNetwork(), + withLocalize, +)(ReimbursementAccountLoadingIndicator);melvin-bot commentedon Nov 14, 2022
Looks like something related to
react-navigationmay have been mentioned in this issue discussion.As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our
DeprecatedCustomActions.jsfiles should not be accepted.Feel free to drop a note in #expensify-open-source with any questions.
melvin-bot commentedon Nov 15, 2022
Current assignee @dylanexpensify is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Nov 15, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)melvin-bot commentedon Nov 15, 2022
Triggered auto assignment to @AndrewGable (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.[-]There's no back button at bank offline blocking view reported by @thesahindia [/-][+][$250] There's no back button at bank offline blocking view reported by @thesahindia [/+]dylanexpensify commentedon Nov 15, 2022
Upwork: https://www.upwork.com/jobs/~012907523c42742c6b
44 remaining items
melvin-bot commentedon Jan 25, 2023
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 25, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.58-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-02-01. 🎊
After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Jan 25, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
dylanexpensify commentedon Feb 6, 2023
Working on this today!
dylanexpensify commentedon Feb 8, 2023
RT here
thesahindia commentedon Feb 9, 2023
@dylanexpensify, this is eligible for reporting compensation. We will need an upwork job here.
dylanexpensify commentedon Feb 13, 2023
Ah yes, will do now
dylanexpensify commentedon Feb 13, 2023
job here, also invited you!
thesahindia commentedon Feb 13, 2023
Applied, thanks!
dylanexpensify commentedon Feb 13, 2023
offer sent!
thesahindia commentedon Feb 13, 2023
@dylanexpensify, accepted!
dylanexpensify commentedon Feb 13, 2023
paid! Closing this out @nkuoch reopen if something is missing!