[HOLD for payment 2022-11-30] [$250] FaceTone selector does not highlight the current selected value on web reported by @parasharrajat

@parasharrajat

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Log in to the app on web.
Open any report.
Go to composer and click on the EmojiPicker.
Click on the face tone changer 🖐️ .
Observe that there current tone is not highlighted.

Expected Result:

Current tone is highlighted in the facetone selector on the EmojiPicker.

Actual Result:

Current tone is not highlighted in the facetone selector on the EmojiPicker on WEB. But Native app has it.

Workaround:

unknown

Platform:

Where is this issue occurring?

Web
Desktop App

Version Number: 1.2.28-2
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668624156359639

View all open jobs on GitHub

@isabelastisser

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Taking this since I'm on the tracking issue.

This is a clear issue and reproducible, so I'm going to go ahead and get the Upwork posting kicked off and open this up for external contributors.

@stitesExpensify

We're open for proposals: https://www.upwork.com/jobs/~01261110e4fdea977f.

cc @stitesExpensify for 👀 when you get back.

@JmillsExpensify

Current assignee @JmillsExpensify is eligible for the External assigner, not assigning anyone new.

@rushatgabhane

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@francoisl

Triggered auto assignment to @francoisl (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@francoisl

Nice work here. Based on what I'm seeing, the linked PR is eligible for the 50% bonus since it was merged within 3 business days. Is that right @francoisl? If so, I'll issue the bonus as part of final payment when this PR is successfully deployed and the regression period passes.

Yes I think you're correct, it's eligible for the bonus!

Thanks :)

Following up on this issue, it looks like our automated Github bot is broken as the linked PR hit production 3 days ago. Accordingly, I'm going to update the title to reflect that payment should be issued on 11-30-22.

@JmillsExpensify

Following up on this issue, it looks like our automated Github bot is broken as the linked PR hit production 3 days ago.
Accordingly, I'm going to update the title to reflect that payment should be issued on 11-30-22.

@JmillsExpensify Can I expect this today?

Yep you sure can. It's on my list.

Yep you sure can. It's on my list.

Great, Thanks. :)

@Pujan92

Ok I'm circling back to close this out today. Here's where we landed:

✅ Contributor: @Pujan92 $500 (includes the 50% bonus)
✅ Contributor+: @rushatgabhane $500 (includes the 50% bonus)
Issue reporter: @parasharrajat $250 (offer sent)

I'll keep this issue open until @parasharrajat accepts for the bug report. Then we should be good here. Thanks all!

@Pujan92

Also whoops, my mistake. The correct amounts should be:

✅ Contributor: @Pujan92 $375 (includes the 50% bonus)
✅ Contributor+: @rushatgabhane $375 (includes the 50% bonus)
Issue reporter: @parasharrajat $250 (offer sent)

However the bonuses are my mistake, so I won't be asking for a refund on those. We're working on payments being automated and I can't wait!

Yes, how about adjusting it in the other task? I will remind you in the next task payment.

@JmillsExpensify

is it Friday already? 😂

@JmillsExpensify that's generous of you, but please issue a refund

Feel free to remind me in a future task. Let's focus on closing more bugs in the meantime! Everyone is paid out now. Closing.

Navigation Menu

Repository navigation

[HOLD for payment 2022-11-30] [$250] FaceTone selector does not highlight the current selected value on web reported by @parasharrajat #12804

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

14 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2022-11-30] [$250] FaceTone selector does not highlight the current selected value on web reported by @parasharrajat #12804

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

Activity

melvin-bot commented on Nov 17, 2022

JmillsExpensify commented on Nov 17, 2022

JmillsExpensify commented on Nov 17, 2022

JmillsExpensify commented on Nov 17, 2022

melvin-bot commented on Nov 17, 2022

melvin-bot commented on Nov 17, 2022

melvin-bot commented on Nov 17, 2022

14 remaining items

JmillsExpensify commented on Nov 22, 2022

francoisl commented on Nov 22, 2022

Pujan92 commented on Nov 24, 2022

JmillsExpensify commented on Nov 26, 2022

Pujan92 commented on Nov 30, 2022

JmillsExpensify commented on Nov 30, 2022

Pujan92 commented on Dec 1, 2022

JmillsExpensify commented on Dec 1, 2022

JmillsExpensify commented on Dec 1, 2022

Pujan92 commented on Dec 1, 2022

rushatgabhane commented on Dec 1, 2022

JmillsExpensify commented on Dec 1, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions