Repository navigation
Text color appears black for all the buttons in the site - Reported by dhairyasenjaliya #12822
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to URL https://staging.new.expensify.com/
- Log in with any account
- Check the display of buttons in the program
Expected Result:
The text in the buttons should be white
Actual Result:
The text in all program buttons is black
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number: 1.2.29-3
Reproducible in staging?: y
Reproducible in production?: n
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5824693_Recording__2966.mp4
Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya & Applause internal team
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1668665477914149
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0125057940417ca326
- Upwork Job ID: 1596133416959213568
Activity
melvin-bot commentedon Nov 17, 2022
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.[-]Test color appears black for all the buttons in the site[/-][+]Text color appears black for all the buttons in the site[/+]OSBotify commentedon Nov 17, 2022
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Nov 17, 2022
Triggered auto assignment to @sketchydroide (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.mountiny commentedon Nov 17, 2022
cc @grgia I think this is most likely coming from here #12478
michaelhaxhiu commentedon Nov 17, 2022
Bug reporting bonus should go to the contributor dhairyapatel143@gmail.com right?
https://expensify.slack.com/archives/C049HHMV9SM/p1668665477914149
getusha commentedon Nov 17, 2022
I think this issue is coming from this commit c935d51#diff-9702ee736b887acf4ebfb56ce7a99c64b1cae4aca7c5ac88dab41ca6ea741c60L2-R9
the white variable is given a black color. which of course might be used other places.
33 remaining items
dhairyasenjaliya commentedon Nov 25, 2022
Accept @laurenreidexpensify
neil-marcellini commentedon Nov 28, 2022
There's no help wanted here correct?
grgia commentedon Nov 28, 2022
Yep this was already fixed in this PR, I'll remove the label
sketchydroide commentedon Nov 29, 2022
@dhairyasenjaliya let us know if/when everything is done so we can close this :)
dhairyasenjaliya commentedon Nov 29, 2022
@sketchydroide waiting for @laurenreidexpensify to close the upwork contract so that we can close this one :)
sketchydroide commentedon Nov 30, 2022
@laurenreidexpensify not sure if this is something you can do now, or we are waiting for something :)
sketchydroide commentedon Dec 2, 2022
still waiting, hopefully this will be closed soon
laurenreidexpensify commentedon Dec 2, 2022
Hey folks 👋 @greg-schroeder is the assigned Bug Zero person here :) I think I stepped in to help get the contract on Upwork. I'll pay this now though as it's on my radar again
laurenreidexpensify commentedon Dec 2, 2022
Payment done 👍🏽
sketchydroide commentedon Dec 2, 2022
Thanks for the context, will ask the BZ instead next time, thanks for jumping in though :)