Repository navigation
Console error shows on login Invalid prop ....role of value user supplied to AvatarWithIndicator, expected one of [“admin”] #12920
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Launch the app
Expected Result:
Not seeing this console error
Actual Result:
Seeing the console error
Workaround:
Does not seem to affect anything
Platform:
Where is this issue occurring?
- Web
- iOS
- Android
- Desktop App
- Mobile Web
Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669099212581009
Activity
melvin-bot commentedon Nov 22, 2022
Triggered auto assignment to @davidcardoza (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.hungvu193 commentedon Nov 22, 2022
Proposal
Since we have new role "user" in
policiesobject insideAvatarWithIndicator.jsthis warning happened.Solution
To avoid this warning, we can update the
AvatarWithIndicatorPropTypes by adding new role "user" insideCONST.js.App/src/CONST.js
Lines 690 to 692 in 6fc1793
POLICY: { TYPE: { FREE: 'free', PERSONAL: 'personal', CORPORATE: 'corporate', TEAM: 'team', }, ROLE: { ADMIN: 'admin', + USER: 'user', }, ROOM_PREFIX: '#', CUSTOM_UNIT_RATE_BASE_OFFSET: 100, OWNER_EMAIL_FAKE: '_FAKE_', },flodnv commentedon Nov 22, 2022
Thanks @hungvu193 but this GH does not have the 'Help wanted' label. It was my plan to do this, but another reason I also took it is because we also need another role in there (or else we'll be fixing the same "bug" in a few months).
davidcardoza commentedon Nov 23, 2022
@flodnv This is what I see when I launch NewDot on web and open the console. Let me know if I am missing a step here, my error doesn't match with the error message in the linked Slack thread.
flodnv commentedon Nov 23, 2022
@davidcardoza this stumped me for a bit. The logged in user has to be a part of another policy as a user (not admin)
dhairyasenjaliya commentedon Nov 30, 2022
Hello @flodnv upwork job for bug reporting missing
flodnv commentedon Nov 30, 2022
Thanks for the bump, can you handle this @davidcardoza please?
davidcardoza commentedon Dec 1, 2022
Job posted - https://www.upwork.com/jobs/~01fed2b4c2608f0a4f
Waiting for proposals.
devr097 commentedon Dec 1, 2022
Hi @flodnv
I am interested in this error,
How did you get this error, web building or mobile app?
I can fix this error.
dhairyasenjaliya commentedon Dec 2, 2022
Applied @davidcardoza bug is already fixed internally just need to settle reporting bonus
flodnv commentedon Dec 2, 2022
Yes, this bug is fixed @davidcardoza .... we just need to pay @dhairyasenjaliya for reporting
davidcardoza commentedon Dec 2, 2022
Contract extend @dhairyasenjaliya please accept and I will process payment.
dhairyasenjaliya commentedon Dec 3, 2022
Accepted @davidcardoza
flodnv commentedon Dec 5, 2022
Can we close this @davidcardoza ?
davidcardoza commentedon Dec 7, 2022
Yeah, payment sent. Sorry for the delay I was OOO for a conference.
dhairyasenjaliya commentedon Dec 8, 2022
Received and also please close the upwork contract @davidcardoza