Repository navigation
[$1000] Date picker is not centered and has too small clickable area #12957
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
- Go to any view with a date picker
- Ex: Workspace -> Connect Bank Account -> Connect Manual -> Company Step -> Check Incorporation date
Expected Result:
The calendar icon should be centered vertically and clickable anywhere as we do for password hide show.
Actual Result:
Icon is not centered and has very small clickable area
Workaround:
unknown
Platform:
Where is this issue occurring?
- Web
- Desktop App
- mobile web - Pop up not aligned
Version Number: 1.2.30-0
Reproducible in staging?: y
Reproducible in production?: No credentials to check
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/203600161-5654b7fd-6682-40a9-8530-b75fe04c37e6.mov
https://user-images.githubusercontent.com/43996225/203600179-d2758ed5-df72-43c7-ac8d-acef91305879.mov
https://user-images.githubusercontent.com/43996225/203600448-461332bf-edff-4ed7-b2c6-02190895941a.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Santhosh-Sellavel
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669169036468899
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01a1478c10c7c22d0c
- Upwork Job ID: 1597292879110447104
Activity
melvin-bot commentedon Nov 23, 2022
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.dhairyasenjaliya commentedon Nov 23, 2022
Proposal
.expensify-datepicker::-webkit-calendar-picker-indicator { position: absolute; - right: 12px; - top: 13px; + right: 0px; + height: 52px; + padding: 20px; + padding-right: 12px; + margin-top: 20px; }Result
Chrome
Increased touch area
Screen.Recording.2022-11-25.at.4.06.00.PM.mov
MWeb
Desktop
Result without fix
melvin-bot commentedon Nov 23, 2022
Triggered auto assignment to @grgia (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.bfitzexpensify commentedon Nov 23, 2022
Agree this could be improved.
varshamb commentedon Nov 24, 2022
Proposal
Instead making Date Picker in centre I propose make it aligned with date input text.
for this change position to
relative.position: relative;App/src/components/DatePicker/styles.css
Lines 8 to 9 in 0274c4a
JmillsExpensify commentedon Nov 28, 2022
I think we should make this
External@bfitzexpensify. Can you apply that label so that proposals can be evaluated?melvin-bot commentedon Nov 28, 2022
Current assignee @bfitzexpensify is eligible for the External assigner, not assigning anyone new.
[-]Date picker is not centered and has too small clickable area[/-][+][$1000] Date picker is not centered and has too small clickable area[/+]52 remaining items
melvin-bot commentedon Jan 17, 2023
@sobitneupane, @shonsirsha, @grgia, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Jan 19, 2023
@sobitneupane, @shonsirsha, @grgia, @bfitzexpensify Eep! 4 days overdue now. Issues have feelings too...
sobitneupane commentedon Jan 20, 2023
This feature was added in #5509 PR. I believe this was present with the introduction of this feature.
MelvinBot commentedon Feb 6, 2023
@sobitneupane, @shonsirsha, @grgia, @bfitzexpensify 12 days overdue. Walking. Toward. The. Light...
MelvinBot commentedon Feb 6, 2023
@sobitneupane, @shonsirsha, @grgia, @bfitzexpensify 12 days overdue. Walking. Toward. The. Light...
MelvinBot commentedon Feb 6, 2023
@sobitneupane, @shonsirsha, @grgia, @bfitzexpensify 12 days overdue now... This issue's end is nigh!
MelvinBot commentedon Feb 9, 2023
This issue has not been updated in over 14 days. @sobitneupane, @shonsirsha, @grgia, @bfitzexpensify eroding to Weekly issue.
MelvinBot commentedon Mar 6, 2023
This issue has not been updated in over 15 days. @sobitneupane, @shonsirsha, @grgia, @bfitzexpensify eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
MelvinBot commentedon May 3, 2023
@sobitneupane, @shonsirsha, @grgia, @bfitzexpensify, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.