You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$2000] iOS - Profile - Bottom home bar on iOS does not have transparent background #12963
Bottom home bar should have transparent background
Actual Result:
Have white background
Workaround:
unknown
Platform:
Where is this issue occurring?
iOS
Version Number: 1.2.30-0 Reproducible in staging?: y
**Reproducible in production?:**y Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos:
This also happen in every screens that used ScreenWrapper, I tested on Setting, About... Solution
So I think the prop: includePaddingBottom should be false by default.
The bug is not a duplicate report of an existing GH (close the GH and add any novel details to the original GH instead):
The bug is reproducible, following the reproduction steps:
If you’re unable to reproduce the bug, add the Needs reproduction label. Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.:
The GH template is filled out as fully as possible -- this means the GH body and title are clear (ie. could an external contributor understand it and work on it?):
The GH was created by an Expensify employee or a QA tester:
If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it’s better to wait, close the GH & provide this justification:
If there's a link to Slack, check the discussion to see if we decided not to fix it:
Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label:
changed the title [-]iOS - Profile - Bottom home bar on iOS does not have transparent background[/-][+][$1000] iOS - Profile - Bottom home bar on iOS does not have transparent background[/+]on Nov 24, 2022
Oh, was there not any announcement about this? As far as I know, we have been encouraged to take things "internal" at our discretion to help expedite as our roadmap is blocked on these bugs and unblocking it is our highest priority atm. It does not affect compensation if you have contributed to the solution then you will get paid. So, it's less work for you and the same benefit 😄
Oh, was there not any announcement about this? As far as I know, we have been encouraged to take things "internal" at our discretion to help expedite as our roadmap is blocked on these bugs and unblocking it is our highest priority atm. It does not affect compensation if you have contributed to the solution then you will get paid. So, it's less work for you and the same benefit 😄
PR is merged and deployed to production 3 days ago. @kadiealexander should we update the label so that the bot doesn't keep sending the reminders. Also the payment date for this issue isn't updated.
Activity
melvin-bot commentedon Nov 23, 2022
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.hungvu193 commentedon Nov 24, 2022
Proposal
This come from this piece of code:
App/src/components/ScreenWrapper/BaseScreenWrapper.js
Lines 78 to 81 in 0274c4a
This also happen in every screens that used ScreenWrapper, I tested on Setting, About...
Solution
So I think the prop:
includePaddingBottomshould be false by default.const defaultProps = { style: [], - includePaddingBottom: true, + includePaddingBottom: false, includePaddingTop: true, onTransitionEnd: () => {}, modal: {}, keyboardAvoidingViewBehavior: 'padding', };kadiealexander commentedon Nov 24, 2022
From this SO: https://stackoverflow.com/c/expensify/questions/14418
melvin-bot commentedon Nov 24, 2022
Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Nov 24, 2022
Job added to Upwork: https://www.upwork.com/jobs/~01d769c08d05e2ed49
melvin-bot commentedon Nov 24, 2022
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (
External)melvin-bot commentedon Nov 24, 2022
Triggered auto assignment to @Gonals (
External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.[-]iOS - Profile - Bottom home bar on iOS does not have transparent background[/-][+][$1000] iOS - Profile - Bottom home bar on iOS does not have transparent background[/+]57 remaining items
marcaaron commentedon Dec 14, 2022
Oh, was there not any announcement about this? As far as I know, we have been encouraged to take things "internal" at our discretion to help expedite as our roadmap is blocked on these bugs and unblocking it is our highest priority atm. It does not affect compensation if you have contributed to the solution then you will get paid. So, it's less work for you and the same benefit 😄
hungvu193 commentedon Dec 15, 2022
Thank you @marcaaron
kadiealexander commentedon Dec 20, 2022
I'm going OOO for a family emergency, if this needs action while I'm away please re-add the
buglabel to assign someone.melvin-bot commentedon Dec 27, 2022
@shawnborton, @mananjadhav, @marcaaron, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Dec 29, 2022
@shawnborton, @mananjadhav, @marcaaron, @kadiealexander Eep! 4 days overdue now. Issues have feelings too...
mananjadhav commentedon Jan 2, 2023
PR is raised and I am going to review this by today-tomorrow.
melvin-bot commentedon Jan 9, 2023
@shawnborton, @mananjadhav, @marcaaron, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
mananjadhav commentedon Jan 10, 2023
PR is merged and deployed to production 3 days ago. @kadiealexander should we update the label so that the bot doesn't keep sending the reminders. Also the payment date for this issue isn't updated.
mananjadhav commentedon Jan 13, 2023
@kadiealexander This is ready for payout today. Can you please help me with the same?
kadiealexander commentedon Jan 16, 2023
Yes! The Upwork job closed, but please apply here @hungvu193 and @mananjadhav and I'll get the payment issued.
https://www.upwork.com/jobs/~0135d50f36c1f175ac
hungvu193 commentedon Jan 16, 2023
Thanks @kadiealexander, I've just applied.
kadiealexander commentedon Jan 16, 2023
Thanks @hungvu193, I've just issued that payment now :)
mananjadhav commentedon Jan 16, 2023
Applied @kadiealexander :)
kadiealexander commentedon Jan 16, 2023
Everyone is paid 🎉