Skip to content

[$2000] iOS - Profile - Bottom home bar on iOS does not have transparent background #12963

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login
  2. Go to profile page

Expected Result:

Bottom home bar should have transparent background

Actual Result:

Have white background

Workaround:

unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.2.30-0
Reproducible in staging?: y
**Reproducible in production?:**y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669215534845239

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01d769c08d05e2ed49
  • Upwork Job ID: 1595628342549524480
  • Last Price Increase: 2022-12-13

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 23, 2022
  2. melvin-bot commented on Nov 23, 2022

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. hungvu193 commented on Nov 24, 2022

    @hungvu193
    Contributor

    Proposal
    This come from this piece of code:

    // We always need the safe area padding bottom if we're showing the offline indicator since it is bottom-docked.
    if (this.props.includePaddingBottom || this.props.network.isOffline) {
    paddingStyle.paddingBottom = paddingBottom;
    }

    This also happen in every screens that used ScreenWrapper, I tested on Setting, About...
    Solution
    So I think the prop: includePaddingBottom should be false by default.

    const defaultProps = {
        style: [],
    -    includePaddingBottom: true,
    +   includePaddingBottom: false,
        includePaddingTop: true,
        onTransitionEnd: () => {},
        modal: {},
        keyboardAvoidingViewBehavior: 'padding',
    };
  4. kadiealexander commented on Nov 24, 2022

    @kadiealexander
    Contributor

    From this SO: https://stackoverflow.com/c/expensify/questions/14418

    • The "bug" is actually a bug:
    • The bug is not a duplicate report of an existing GH (close the GH and add any novel details to the original GH instead):
    • The bug is reproducible, following the reproduction steps:

    28696830-FCDC-47D8-B9A3-79F37EE3668E

    • If you’re unable to reproduce the bug, add the Needs reproduction label. Comment on the issue outlining the steps you took to try to reproduce the bug, your results and tag the issue reporter and the Applause QA member who created the issue. Ask them to clarify reproduction steps and/or to check the reproduction steps again. Close issue.:
    • The GH template is filled out as fully as possible -- this means the GH body and title are clear (ie. could an external contributor understand it and work on it?):
    • The GH was created by an Expensify employee or a QA tester:
    • If the bug is an OldDot issue, you should decide whether it is widespread enough to justify fixing or it is better to wait for reunification. If it’s better to wait, close the GH & provide this justification:
    • If there's a link to Slack, check the discussion to see if we decided not to fix it:
    • Decide if the GH should be resolved by an External contributor or Internal engineer, add the appropriate label:
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 24, 2022
  6. melvin-bot commented on Nov 24, 2022

    @melvin-bot

    Current assignee @kadiealexander is eligible for the External assigner, not assigning anyone new.

  7. melvin-bot commented on Nov 24, 2022

    @melvin-bot
  8. melvin-bot commented on Nov 24, 2022

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 24, 2022
  10. melvin-bot commented on Nov 24, 2022

    @melvin-bot

    Triggered auto assignment to @Gonals (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  11. changed the title [-]iOS - Profile - Bottom home bar on iOS does not have transparent background[/-] [+][$1000] iOS - Profile - Bottom home bar on iOS does not have transparent background[/+] on Nov 24, 2022
  12. 57 remaining items

  13. marcaaron commented on Dec 14, 2022

    @marcaaron
    Contributor

    Oh, was there not any announcement about this? As far as I know, we have been encouraged to take things "internal" at our discretion to help expedite as our roadmap is blocked on these bugs and unblocking it is our highest priority atm. It does not affect compensation if you have contributed to the solution then you will get paid. So, it's less work for you and the same benefit 😄

  14. hungvu193 commented on Dec 15, 2022

    @hungvu193
    Contributor

    Oh, was there not any announcement about this? As far as I know, we have been encouraged to take things "internal" at our discretion to help expedite as our roadmap is blocked on these bugs and unblocking it is our highest priority atm. It does not affect compensation if you have contributed to the solution then you will get paid. So, it's less work for you and the same benefit 😄

    Thank you @marcaaron

  15. kadiealexander commented on Dec 20, 2022

    @kadiealexander
    Contributor

    I'm going OOO for a family emergency, if this needs action while I'm away please re-add the bug label to assign someone.

  16. melvin-bot commented on Dec 27, 2022

    @melvin-bot

    @shawnborton, @mananjadhav, @marcaaron, @kadiealexander Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. melvin-bot commented on Dec 29, 2022

    @melvin-bot

    @shawnborton, @mananjadhav, @marcaaron, @kadiealexander Eep! 4 days overdue now. Issues have feelings too...

  18. mananjadhav commented on Jan 2, 2023

    @mananjadhav
    Collaborator

    PR is raised and I am going to review this by today-tomorrow.

  19. melvin-bot commented on Jan 9, 2023

    @melvin-bot

    @shawnborton, @mananjadhav, @marcaaron, @kadiealexander Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  20. mananjadhav commented on Jan 10, 2023

    @mananjadhav
    Collaborator

    PR is merged and deployed to production 3 days ago. @kadiealexander should we update the label so that the bot doesn't keep sending the reminders. Also the payment date for this issue isn't updated.

  21. mananjadhav commented on Jan 13, 2023

    @mananjadhav
    Collaborator

    @kadiealexander This is ready for payout today. Can you please help me with the same?

  22. kadiealexander commented on Jan 16, 2023

    @kadiealexander
    Contributor

    Yes! The Upwork job closed, but please apply here @hungvu193 and @mananjadhav and I'll get the payment issued.

    https://www.upwork.com/jobs/~0135d50f36c1f175ac

  23. hungvu193 commented on Jan 16, 2023

    @hungvu193
    Contributor

    Thanks @kadiealexander, I've just applied.

  24. kadiealexander commented on Jan 16, 2023

    @kadiealexander
    Contributor

    Thanks @hungvu193, I've just issued that payment now :)

  25. mananjadhav commented on Jan 16, 2023

    @mananjadhav
    Collaborator

    Applied @kadiealexander :)

  26. kadiealexander commented on Jan 16, 2023

    @kadiealexander
    Contributor

    Everyone is paid 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2InternalRequires API changes or must be handled by Expensify staffReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions