Skip to content

[Hold #12917] [$1000] IOU - copy to clipboard appears before closing the context menu #13004

Closed

Description

@kavimuru

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open any chat
  2. Send a request
  3. Long press on the IOU preview to bring up the context menu
  4. Tap outside of the context menu to close it

Expected Result:

The context menu closes without an additional screen displayed

Actual Result:

The copy to clipboard menu appears quickly before the context menu is closed

Workaround:

None

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.2.35-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Original report:
https://user-images.githubusercontent.com/43996225/203825089-02357973-ef8d-4bf5-b09d-2a8a77af0b46.mov

TRJ reproduction:
https://user-images.githubusercontent.com/16232057/205189920-13befcd3-cef1-4332-9492-ceb3e4a862f9.MP4

Tip: knock the playback speed down a bit to see it more clearly.

Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669224900283549

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Activity

  1. melvin-bot commented on Nov 28, 2022

    @melvin-bot

    Whoops! This issue is 2 days overdue. Let's get this updated quick!

  2. melvin-bot commented on Nov 30, 2022

    @melvin-bot

    Huh... This is 4 days overdue. Who can take care of this?

  3. self-assigned this
    on Dec 2, 2022
  4. trjExpensify commented on Dec 2, 2022

    @trjExpensify
    Contributor

    👋 Happened across this one hanging out here. I can reproduce it on a physical device (iOS 16, iPhone 13 Pro) on the latest staging app: v1.2.35-0.

    Action Performed:

    1. Open any chat
    2. Send a request
    3. Long press on the IOU preview to bring up the context menu
    4. Tap outside of the context menu to close it

    Actual Result
    The copy to clipboard menu appears quickly before the context menu is closed

    Expected Result
    The context menu closes without this added step

    RPReplay_Final1669942198.MP4

    Pro-tip: knock the playback speed down a bit to see it more clearly.

    Adding the Bug and External labels.

  5. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 2, 2022
  6. melvin-bot commented on Dec 2, 2022

    @melvin-bot

    Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Dec 2, 2022
  8. melvin-bot commented on Dec 2, 2022

    @melvin-bot

    Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

  9. changed the title [-] Report popup is blink after closing [/-] [+][$1000] Report popup is blink after closing [/+] on Dec 2, 2022
  10. 13 remaining items

  11. PauloGasparSv commented on Dec 2, 2022

    @PauloGasparSv
    Contributor

    @railway17 were you on the very latest version of main?

    Asking this because I just tested and reproduced the bug on my first try but then I pulled from main and the bug was gone. I can't reproduce this bug anymore here.

  12. railway17 commented on Dec 2, 2022

    @railway17
    Contributor

    @railway17 were you on the very latest version of main?

    Asking this because I just tested and reproduced the bug on my first try but then I pulled from main and the bug was gone. I can'r reproduce this here.

    Let me check with latest code.
    But this issue has a very clear reason, so it should appear as long as there were not any changes in hideContextMenu method.

  13. railway17 commented on Dec 2, 2022

    @railway17
    Contributor

    Ah..
    It was updated in latest main 🥲 and reportAction is updated inside runAndResetOnPopoverHide

  14. trjExpensify commented on Dec 2, 2022

    @trjExpensify
    Contributor

    Okay, niceee! I'm going to pop a hold in the title for #12917. I'll retest once it hits staging and then close it out.

  15. changed the title [-][$1000] IOU - copy to clipboard appears before closing the context menu[/-] [+][Hold #12917] [$1000] IOU - copy to clipboard appears before closing the context menu[/+] on Dec 2, 2022
  16. PauloGasparSv commented on Dec 5, 2022

    @PauloGasparSv
    Contributor

    Not overdue, #12917 was deployed to staging

  17. melvin-bot commented on Dec 8, 2022

    @melvin-bot

    @PauloGasparSv, @trjExpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

  18. trjExpensify commented on Dec 8, 2022

    @trjExpensify
    Contributor

    Okay, this has been deployed to production. I'm unable to reproduce it on the latest. @aimane-chnaif @PauloGasparSv can you give it a try for a secondary check and then we'll close it out.

  19. PauloGasparSv commented on Dec 8, 2022

    @PauloGasparSv
    Contributor

    Cannot reproduce the issue here! Let's close this off : )

  20. aimane-chnaif commented on Dec 8, 2022

    @aimane-chnaif
    Contributor

    @trjExpensify The root cause of this issue is different from my PR trying to solve. I think it's a regression of PR #12735, and has been solved by PR #12917, issue not reproducible on latest main branch.

    Maybe we should wait PR #12917 hit production, and close this issue.

    This analysis should be correct. Not reproducible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions